Carousel Enhancements

jdrassa

One additional question for the theme makers. The unselected logos have their opacity set to 0x80. I am also going to allow this value to be set by themes. Any preference on whether it is set as a hex value as above or as a decimal value?
i.e.
0x00 vs 0
0x80 vs. .5
0xFF vs 1

lilbud

@jdrassa Probably keep it as decimal values, keep it inline with everything else.

mattrixk

@jdrassa: I think I'm with @lilbud on this one. It's probably best to keep everything the same.

On a related note, are we going to able to colour the individual logos on the System View?

Eg: in nes/theme.xml having the code

<image name="logo">
  <path>./logo.png</path>
  <color>FF0000FF</color>
</image>

Would turn the NES logo red (if it were a white image). We can still use FF000080 to make it transparent.

ruckage

@jdrassa
This would be a great addition and something I was hoping for.

I'm with @mattrixk. Having it as Hex and part of a color option would make the most sense as that's the way it's handled for every other element. Plus it then gives us the bonus of colouring the logos as we can with other elements.

So perhaps we could borrow a tag used in textlist for uniformity?

<Color>ABABAB00<Color>  *** Used to set color & alpha for all unselected logos
<selectedColor>ABABAB00</selectedColor> *** Used to set color & alpha for the selected logo

EctoOne

@mattrixk Isn't that already possible? I did that when I modified your IO theme and was able to delete all of the white system.svg (I had to keep the dark logos because that was before the carousel was themable) you had and used the color tag to change the color of the logos in detailed, basic view.
Oh, but if I remember right I tried that with png files and it did not work. So maybe it only works on svg.

mattrixk

@ectoone I can't remember the exact details, but I think that while it worked okay in Basic and Detailed, it didn't really carry over to the System View.

EctoOne

@mattrixk Oh yeah stupid me. I even said that I tried it before the carousel was themable. So I'm not sure if I ever tried it with png or svg.

jdrassa

@mattrixk said in Carousel Enhancements:

On a related note, are we going to able to colour the individual logos on the System View?

Eg: in nes/theme.xml having the code
<image name="logo">
  <path>./logo.png</path>
  <color>FF0000FF</color>
</image>

You should be able to do this now. I added this when I implemented theme variables.

@ruckage said in Carousel Enhancements:

So perhaps we could borrow a tag used in textlist for uniformity?
<selectedColor>ABABAB00</selectedColor> *** Used to set color & alpha for the selected logo

The problem with this approach is that the logo color can be set per system. I may just hold off and implement the opacity changes separately, so I can think about it more and try out a few approaches.

EctoOne

@jdrassa said in Carousel Enhancements:

@mattrixk said in Carousel Enhancements:
On a related note, are we going to able to colour the individual logos on the System View?

Eg: in nes/theme.xml having the code
<image name="logo">
  <path>./logo.png</path>
  <color>FF0000FF</color>
</image>
You should be able to do this now. I added this when I implemented theme variables.

Ok, tried that and it only works for svg files, not png.

Edit: Scratch that. The color only covers white pixels. So to make use of it, we need to use images which are as white as possible. Although it might be possible to create some special effects if multicolored images are used.
I only had the issues that I had a pure black logo.png and compared it with a mostly white svg.

EctoOne

Am I stupid or is horizontal_view not an option!? Because it's kinda confusing to use Up/Down while browsing on this carousel.
alt text

lilbud

@ectoone Okay, that is friggin cool looking

jdrassa

@ectoone It is not currently, I had intended ask if there was demand for it, but forgot. I will get it added in the near future.

EctoOne

@jdrassa OK good, thought I had missed something again.

EctoOne

Since i hate waiting (no offence), i had to find a way to reduce the confusion i had when using the horizontal wheel with Up/Down keys.
This is what i came up with:
alt text
To make it clear: The 5 smaller Metroids are the system logos on the actual carousel, and i've used the system.fullName variable to see what system is selected.

lilbud

@ectoone As a Metroid fan, thats frickin cool.
0_1504027103520_a63dcdac-aa49-4a4a-af11-63782718bdc4-image.png

EctoOne

@lilbud I always wanted to make a Metroid theme but I was never satisfied with the results. With the new enhancements, I'm now at least quite comfortable with the system view (Credits to Andrew Ariza for the image).
And I'm actually a bit surprised by the result I got by using the carousel, with a static system logo, to create some sort of animation. Saved me a lot of work, because I thought I had to create matching logos for each system.
Still need to figure out what to do with with detailed view tho. I have a rough version, but I'm not satisfied yet. It's hard to find a good wallpaper and a layout where the colors are readable without having to use semi-transparent boxes as element background.

jdrassa

@ectoone would you mind posting your carousel config? It would be helpful for testing. Thanks.

EctoOne

@jdrassa Sure thing.

<!-- SystemCarousel -->  
<feature supported="carousel">
 <view name="system">
  <carousel name="systemcarousel">
   <type>vertical_wheel</type>
   <origin>0.5 0.5</origin>
   <pos>0.5 0.82</pos>
   <size>1 1</size>
   <color>00000000</color>
   <logoScale>2</logoScale>
   <logoSize>0.1 0.1</logoSize>
   <maxLogoCount>5</maxLogoCount>
   <logoRotation>35</logoRotation>
   <logoRotationOrigin>0.5 -4</logoRotationOrigin>
  </carousel>
 </view>
</feature>

jdrassa

@EctoOne Is that from the metroid theme? Could you post the planet one as well?

EctoOne

@jdrassa Here ya go:

<!-- SystemCarousel -->  
<feature supported="carousel">
 <view name="system">
  <carousel name="systemcarousel">
   <type>vertical_wheel</type>
   <origin>0.5 0.5</origin>
   <pos>0.5 0.5</pos>
   <size>1 1</size>
   <color>00000000</color>
   <logoScale>1.9</logoScale>
   <logoSize>0.125 0.160</logoSize>
   <maxLogoCount>5</maxLogoCount>
   <logoRotation>15</logoRotation>
   <logoRotationOrigin>0.5 11.5</logoRotationOrigin>
  </carousel>
 </view>
</feature>

Can i go to bed now? :)