Scripting help for replacing retroarch.cfg

FlashPC

@meleu I like the idea, apart from the fact that they could potentially change aspects of the emulators, plus I can only seem to access the runcommand menu via a keyboard, and I am trying to change these with a controller only.

@tmntturtlguy I ran the script and it is nice, but is there anyway control could be made with the controller. just like the way retropie_setup.sh does?

TMNTturtlguy

@flashpc it should work with your controller. Did you follow the instructions and place the script in retropie menu folder? If run from the retropie menu it will run with a properly configured controller that is recognized as the first player.

FlashPC

@TMNTturtlguy yeah you are right, it just works in emulationstation, I've manage to get it working within attract mode using joymap, like the old days and KODI.

I really like the script, is there a way in which the first menu has you select the console and then a second menu will ask you to select a config

I've changed the code slightly to match my setup, there is a lot of text, and it does work, I was just thinking once the system has been selected in the first menu can that variable be used to populate the file addresses in the second menu

For example if you select Playstation in the first menu then it knows to look in the 'psx' folder

Here is what I have so far

meleu

@flashpc said in Scripting help for replacing retroarch.cfg:

@meleu I like the idea, apart from the fact that they could potentially change aspects of the emulators,

Not sure what you mean here.

I can only seem to access the runcommand menu via a keyboard, and I am trying to change these with a controller only.

Every connected controller can invoke runcommand menu. After choosing a game to play press the button you set for A several times until runcommand menu appears.

FlashPC

@meleu from the runcommand you can select emulators for the complete system, as well as per game. If this is done and the game is not compatible with the new emulator then it wont load, (arcade for example) so I would like to avoid that as I will not be able to help once he takes the box away with him.

and I don't know about accessing the menu from a controller, I tap the 'X' on my controller which is set to A in emulationstation and it just loads the games, but pressing 'ENTER' on the keyboard works every time.

TMNTturtlguy

@flashpc Wow, you have done a lot of work on this! As far as adding a second menu, I am sure there is a way to do it. I am not an expert on scripts, i just know enough to be dangerous! So my short answer is, I don't know how to do it off hand. I would have to spend some time researching/playing with it. Maybe @meleu can share some insight on how to modify the main menu and and add a second menu for each console.

My other thought would be to simplify the entire script so that the end user only has 3 choices.

Standard
Shaders
Overlay

When they select any of the options, the script runs and sets all emulators to the same configuration. You would still have a separate retroarch.cfg file for each system as you currently do, so you can control the exact outcome of each system, it is just that when the user wants overlays on NES, then all systems will have overlays. In my opinion this is how I would set it up. It is clean and easy. The end user has 3 choices and running the script is fast and easy, so it isn't like it is that big of an issue to go in and change it.

FlashPC

@tmntturtlguy I decided to use 4 options so I could use an overlay with an additional transparent filter which gives a shine or glare on the screen.

meleu

Can you guys post your scripts on ghostbin (or something similar) instead of meganz? I'm unable to see the script on my phone when it's on meganz.

cyperghost

@meleu https://ghostbin.com/paste/ytrxt

It's ... well functional but a huge list with cp commands.
I would prefer your approach as it is the easier way without copy file -->> much better.

@FlashPC
Use submenu and case selection to get it functional calls

Mean...
Main list is SEGA CD -> Select overlay, shader..... for SegaCD

#### THIS IS PSEUDOCODE!!!

modemenu ()
{
until [[ $shaderchoice == "<--" ]]
do
    shaderchoice=$(whiptail --backtitle " Choose " --title " Choose " --menu "Choose an option" 0 0 0 \
        "<--" "... back to mainmenu" \
        "standard" "Reset retroarch.cfg" \
        "shaders" "Use Shaders...." \
       .....
done

case "$shaderchoice" in
    standard) cp -f /opt/retropie/configs/all/retroswap/$1/standard/retroarch.cfg /opt/retropie/configs/$1/ ;;
    shaders) cp -f /opt/retropie/configs/all/retroswap/$1/shaders/retroarch.cfg /opt/retropie/configs/$1/ ;;
esac
done
}

#----------------------------

while true
do
    syschoice=$(whiptail --backtitle " Choose " --title " Choose " --menu "Choose an option" 0 0 0 \
        "nes" "Nintendo Entertainment System" \
        "md" "Sega Megadrive" \
       .....
done


case "$syschoice"
    *) modemenu "$syschoice" ;;
esac
done

This will shrink your code to minimum :)

meleu

@cyperghost said in Scripting help for replacing retroarch.cfg:

@meleu https://ghostbin.com/paste/ytrxt

Wow! Pretty huge. It can be simplified, but if it works, then fine. I could help, but it seems to be a very specific script to @FlashPC needs. I'm not sure about the details in his config...

FlashPC

Hey guys I've filled in the script that @cyperghost posted and I kind of understand what is trying to happen, but Iam stuck as to what I am missing, I don't know how to add the nice black boxes but I've entered it into ghost paste here

cyperghost

https://ghostbin.com/paste/t7ws7

Here is a working script!
As I said --- it's was pseudocode with some errors
2x done without do, break condition was set wrong, dialogboxes showed unneeded options....

If you run this script you will see just 3do standard for ex. as output.. Therefore
You must exchange the commands in line 49-52 with your copy commands.

So you stripped down from 30kB to 3kB and can faster navigate ;)

Greetings fly out to @meleu (<--- this guy is responsible for my rising interest in bash) and @TMNTturtlguy (<--- this guy is responsible that I get in need to use bash ... EUREKA!)

FlashPC

@cyperghost Thanks, its so tidy

cyperghost

@flashpc Does it work for you?
Can you post the full script with all alterings please?

You can even alter the titles and backtitles of each menu for ex. like this --backtitle " Your selected console is ${1^^} " So you have an overview of your systemchoice if you want to exchange the shader. Just a convenient addon...

... There is a small bug Please add a return between line 53 & 54. I update code.

What is the difference between overlay and overlay-real?

TMNTturtlguy

@cyperghost said in Scripting help for replacing retroarch.cfg:

Greetings fly out to @meleu (<--- this guy is responsible for my rising interest in bash) and @TMNTturtlguy (<--- this guy is responsible that I get in need to use bash ... EUREKA!)

Greetings back to you @cyperghost! Hope all is well. I just come up with crazy ideas, and pretty down and dirty ways to try to make them work, you and @meleu are the true artists that clean up the messes I start!

cyperghost

@TMNTturtlguy Yes I'm fine. Thank you - it's always a pleasure to do some coding stuff

meleu

Nice job guys!

@cyperghost I would like to recommend this reading when you have a time: Importance of code indentation. ;-)

FlashPC

@cyperghost said in Scripting help for replacing retroarch.cfg:

... There is a small bug Please add a return between line 53 & 54. I update code.

I found that out, does the additional return clear the $shaderchoice variable? I just added "shaderchoice=" at the start of the modemenu routine and that allowed me to select another mode after returning the main screen

@cyperghost said in Scripting help for replacing retroarch.cfg:

What is the difference between overlay and overlay-real?

overlay has side art and a bezel around the screen, overlay-real is the same with an additional semi transparent layer over the play area to mimic sun glare and smears on an old CRT TV

The current script is here

Thanks again

meleu

@tmntturtlguy said in Scripting help for replacing retroarch.cfg:

you and @meleu are the true artists that clean up the messes I start!

haha! I tried to be an artist. I even created a blog with some drawings I made: https://meleuartblog.wordpress.com/

Stopped updating that 2 years ago...

@FlashPC sorry for this off-topic post on your thread. :)

cyperghost

@meleu Hehe... I like artists ;)
Drawing is good for relaxing and maybe once a time you come back to design studies. Believe me I've married a talented artist - my wife do great drawings if there is muse. You can do also good scratches with Corel Painter and a small Bamboo Tableu.

Btw.: This one is epic ;)

@FlashPC

I found that out, does the additional return clear the $shaderchoice variable? I just added "shaderchoice=" at the start of the modemenu routine and that allowed me to select another mode after returning the main screen

Yes that also helps, maybe it helps to declare shaderchoice as local variable.
You did a great job ;) Even if the coding is a bit "uncommon" ;) You use tons of if-then clauses to set a variable. Please don't see this as an offence but now you have to maintain two locations of systemnames. It's better to use an array for this and to create the menu out of this, too. But as the script works for you it's okay ....