shell scripting topic

[meleu]

@lilbud said in shell scripting topic:

@meleu The script would apply the overlay to all systems automatically.

I'm not sure if an overlay for all systems would look good. I think some systems have a different aspect ratio.

As @cyperghost said, we can help you once you start the coding. But maybe the fastest solution is to use rpie-art tool. Learning how to create an info.txt file is faster than learning a programing language.

Here is the info.txt creation doc: https://github.com/meleu/rpie-art/blob/master/INFO.md

[cyperghost]

@meleu Yes... therefore the runcommand-onstart. $1 shows current used system. So there is a way to set an overlay for a specfic system ... ;)

[lilbud]

@meleu @cyperghost I had this to start with:
sed -i 's/01.png/08.png/g' overlay.cfg

Something feels missing, not sure what at the moment.

[meleu]

@lilbud where is placed the script with that line of code? maybe you have to use the full path to the overlay.cfg.

[lilbud]

@meleu I believe it is placed in the overlay directory.

opt/retropie/configs/all/retroarch/overlay

[cyperghost]

@lilbud Just start coding use echo commands to show results in your bash
You can test sedcommands directly from CLI and results will be marked red.
Don't use -i parameter for testing... it will directly write to input file and may give unwantend results. If you want create altered files then work with direction > output-file first.

If all works then use -i

[lilbud]

@cyperghost Ok, I can get the original command to replace the text, but only if both fields are specified.

sed -i 's/01.png/08.png/g' overlay.cfg

This works fine, 01.png is replaced with 08.png. But what would I put in the first field if the overlay name is not 01.png. Something like this?:

sed -i 's/${FILENAME}.png/08.png/g' overlay.cfg

[mitu]

@lilbud You can use a wildcard:

sed -i 's/.*.png/08.png/g' overlay.cfg

Note that this will replace any <filename>.png in the file with 08.png.

[cyperghost]

@lilbud I'm still not sure what your goal is.
Anwer yourself:

1. Where is the overlay.cfg located?
2. In which case do you want to alter overlays?
3. Is there a "system" in altering names (Maybe $EMU-$ROMNAME-$TAG.png?)

Imho ... here's is a good script that writes several information in /boot/config.txt and checks existance of data before.

For graphics menu layout you can use this it uses arrays for graphics menu and here is a Howto for dialog/whiptail usage.

Here is the RetroPie wiki and how to input paramters into your script.

[lilbud]

@cyperghost okay

• Overlay.cfg located in default directory, /opt/retrofit/configs/all/retroarch/overlay

• The point of the script is to provide a way a to switch and choose the overlay from the retropie menu in ES.

• So choosing overlay named, '08.png, will do a few things. It will check for an overlay in use. If one is found, then the cfg file will be modified to show the path of the wanted overlay.png, (/my/awesome/overlay/8.png).

• Once the overlay is selected, the main retroarch.cfg will be modified with the viewport settings and the overlay.

Anything else needing further explanation?

[cyperghost]

@lilbud No I understood.
All the links I've provided to you will help you to code this.
Just start over with the selection menu ;)

[lilbud]

@cyperghost If I can find a way to get the script done during class, I'll see if I can work on it.

I think there is bash on my school computer...

[cyperghost]

@lilbud
Bash? School computer?

Code on your Pie!
All you need is a SSH terminal and nanoas editor

So you I would do the following.

1. You write a selection menu that provides a layout for selected system and save it to config
2. You write an "enabler" that sets overlay according to choosen system

;)

[lilbud]

@cyperghost I don't have access to my pi in school, besides, the schools network is locked to any device that isn't a school issued computer.

[meleu]

@cyperghost said in shell scripting topic:

For graphics menu layout you can use this

I'm afraid that a scriptmodule isn't a good example for starters ;-)

@lilbud said in shell scripting topic:

Anything else needing further explanation?

Yes, post your code in ghostbin or something so we can give more effective guidance.

[lilbud]

@meleu I'll have to redo it today, I'll post a link later.

[cyperghost]

@meleu Yes but for the sake of coding style

choice=$(dialog --command1 --command2 --menulist \
        1 Option 1 \
        2 Option 2 \
        redirection to ....)

is better coded in this script menu example ;)

dialogcmd=(dialog --command1 --command2 --menu)
dialogoptions=("1" "Option 1" "2" "Option 2")
choice=$("${dialogcmd[@]}" "${dialogoptions[@]}" redirection to)

And it will be much easier for bug hunting. Because structur here is clear. And this was my intention to bring this script module into game.
dialogcmd sets the structure of how the menu will looks like as array
dialogoptions is the data array for selection
and now with choice you put cmd and options together.

And I think this is a good example of clean coding ;)
Of course @lilbud will choose his own flavour later

[lilbud]

@meleu @cyperghost Here is my plan for the script: https://ghostbin.com/paste/6bbsa

not much in the way of code since I don't have a way to write/test it on my school computer.

[hiulit]

Hi there!

I've created my first shell script and I'd like your opinion, codewise.
It's a script to install some extras for RetroPie themes (icons, splashscreens and launching images).

The code is here: https://github.com/hiulit/es-theme-extras/blob/master/es-theme-extras.sh

I've created a post on this forum https://retropie.org.uk/forum/topic/13344/extras-for-retropie-themes-icons-splashscreens-and-launching-images-es_theme_extras-shell-script You can check it out to see more details.

Thanks! :)

[meleu]

@hiulit I saw that post. That's a pretty cool idea. I'm just a little busy with RL stuff, but I'll take a look at that soon. ;-)