Mausberry Shutdown Script Doesn't Save Metadata

meleu

@cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

please correct your ghostbin bash... there are small errors in... $emucall isn't definated - it should rather be $emupid

fixed! thanks!

emucall is emucall and emupid is emupid. ;-)

cyperghost

@meleu
No problem brother. I corrected it but used only emupid as variable :)
But it is better to repost code according to your latest changes. So there is one version 1.59 around

About using variables? You see I'm avoiding these and use just a bunch of them...
Is there any difference? Speed up? Memory usage?

I know it's better for clear code reading.... but is that effcient?

barrymossel

Sorry guys, I was busy drinking last night so I didn't test yet. Probably won't this evening. Will test later this weekend, but I am sure it works with the two of you working on it :)

barrymossel

Yup, seems to work. Thanks guys!

lostless

@meleu @cyperghost Hey, somthing has happened. The script no longer works in retroarch. This is recent as I just updated and a week ago it worked. so Kodi it kills, and will shutdown emulation station properly if its open, but will no longer kick retroarch back to emulation station to exit. It just says terminated and shuts down without saving meta data. Looks like it just gives up and does the old way of shutting down. also @cyperghost , my reset on my nespi no longer works with retro arch, kodi is fine, because of what ever has happened. WHY DID I UPDATE!!!!! LOL

meleu

@lostless can you please try this approach here?: https://retropie.org.uk/forum/topic/12895/ensuring-es-gracefully-finish-and-save-metadata-in-every-system-shutdown

lostless

@meleu I’ll take a look when I get home. Just To Verify, this is what I have running in my script. Is this the most up to date?

#!/bin/bash
# Terminate any emulatorcall!
# This works just for RetroPie!

 emucall="$(sed -n 4p /dev/shm/runcommand.info | tr -d '\\"' | tr '^$[]*.()|+?{}' '.')"
        if [[ -n "$emucall" ]]; then
            emupid="$(pgrep -f "$emucall")" 
            pkill -P "$emupid"
            kill "$emupid"
            sleep 4
        fi

cyperghost

@lostless Please use the approach @meleu posted...
The coding is the same but you don't need to modify the shutdown script itself!

meleu

@lostless please, when posting a code like that put it beetween codeblocks. More info here: http://commonmark.org/help/

lostless

Looks like I’m missing the “wait”at the end compared to the script I use for the reset button. I’ll add it in and see if it helps. The issue I’m having though is not meta data related. As I said. When in ES, it funtions fine. It’s just when in retroarch that it no longer exits back to ES. Kodi is fine. It was working fine until yesterday.

lostless

@meleu heres the script im using now, same issue

#!/bin/bash
# Terminate any emulatorcall!
# This works just for RetroPie!
emucall="$(sed -n 4p /dev/shm/runcommand.info | tr -d '\\"' | tr '^$[]*.()|+?{}' '.')"
# If there's an emulator running, we need to kill it and go back to ES
if [[ -n "$emucall" ]]; then
    emupid="$(pgrep -f "$emucall")" 
    pkill -P "$emupid"
    kill "$emupid"
    wait "$emupid"
    sleep 5 # maybe it can be lesser
fi

and errors im getting trying to exit out of retroarch

pkill: killing pid 1 failed: Operation not permitted
pkill: killing pid 2 failed: Operation not permitted
./exit.sh: line 9: kill: `': not a pid or valid job spec
./exit.sh: line 10: wait: `': not a pid or valid job spec

meleu

@lostless are you able to access your raspi via SSH while running an emulator?

If yes, I would like to ask you to do this:

launch a game.
access your raspi via SSH.
perform this command:

bash -x /path/to/the/emulator/killer/script.sh 2> debug.txt

The command above generates the debug.txt file. Post this file on ghostbin or something similar.

Thanks.

lostless

@meleu https://ghostbin.com/paste/qa5ph
Just want to say thanks for all your help.

lostless

@meleu Sorry, looks like copying from nano cut a lot off text. heres a good copy
https://ghostbin.com/paste/q9zsm

meleu

@lostless Thanks for this. I've found the problem. The runcommand.sh script changed a bit 3 days ago. I just have to adapt my Regular Expression and make it stronger. Wait a little, I'll try to sort it on our script.

meleu

@lostless I made my tests on a shell where there's no RetroPie installed and I believe it will work fine. But, you know, sh!t happens...

Try this version, please (feedback would be appreciated):

#!/bin/bash
# Terminate any emulatorcall!
# This works just for RetroPie!
emucall="$(sed -n 4p /dev/shm/runcommand.info | tr -d '\\"' | tr '^$[]*.()|+?{}' '.' | sed 's/[^ ]*=[^ ]* //g')"
# If there's an emulator running, we need to kill it and go back to ES
if [[ -n "$emucall" ]]; then
    emupid="$(pgrep -f "$emucall")" 
    pkill -P "$emupid"
    kill "$emupid"
    wait "$emupid"
    sleep 5 # maybe it can be lesser
fi

maybe I'll try to simplify that crazy line with a simpler regex later... ;-)

lostless

@meleu Its working in retroarch now im going to patch in into my mauseberry shutdown script!!!!!!!!!!!!!! YOU ARE THE MAN
But kodi is not working
https://ghostbin.com/paste/uqo6e
debug of kodi not exiting.
not a big deal if kodi does not work. Just kind of want my reset button to be the end all to go back to ES.

meleu

@lostless said in Mausberry Shutdown Script Doesn't Save Metadata:

But kodi is not working

Here it goes another version, trying to get kodi too:

# Terminate any emulatorcall!
# This works just for RetroPie!
emucall="$(sed -n 4p /dev/shm/runcommand.info | tr -d '\\"' | tr '^$[]*.()|+?{}' '.' | sed 's/[^ ]*=[^ ]* //g')"
# If there's an emulator running, we need to kill it and go back to ES
if [[ -n "$emucall" ]]; then
    emupid="$(pgrep -f "$emucall" | tr '\n' ' ')"
    pkill -P "$(echo $emupid | tr ' ' ',')"
    kill "$emupid"
    wait "$emupid"
    sleep 5 # maybe it can be lesser
fi

lostless

@meleu it works!!!!!! but now it looks like i blew out the gpio pin for my reset button. NOOOOOOOOOOOOOOOOO. That what i get for using a different build without gpio setup. GPIO DANGEROUS TO USE if not setup?

meleu

@lostless sorry, I didn't understand your last question...