EmulationStation Grid View v1 ready for wider testing

ruckage

@a12c4 said in EmulationStation Grid View v1 ready for wider testing:

@ruckage @lilbud @EctoOne I fixed a bug which caused the padding of the grid tile to be 2 times smaller than it should be. I wanted you to know it will be in next release in case you already started to build your theme.

The 2 other fixes (for horizontal grid position bug and enabling the grid crash) should also come soon.

Thanks, I'll keep that in mind. I look forward to the next update.

A12C4

The "infinite hang" when enabling the grid view should be fixed.
The horizontal grid position got fixed.

You can find this changes in latest release of Jdrassa's continuous build.

You may experience slows down while navigating big game collections, next big step will be to optimize the grid view code.

RxBrad

(using the latest continuous build for testing...)

I just added grid support to the Freeplay theme. Seems to be working pretty well.

I did notice that setting a backgroundImage on the gridtile reeeally slows down navigation. Also, backgroundCornerSize seems locked at 0 when setting a backgroundImage.

Also, just out of curiosity, what is the unit for the gridtile backgroundCornerSize & padding? Percent? Pixels?

A12C4

@rxbrad said in EmulationStation Grid View v1 ready for wider testing:

I did notice that setting a backgroundImage on the gridtile reeeally slows down navigation.

Maybe adding this image made you exceed your vRam limit. Have you changed that setting in the menu ? The default value is a bit short for the grid view as this view use way more images than usual.

Also, backgroundCornerSize seems locked at 0 when setting a backgroundImage.

Also, just out of curiosity, what is the unit for the gridtile backgroundCornerSize & padding? Percent? Pixels?

Pixels. I think you misunderstood what the backgroundCornerSizeis used for, check out what the ninepatch is.

RxBrad

@a12c4
vRAM was set at 384Mb, but the backgroundImage was just a 1px x 1px image I was using to set backgroud color (which I realized I didn't need in the first place, and removed it). I wouldn't think that would eat much memory.

And I guess I thought backgroundCornerSize was more of a radius for rounded corners, similar to what's in vector editing programs.

I think my main problem is probably that I don't understand ninepatch, I guess.

Padding in pixels does seem a bit unusual to me, given that most ES theming elements are measured in percent. (Maybe this is just more evidence that I don't understand ninepatch?)

paffley

@A12C4 Brilliant work on the update,Thank you! Works flawlessly on my pi 3. I have no issues with slowdown on background image added, running at 100mb vram. Tested on 1080p res and 720p res. Runs 'imo' perfect.

RxBrad

Had some issues with the grid view breaking my theme on a previous dev version of ES, so I had to temporarily remove the grid from my theme.

Not sure if it matters, but while trying to work around this, I noticed that the <feature supported="grid"> tag doesn't appear to be acknowledged by the current continuous build.

A12C4

@rxbrad said in EmulationStation Grid View v1 ready for wider testing:

Not sure if it matters, but while trying to work around this, I noticed that the <feature supported="grid"> tag doesn't appear to be acknowledged by the current continuous build.

You don't need that tag.

paffley

@A12C4 quick question......when using <scrollDirection> horizontal, it still uses the 'up' and 'down' controls, is there anyway if selecting 'horizontal' it could maybe cancel the up and down controls?

Keep up the great work :)

A12C4

@paffley You can still uses 'up' and 'down' because 'horizontal' doesn't mean it will be a single line ;)

paffley

@a12c4 said in EmulationStation Grid View v1 ready for wider testing:

@paffley You can still uses 'up' and 'down' because 'horizontal' doesn't mean it will be a single line ;)

Thanks @A12C4

paffley

@A12C4 have you had much feedback on the grid view? its absolutely flawless on my pi with latest build, I cannot pick anything out with it and that's not normal for me haha :)

A12C4

@rxbrad Have you found the root of the problem or any additionnal information about your issue when changing the background image ?

RxBrad

@a12c4 I actually haven't been able to reproduce it when fiddling around with it this morning. So, everything honestly seems to be working well in emulationstation-dev.

paffley

Hi @A12C4 any new news on the Grid? I was just wondering if you think v1 is good enough to move across to the stable release?

A12C4

@paffley I don't think the grid view will move to the stable branch anytime soon.

paffley

Hi @A12C4 any chance of adding '<scrollSound>' to the grid view please? I'm testing on pi3 on emulationstation-dev package.

A12C4

Hi @paffley , it was originaly planned for me to refactor the way the sounds are handled in EmulationStation, because I feel like it is done poorly, and I don't think I'm not the only one sharing this opinion seeing how often this discussion come back.

paffley

Hye @A12C4 thanks mate, yeh some seem to work and some do not. <scrollSound> to md_name would be cool for the grid view as this would work when flowing through the grid im guessing?. I love this grid view you've worked on, very very well done with this, its awesome! keep up the great work mate!

A12C4

@paffley <scrollSound> to md_name ? You mean to put the "scrollSound" tag on the md_name ? No that would be wrong, if I do a cheap implementation I would put it on the grid like you first said.

What I meant is, ultimately, a theme should be able to define sounds globally with a syntax like this :

<view name="grid, basic, detailed, video">
	<sound name="launch">
    		<path>./art/launch.wav</path>
    	</sound>
	<sound name="back">
		<path>./art/back.wav</path>
	</sound>
	<sound name="scroll">
		<path>./art/select.wav</path>
	</sound>
</view>

<view name="menu">
	<sound name="launch">
    		<path>./art/launch_menu.wav</path>
    	</sound>
	<sound name="back">
		<path>./art/back_menu.wav</path>
	</sound>
	<sound name="scroll">
		<path>./art/select_menu.wav</path>
	</sound>
</view>

That's what I planned to do originally and will see how it goes after I finish the grid view.