mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support

[grant2258]

I wonder if this could be causing the issue in the older cores never seen it set to null before.

https://github.com/mamedev/historic-mame/blob/dd2571a8c38e799cb50fb30f928fac293566e30c/src/drivers/n8080.c#L211

might be unrelated its complying about using memory after its been freed.

edit
strange does not happen when i put retroarch logging on(1.7.8) would need more looking into

[UDb23]

@arcadez2003 That overlay is a retroarch one, so it should not be related to any issue of the game code/driver.

[arcadez2003]

@grant2258 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

I wonder if this could be causing the issue in the older cores never seen it set to null before.

https://github.com/mamedev/historic-mame/blob/dd2571a8c38e799cb50fb30f928fac293566e30c/src/drivers/n8080.c#L211

might be unrelated its complying about using memory after its been freed.

edit
strange does not happen when i put retroarch logging on(1.7.8) would need more looking into

@grant2258 Thanks for taking a look, it seems that palette_init_n8080(NULL, NULL); is just telling the game not to use the n8080 palette by looks it serves no other purpose
removing it makes no difference but it was worth a try at anyrate.

[grant2258]

i had some time to look through some code and managed to start the game 10 times without crashing could can you try this on your test build and let me know how you get on mate. https://github.com/grant2258/mame2003-plus-barcade/commit/bfc7bfb3d1212b5110c5e05dfd77ac0a22e60ea3. PS ive only tested this on 64 bit could be a 64 bit issue will get the pi out when im off work will let you know if it works on that.

[arcadez2003]

@grant2258 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

i had some time to look through some code and managed to start the game 10 times without crashing could can you try this on your test build and let me know how you get on mate. https://github.com/grant2258/mame2003-plus-barcade/commit/bfc7bfb3d1212b5110c5e05dfd77ac0a22e60ea3. PS ive only tested this on 64 bit could be a 64 bit issue will get the pi out when im off work will let you know if it works on that

Nah no joy, but it's as you suspected a problem with the palette rather than the CPU's where my attention was focused, you'd think the compiler would have spat out
a warning or two about this or the game would have booted with messed up gfx rather than stalling on boot which made me think it was a CPU communication problem.

Anyway good job hopefully it'll work with your changes on the platforms that use this core.

EDIT
i checked out the core gfx in MAME72 vs 84 where Heli Fire actually works and apart from the palette handling it's on a par more or less in both builds, anyway outta
curiosity i updated the palette code to MAME84 and whatya know the game still wont boot, i think there's more going on here than just the palette code in the driver
causing issues in MAME78 if you can sort this you'll deserve a medal :)

[grant2258]

It was very tempremental worked sometimes and not others. Just mark it not working for now seems like a good idea until its fixed. If I manage to find anything ill post and let you know dont want to fill up the posts here with it. It might naw be the palette just was the first thing i noticed time will tell.

[darknior]

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@darknior Link

Many thanks, i have take it i will try to make me a good rom pack :)

And thanks too @arcadez2003 to update it too ;)
https://github.com/libretro/mame2003-plus-libretro/blob/fbdc5f482355a7e2eb7b6c7f01d7d1bdf7d9b61a/metadata/mame2003-plus.xml

[WeirdH]

@grant2258 Is it possible that palette changes also affected colors in other games?

Because I might be imagining things, but since the update some effects in Storm Blade have been multi colored where they didn't use to be (shockwave before enemies explode and apparently some shadows). At least to the best of my recollection. Again, I might be remembering wrong, was just wondering about it, because I noticed it yesterday.

[arcadez2003]

And thanks too @arcadez2003 to update it too ;)
https://github.com/libretro/mame2003-plus-libretro/blob/fbdc5f482355a7e2eb7b6c7f01d7d1bdf7d9b61a/metadata/mame2003-plus.xml

@grant2258 did all the graft i just copied and ported across his xml :)

[arcadez2003]

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@grant2258 Is it possible that palette changes also affected colors in other games?

Because I might be imagining things, but since the update some effects in Storm Blade have been multi colored where they didn't use to be (shockwave before enemies explode and apparently some shadows). At least to the best of my recollection. Again, I might be remembering wrong, was just wondering about it, because I noticed it yesterday.

A year or so back we ported some video changes from later MAME for Storm Blade and Ultra X Weapons to fix the colours and graphical problems............

https://github.com/libretro/mame2003-plus-libretro/commit/dcab429899470b1d893a0b3f660fbc7f4211eda8#diff-e19b55627b841d35ec504da4089655c4

[akafox]

I am correct that not all games have been optimized or for this core..yet every game that runs on the mame 2003 core should work on the mame plus core?

I ask because I was running LibreELEC (kodi) on my pi 3 and using retroplayer within kodi and Advanced Emulator Launcher..I loaded DK (dkong.zip) and it ran poorly with the plus core..but just fine with the standard core.

(yes I mentioned that on the kodi forums already. Just the gaming community is much larger here.)
(I will admit I have not had much use of the plus core...yet...)

[Riverstorm]

@akafox - Their are actually around a dozen "B" games that only exist in mame2003 but for the most part the ROM sets are identical (minus the m3plus exclusives) and should all work fine in either core. I mainly use m3plus and as far as I know dkong was running fine as of the last commit at around 60 FPS. Both cores use the same ROM set and I believe the same driver code. I've never tried Kodi so I don't know if that could be part of the issue.

[arcadez2003]

@akafox said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

I am correct that not all games have been optimized or for this core..yet every game that runs on the mame 2003 core should work on the mame plus core?

I ask because I was running LibreELEC (kodi) on my pi 3 and using retroplayer within kodi and Advanced Emulator Launcher..I loaded DK (dkong.zip) and it ran poorly with the plus core..but just fine with the standard core.

(yes I mentioned that on the kodi forums already. Just the gaming community is much larger here.)
(I will admit I have not had much use of the plus core...yet...)

The only difference with Donkey Kong in this core over MAME2003 is that it uses newer and improved samples, and @grant2258 made a small fix for the gfx decoding
that's it more or less and i seriously doubt that would cause a drop in the performance dept.

[akafox]

thank you both.

Yeah it may just have something to with kodi itself or the porting the core from a real libreto core to a kodi add-on. Not a deal breaker just curious. I'll keep you posted from the other forum if you want.

I can launch kodi from ES sure but never could never figure out how to get into kodi and then exit it cleanly back into ES without a reset of the system. It's nice to have a "all-in-one" entertainment box but then again two PIs are better than one I guess? :P

Okay I am not going to hijack this thread so back on topic...

is there a one stop place I can look to find a list of improvements or/and "m3plus exclusives" that is available? And thank you for your HARD work (yeah we used to be called coding wizards...but honestly if we were wizards you think we would code instead of making gold out of air? xD )

[arcadez2003]

@akafox said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

thank you both.

Yeah it may just have something to with kodi itself or the porting the core from a real libreto core to a kodi add-on. Not a deal breaker just curious. I'll keep you posted from the other forum if you want.

I can launch kodi from ES sure but never could never figure out how to get into kodi and then exit it cleanly back into ES without a reset of the system. It's nice to have a "all-in-one" entertainment box but then again two PIs are better than one I guess? :P

Okay I am not going to hijack this thread so back on topic...

is there a one stop place I can look to find a list of improvements or/and "m3plus exclusives" that is available? And thank you for your HARD work (yeah we used to be called coding wizards...but honestly if we were wizards you think we would code instead of making gold out of air? xD )

https://github.com/libretro/mame2003-plus-libretro/blob/master/CHANGELOG.md

[WeirdH]

@arcadez2003 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@grant2258 Is it possible that palette changes also affected colors in other games?

Because I might be imagining things, but since the update some effects in Storm Blade have been multi colored where they didn't use to be (shockwave before enemies explode and apparently some shadows). At least to the best of my recollection. Again, I might be remembering wrong, was just wondering about it, because I noticed it yesterday.

A year or so back we ported some video changes from later MAME for Storm Blade and Ultra X Weapons to fix the colours and graphical problems............

https://github.com/libretro/mame2003-plus-libretro/commit/dcab429899470b1d893a0b3f660fbc7f4211eda8#diff-e19b55627b841d35ec504da4089655c4

Are you saying I should not be seeing colors glitching then?

[arcadez2003]

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@grant2258 Is it possible that palette changes also affected colors in other games?

Because I might be imagining things, but since the update some effects in Storm Blade have been multi colored where they didn't use to be (shockwave before enemies explode and apparently some shadows). At least to the best of my recollection. Again, I might be remembering wrong, was just wondering about it, because I noticed it yesterday.

A year or so back we ported some video changes from later MAME for Storm Blade and Ultra X Weapons to fix the colours and graphical problems............

https://github.com/libretro/mame2003-plus-libretro/commit/dcab429899470b1d893a0b3f660fbc7f4211eda8#diff-e19b55627b841d35ec504da4089655c4

Are you saying I should not be seeing colors glitching then?

Not that im aware of, show me a pic

[WeirdH]

@arcadez2003 Okay, some horrible phone pics, but the problem is visible. It appears when a shockwave of an exploding enemy overlaps with a shadow in the background. (these same shadows appear red when using mame2003, by the way)

[arcadez2003]

Ok thanks for taking the time to upload some pics, i can confirm im not getting this in my test build, but as i always say it's different MAME72 standalone emulator
on a different platform although the driver for this game and the video code are identical in both builds, is anyone else getting these graphical problems
when playing Storm Blade in this core.??

[Riverstorm]

I am seeing the same issue running RetroPie 4.5.1 and m3plus commit 0278635 on a Pi 3. Screenshot below: