Grid Updates - emulationstation-dev

jdrassa

@paffley said in Grid Updates - emulationstation-dev:

In fact, I don't think its picking up any of the settings in the gridtile default and selected. Hope this helps.

There is a bug in the assignment of the gridtile properties. I am preparing a PR and it should be merged within the next day or two.

@paffley said in Grid Updates - emulationstation-dev:

@jdrassa in theory majority of the new updates you are doing could be adapted within the <imagegrid> tag and make the <gridtile> tags redundant? is that your thinking or plan?
The majority of your updates make the <gridtile> tags unnecessary imo.

Some of the new options like autoLayout and autoLayoutSelectedZoom simplify the need to set specific sizes, but there are no plans to remove <gridtile>

sergioad

@jdrassa could / might you restore the slide minimal transitions to ES? Some time ago it was added but then deprecated and was my favorite transitions, it animated the game lists when you switch system not leaving the gamelists and when launching a game and the transition from the carrousel to the gamelists but it did not animated the carrousel background (not the carrousel itself), it was elegant and perfect for themes like NES mini, SNES mini, Switch and many other themes

paffley

@jdrassa said in Grid Updates - emulationstation-dev:

There is a bug in the assignment of the gridtile properties. I am preparing a PR and it should be merged within the next day or two.

Thank you :) I'll keep an eye out and run some more tests.

Do you still need the selected image from your post above?

The autoLayout and autoLayoutSelectedZoom are great additions and will make life a lot easier for boxart. I had a previous discussion with @ruckage about this on one of this themes (regarding specific grid sizes for specific systems etc for boxart for the end-user - this solves that issue).

jdrassa

@paffley The fix should now be in emulationstaiton-dev.

paffley

@jdrassa said in Grid Updates - emulationstation-dev:

@paffley The fix should now be in emulationstaiton-dev.

Perfect - all working great Thanks @jdrassa

This has changed the game completely for the grid view! All possibilities now!

paffley

Found a bug @jdrassa

<animate> tag does not work with either

<animate>true</animate>

or

<animate>false</animate>

It crashes the theme when inputted into the <imagegrid> section.

Hope this helps.

jdrassa

@paffley This should be fixed now. animate got left of the list of supported theme elements.

paffley

@jdrassa said in Grid Updates - emulationstation-dev:

@paffley This should be fixed now. animate got left of the list of supported theme elements.

Super, thanks @jdrassa i'll have a play with it shortly - loving your work, thank you :)

paffley

@jdrassa all seems to work fine with true and false for <animate>, your a star! :)

I'm not asking for straight away but when you get some free time would you be able to look at adding a <scrollSound> to the imagegrid please, I believe then it would be a complete view of its own :)

I believe someone was looking at this a while back but it never materialised and think they have disappeared now.

Thanks again for the updates, really appreciate it. Looking forward to releasing some grid themes!

paffley

Hi @jdrassa I've ran vigorous tests with the new updates you've done on the grid and all seems to work fine! It's ten times better than the previous grid release. Thanks again for all your hard work :)

Do you think it would be merged to the official retropie release?

sergioad

@sergioad said in Grid Updates - emulationstation-dev:

@jdrassa could / might you restore the slide minimal transitions to ES? Some time ago it was added but then deprecated and was my favorite transitions, it animated the game lists when you switch system not leaving the gamelists and when launching a game and the transition from the carrousel to the gamelists but it did not animated the carrousel background (not the carrousel itself), it was elegant and perfect for themes like NES mini, SNES mini, Switch and many other themes

@jdrassa could you?

jdrassa

@sergioad There are no plans to add it back. However, one thing I would like to look into is giving themes more control over animations/transitions. If I ever get to it, it would probably enable themes to recreate something very similar.

sergioad

Cool

paffley

@jdrassa hi, I think I found another bug, only small.

When adding...

<imageSource>image</imageSource>

it still picks up the <image> folder and therefore does not display whats in the marquee tag.

Hope this helps.

jdrassa

@paffley I submitted a PR to fix this. It should be merged in the next few days.

paffley

Thanks @jdrassa i'll keep my eye open and run another test :)

paffley

Hi @jdrassa have you seen this pr - https://github.com/RetroPie/EmulationStation/pull/623

Looks pretty interesting for the grid view :)

jdrassa

@paffley I did. I've been swampped and haven't had much time to look at it. Hoping to get to it over the holidays.

paffley

Thanks @jdrassa your a star :) no rush dude, I know holidays are busy, looks like a good addition tho :)

meleu

just a reminder:
testers can use the tool I mention in this thread to help developers with their work.

Cheers!