Pegasus theme development general

fluffypillow

@PlayingKarrde It seems there's no built-in way to get the the current locale, so I'll add something for that. In a theme that'd look something like

you add a theme option (think a simple dropdown list) for selecting a language out from those that your theme supports
on loading/change you set it to the one Pegasus uses or to some fallback

You can add support for languages not supported by Pegasus, as it'll be just a theme option. Languages have a code like "en-US" and "en-GB", so you'd be able to make a difference or use a general "English" based on that.

I can also add translations if someone makes them :) I was also thinking about making a translation site, just haven't had the time yet.

@SinisterSpatula Such slowdown is very interesting, the memory of the Pi shouldn't be that slow. This will need some more debugging. Could you record a video of it?

As for jumping from the last to the first element, you can use keyNavigationWraps.

@PlayingKarrde by don't depend, I mean it's not officially part of the Keys yet (ie. undocumented), I think I might change it from being a function to a regular property before first. But yes, that's something you'd use for for actually showing the name of the keys. One shouldn't depend on the the text either, as it may return different names on different languages/platforms (eg. Mac).

PlayingKarrde

@fluffypillow said in Pegasus theme development general:

by don't depend, I mean it's not officially part of the Keys yet (ie. undocumented), I think I might change it from being a function to a regular property before first. But yes, that's something you'd use for for actually showing the name of the keys. One shouldn't depend on the the text either, as it may return different names on different languages/platforms (eg. Mac).

Gah ok how can I get something that is consistent and platform agnostic from that then?

fluffypillow

The key and modifier fields should be same across platforms (they are actually just numbers), it's the displayed name that's different, Like Ctrl turns into Option (I think?) on Mac. The list of possible key values is listed here (you can eg, do if (key == Qt.Key_X) //do something ), and modifiers are listed here. Gamepad keys have their own key code, I think I've listed them here somewhere but I'll also document them eventually.

PlayingKarrde

Hmm ok. I will brute force it then. It's not ideal but also not the end of the world since there aren't THAT many controller buttons.

fluffypillow

@PlayingKarrde one sec and I'll provide a list :)

fluffypillow

@fluffypillow here's the order, the number grows by one on every button after A

A = 0x100000,
B,
X,
Y,
L1,
L2,
L3,
R1,
R2,
R3,
SELECT,
START,
GUIDE,

PlayingKarrde

@fluffypillow Oh ok that's easier than I thought. Although those aren't the results I was getting in my tests, I'll try them and see. Thanks!

PlayingKarrde

For anyone else that wants to do this, this is the function I made:

function processButtonArt(buttonModel) {
    var i;
    for (i = 0; buttonModel.length; i++) {
      if (buttonModel[i].name().includes("Gamepad")) {
        var buttonValue = buttonModel[i].key.toString(16)
        return buttonValue.substring(buttonValue.length-1, buttonValue.length);
      }
    }
  }

Then passing in the key (ie processButtonArt(api.keys.cancel)) . This obviously isn't super ideal since it's currently relying on name() but it's the only way I could find to discern between a gamepad and key for now (if there's a better way I'm happy to change) but this is working for me for now.

AndersHP

How come I have perfect game audio when running the default pegasus theme, but have no audio when switching to other themes?

fluffypillow

@AndersHP Interesting, so you have no audio in-game if the theme is set to something else than the default theme? Does this happen also if Pegasus was launched with the other theme already set or only after you change it in the menu? Does it happen on different devices too? Does it happen with all themes?

AndersHP

Just tested.
I have tested GPiOS theme and GameOS theme, and there's no ingame sound in any of them. I tried changing theme and rebooting, and also shutting down+restarting, there's no sound no matter what I do.

After reverting back to the standard grid theme, the sound is back instantly.

PlayingKarrde

@AndersHP But do you mean no sound in the theme or no sound when playing a game?

AndersHP

@PlayingKarrde
No sound in games at all. Haven't got any video previews so haven't considered if the sound is working in the theme.

fluffypillow

@AndersHP Does it happen with these two themes too?

AndersHP

@fluffypillow
Strangely enough, these two themes work fine, including backgroundmusic in the 9999999-in-1 theme.