Updated EmulationStation for Windows

Joss

Judging from the screenshots, descriptions and videos online you have done a marvellous job of improving the ES experience on Windows! Thank you!! I am particularly happy that you get rid of the console window before and after game launch.
However - maybe it is just my incompetence, but - I cannot get your version running properly:
I have your just-updated continuous-build ES installed. If I run it it exits right after the start. So I copied es_settings.cfg (from my perfectly working jrassa version to the .emulationstation folder). If I run it now I have a working version, which, however looks pretty ugly. So I created a themes folder under .emulationstation and copied a few regular ES themes there (e.g. TronkyFran, Carbon, Simple). Now it gets better, however whichever theme I chose, the page of any emulator (where I can browse the games) is broken:
https://drive.google.com/open?id=1E0GbAhzTf_5Z5wmm0O4m0z2RcNKBL2HU
all text are stuffed at the top and written on one other, while screenshots, box graphics are not displayed.
The Game List View Style setting is Detailed. (The only other option is Basic - if I chose it, only the console name is displayed nothing else, so it is not good, either).
What do I miss?

Thank you so much,

Joss

f.caruso

@Joss I don't know I never saw something like that. I've tested all the themes you name and they are working fine with my latest build. Plus, ES starts fine without any es_settings.cfg file...

f.caruso

@lopapa The exe you name is the good one... I don't know how to help you, in the code the log file is always created when the program runs.

Joss

@f-caruso
Ok then. I will do another clean install to give it one last desperate try. What downloadable do you suggest to use?
Previously I used https://github.com/fabricecaruso/EmulationStation/releases/download/continuous-master/EmulationStation-Win32.zip
Is there a dedicated folder it should be installed to?
Thanks.

f.caruso

@Joss Yes... And No. also, place your .emulationstation folder inside exe's directory, app is portable.

lopapa

@f-caruso

Hello,

Thank you for all the attention you've given, I really, really appreciate it. Let's see if in the future I can find out what's going on.
For now, I will have to look for alternatives to close the active window.

Greetings,

CarissaIsWierd

@f-caruso

I love the updates you've been making! With the changes made to folders, is it possible to add an option to show folders at the bottom of a list? And maybe an option to hide the new back entry when accessing a folder?

Joss

@f-caruso
Hi Fabrice,

The reinstall did not help, however I found the source of the issue with broken rendering: it is in the regional settings. While the original ES considers the number format, your updated version seems to ignore it (or maybe it's the other way around: uses the local number format when it should ignore it). In Hungary we use ',' as the decimal separator, and naturally this is the Windows default on my machine. Since themes operate with decimal numbers between [0..1) digits after the decimal points were ignored resulting in (0,0)-size images and (0,0) text positions.
When I temporarily I set the separator to '.', suddenly everything renders O.K. Can you please look into this minor glitch?

Otherwise it works wonderfully! Thank you for all the effort you put into this vastly improved ES version!!!

Two minor problems I noticed- but I guess you are already aware of those:

the ScreenScraper scraper gives HTTP ERROR 246 now, the GamesDB works as expected,
when I move the highlight to the VRAM LIMIT slider by using the controller's cursor keys, the highlight keeps moving forward in the menu (I am using Logitech F310).

Thank you again!!!

f.caruso

@Joss Thanks for the diagnostic. Strangely, I'm french & in french decimal use commas ',' too... I'll investigate it..
About screenscraper, they blacklisted my Fork. I contacted them & solved the problem yesterday but you need to update with the latest.
EDIT : I just changed a setting in locale management, can you take the last version & tell me if the comma problem is solved ?

Joss

@f-caruso
That was fast!!!
I reset my region settings and the layout remained perfect - just as expected :)
Also, screenscraper works O.K. now.
Thank you so much, I really appreciate your enthusiasm!

jero

@f-caruso

Hi Caruso, thanks as always for your work.

I have not used ES for a while, but when I returned I have seen that you have made changes with the folders and so on. Now it does not work for me, for example: I had a written xml to load an image to a folder, also to select in the list of games entered the folder and the three games came out each with its image and inside games with their different images. Now the image of the folder does not appear and if the one of the games, but these are the same level as the other games in the list. I hope you can understand what I mean.
I have tried new attributes in the menu about hidden folders and files and nothing.

Another thing, I liked the clock a lot. Is there any way to change the font, size, color and position? In addition to the clock, you have thought about setting a date, hehe, it would be very projejej.

messeduprex

i must be a special kind of stupid. i installed cmake but i cannot for the life of me get either repos to compile

f.caruso

@jero said in Updated EmulationStation for Windows:

I hope you can understand what I mean.

Sorry, I don't really understand your explanations... ( Do you use a translator ? ) Maybe post screenshots before/after...
Also the clock is customizable, see the 3 themes on my git for samples ( element <text name="clock"> that has to be described in a <view name="screen"> )

Tromzy

Hi @f-caruso ,

I use your fork on ArchLinux, I used to compile it from git and it worked, but since a few days I get this error when compiling :

[ 18%] Building CXX object es-core/CMakeFiles/es-core.dir/src/ThemeData.cpp.o
Dans le fichier inclus depuis /home/tromzy/EmulationStation/es-core/src/components/VideoComponent.h:6,
depuis /home/tromzy/EmulationStation/es-core/src/components/VideoVlcComponent.h:5,
depuis /home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:6:
/home/tromzy/EmulationStation/es-core/src/components/ImageGridComponent.h: Dans la fonction membre « void ImageGridComponent<T>::updateTileAtPos(int, int, bool, bool) »:
/home/tromzy/EmulationStation/es-core/src/components/ImageGridComponent.h:803:100: erreur: « PLACEHOLDER » n'a pas été déclaré dans cette portée
803 | >getType() == 2 || (mEntries.at(imgPos).object->getType() == PLACEHOLDER && mEntries.at(imgPos).object->getPath() == ".."))
| ^~~~~~~~~~~

/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp: Dans la fonction membre statique « static const std::shared_ptrThemeData::ThemeMenu& ThemeData::getMenuTheme() »:
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:399:15: attention: retourne une référence vers un temporaire [-Wreturn-local-addr]
399 | return std::shared_ptrThemeData::ThemeMenu(new ThemeMenu(&emptyData));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp: Dans la fonction membre « void ThemeData::parseViewElement(const pugi::xml_node&) »:
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:610:41: erreur: impossible de lier la référence d'une l-valeur non constante de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>& » à une r-valeur de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> »
610 | ThemeView& view = mViews.insert(std::pair<std::string, ThemeView>(viewKey, ThemeView())).first->second;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dans le fichier inclus depuis /home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:1:
/home/tromzy/EmulationStation/es-core/src/ThemeData.h:342:119: note: initialisation de l'argument 1 de « std::pair<__gnu_cxx::__normal_iterator<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>*, std::vector<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> > >, bool> ThemeData::UnsortedViewMap::insert(std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>&) »
342 | >::iterator, bool> insert(std::pair<std::string, ThemeView>& item)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp: Dans la fonction membre « void ThemeData::parseCustomView(const pugi::xml_node&, const pugi::xml_node&) »:
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:769:39: erreur: impossible de lier la référence d'une l-valeur non constante de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>& » à une r-valeur de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> »
769 | ThemeView& view = mViews.insert(std::pair<std::string, ThemeView>(viewKey, ThemeView())).first->second;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dans le fichier inclus depuis /home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:1:
/home/tromzy/EmulationStation/es-core/src/ThemeData.h:342:119: note: initialisation de l'argument 1 de « std::pair<__gnu_cxx::__normal_iterator<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>*, std::vector<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> > >, bool> ThemeData::UnsortedViewMap::insert(std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>&) »
342 | >::iterator, bool> insert(std::pair<std::string, ThemeView>& item)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

make[2]: *** [es-core/CMakeFiles/es-core.dir/build.make:258: es-core/CMakeFiles/es-core.dir/src/ThemeData.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:218: es-core/CMakeFiles/es-core.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

Any idea ? Thanks !

f.caruso

@Tromzy said in Updated EmulationStation for Windows:

Yes. PLACEHOLDER has to be replaced with 3, I didn't commit it yet...

Tromzy

@f-caruso OK ! I'll just wait, then. Thanks for your great work !

lopapa

@f-caruso
Hello,

Is there any way to configure a retroarch platform with more than one core, for example MAME --> mame, mame087 and apart, another external emulator such as dolphin?
So in the emulationstation menu you can select emulate with a retroarch emulator and be able to select the core I want to use or select a standalone emulator that is not retroarch.

I haven't been able to see how to do it.

(I know it may make little sense to put MAME with Dolphin, but it's the first thing that came into my head)

Thank you!

jero

@lopapa In this link is the information on how to use several cores. Get down a little with the mouse and in "Changes in my branch", this is what you are looking for.

https://github.com/fabricecaruso/EmulationStation

@f-caruso said in Updated EmulationStation for Windows:

@jero said in Updated EmulationStation for Windows:

I hope you can understand what I mean.

Sorry, I don't really understand your explanations... ( Do you use a translator ? ) Maybe post screenshots before/after...
Also the clock is customizable, see the 3 themes on my git for samples ( element <text name="clock"> that has to be described in a <view name="screen"> )

It was just my problem, I wasn't doing something right hehehe

jero

This post is deleted!

lopapa

@jero
Thanks but the cores of the same emulator for retroarch already work for me correctly thanks to the manual that you indicate of the web page. The problem I pose is to configure a standalone emulator independent of retroarch and at the same time a retroarch emulator with its cores.
Having only one tag <command> I don't know how to make the call discriminating