Updated EmulationStation for Windows

f.caruso

@ThePlagueIsBack Ran some tests. Problem occurs only with exclusive fullscreen ( using --fullscreen ) only. SDL_WINDOW_ALLOW_HIGHDPI does not change anything... The problem comes from SDL_GetDesktopDisplayMode that gives wrongs values (1536x864 instead of 1920x1080 for 125%). This is a bug in SDL. My recommandation : ~~don't use exclusive fullscreen~~....

EDIT : Fine, I found a way do fix it. SDL_WINDOW_ALLOW_HIGHDPI is necessary but was not enough.

jero

@f-caruso said in Updated EmulationStation for Windows:

@jero said in Updated EmulationStation for Windows:

settings for the videos that appear without making the animation

Supported in theming, using video.effect ( none, bump, size, slideRight )

Thank you it worked perfect

play background music and sounds when moving and selecting the carousel.

Supported for theming, using <sound><path> in system view (for music) & carousel.scrollSound for scrolling sound.

Carousel.scrollSound work perfect for me, but background music did not work, I tried this way.Dont work for me.I also searched for information on gitub and found nothing. Also in Themes.md

<view name="system">

	<carousel name="systemcarousel">
		<type>horizontal</type>
		<color>00000000</color>
		<logoScale>1.22592592592593</logoScale>
		<scrollSound>./sounds/notice.ogg</scrollSound>
	</carousel>

        <sound>
		<path>./sounds/bgm.ogg</path>
	</sound>

Bootscreen video, when you start ES

I don't agree. It's not ES responsability. It's the launcher / script role.

I understand thanks for answering

Padtokey [...] without having to be outside of ES.

I don't agree. It's not ES responsability.
I know, I shall do a configuration UI & a testing tool for the launcher, but I don't have time for this.

I understand your time is money, it was just a comment, I think Padtokey is something very very powerful for windows. As I said is windows problem, sure that using admin and removing admin or something like that creates a conflict in windows and does not work for me, but with ES in another hdd it works perfectly now. That's why I don't know how to fix it so that I can go back to work.

As always great work and thanks

f.caruso

@jero said in Updated EmulationStation for Windows:

background music did not work

Missing sound name :

<sound name="bgsound">

About pad2key I know I have things to do to make it better... I will... One day ;-) Maybe I should opensource that project on git too...

jero

@f-caruso said in Updated EmulationStation for Windows:

@jero said in Updated EmulationStation for Windows:

background music did not work

<view name="system">

	<carousel name="systemcarousel">
		<type>horizontal</type>
		<color>00000000</color>
		<logoScale>1.22592592592593</logoScale>			
		<scrollSound>./sounds/scroll.ogg</scrollSound>
		
	</carousel>

	<sound name="bgsound">
		<path>./sounds/bgm.ogg</path>

	</sound>

I used this for sounds. But bgmsound, restarts every time I change system and scrollSound does not sound

About pad2key I know I have things to do to make it better... I will... One day ;-) Maybe I should opensource that project on git too...

oooo it's great news, I hope one day this in ghitub

f.caruso

@jero You're right about the music replaying when changing system, it should not when the music is common to the systems. I just fixed it.

ThePlagueIsBack

@f-caruso said in Updated EmulationStation for Windows:

@ThePlagueIsBack Ran some tests. Problem occurs only with exclusive fullscreen ( using --fullscreen ) only. SDL_WINDOW_ALLOW_HIGHDPI does not change anything... The problem comes from SDL_GetDesktopDisplayMode that gives wrongs values (1536x864 instead of 1920x1080 for 125%). This is a bug in SDL. My recommandation : ~~don't use exclusive fullscreen~~....

EDIT : Fine, I found a way do fix it. SDL_WINDOW_ALLOW_HIGHDPI is necessary but was not enough.

Awesome man! Will wait for your build ;)

ThePlagueIsBack

Call me crazy but I could swear there was a menu option to choose the theme variations if the theme supports it (nes-mini for the instance), could have been on recalbox, have you guys seen anything like it on any ES build before?

LiveFreeDead

@ThePlagueIsBack Me too :) I tested your compile, it has the same issue as usual :( I wish I could compile ES myself, I tried for weeks but it kept failing for me - I use windows 10 LTSC and tried with Microsoft Visual Studio 2015, but I could never get a complete compile, I kept adding missing features/addons etc, but still would just error out mid compile. I even had a direct copy of other peoples source/build folders and it still failed. I had to give up and just report bugs instead. I think the only way I'll ever get to compile it myself is if someone shared a Virtual Machine HDD with it working :P

-EDIT-

REG ADD "HKCU\Control Panel\Desktop" /v DpiScalingVer /t REG_DWORD /d 0x00001018 /f
REG ADD "HKCU\Control Panel\Desktop" /v Win8DpiScaling /t REG_DWORD /d 0x00000001 /f
REG ADD "HKCU\Control Panel\Desktop" /v LogPixels /t REG_DWORD /d 0x00000078 /f

The reg's above do actually fix it, but it requires I log out and back in, same to disable it again... But thanks for this, I can use this fix for now until another option is available.

CarissaIsWierd

@f-caruso Now that I've been messing around with grid view a lot more, I thought I'd mention a slight annoyance in how selecting games is done. Using a 3x3 layout (or more), it keeps the selected game in the middle row (unless it's the very top or very bottom.) It's not pretty. Compare that to Kodi where it feels less jarring.

Is adding proper grid movement a change that can be made? (๑ơ ₃ ơ)ノ︵ ♡

f.caruso

@CarissaIsWierd

<centerSelection>false</centerSelection>

ThePlagueIsBack

@LiveFreeDead said in Updated EmulationStation for Windows:

@ThePlagueIsBack Me too :) I tested your compile, it has the same issue as usual :( I wish I could compile ES myself, I tried for weeks but it kept failing for me - I use windows 10 LTSC and tried with Microsoft Visual Studio 2015, but I could never get a complete compile, I kept adding missing features/addons etc, but still would just error out mid compile. I even had a direct copy of other peoples source/build folders and it still failed. I had to give up and just report bugs instead. I think the only way I'll ever get to compile it myself is if someone shared a Virtual Machine HDD with it working :P

-EDIT-

REG ADD "HKCU\Control Panel\Desktop" /v DpiScalingVer /t REG_DWORD /d 0x00001018 /f
REG ADD "HKCU\Control Panel\Desktop" /v Win8DpiScaling /t REG_DWORD /d 0x00000001 /f
REG ADD "HKCU\Control Panel\Desktop" /v LogPixels /t REG_DWORD /d 0x00000078 /f

The reg's above do actually fix it, but it requires I log out and back in, same to disable it again... But thanks for this, I can use this fix for now until another option is available.

Use Fabrice's build man, he had to add more into it then the hack I did, give it a try.

https://github.com/fabricecaruso/EmulationStation/releases

ThePlagueIsBack

@ThePlagueIsBack said in Updated EmulationStation for Windows:

Call me crazy but I could swear there was a menu option to choose the theme variations if the theme supports it (nes-mini for the instance), could have been on recalbox, have you guys seen anything like it on any ES build before?

Never mind, the theme configuration does show up when I use fabz-theme so the nes-mini must not contain configurable
settings. I was looking into have a optional 4:3 config on the theme to run on CRT monitors without duplicating the theme.

f.caruso

@ThePlagueIsBack nes-mini is a Retropie theme. Retropie Themes don't support subsets. You have to edit the theme to add such a configuration option yourself.

CarissaIsWierd

@f-caruso said in Updated EmulationStation for Windows:

@CarissaIsWierd

<centerSelection>false</centerSelection>

I had already tried that, but everything still selects in the middle row. Here's how it looks in ES as I keep moving up and down.

LiveFreeDead

@f-caruso Well it seams now that if I run EmulationStation.exe directly that the Scaling issues are fixed, thank you.

However - if anyone uses --fullscreen and provides an actual resolution, it doesn't change the screen resolution anymore and if you give it less than the current resolution it condenses it in the bottom left corner of the screen if less than and expands off screen from the bottom left of ES. Might be worth centering it? I don't mind if you don't I wont use --resolution anymore anyway ;)

-EDIT-

GamesLists TXT (Pretend Content)

____________________
_ Atari 2600:
____________________
Asteroids
Frogger
Space Invaders
____________________
_ Amiga:
____________________
Aadams Family
James Pond Robocod 2
____________________
_ Sega Master System:
____________________
Alex Kidd in Miricle World
Sonic The Hedgehog 2
Road Rash

Here is another idea, maybe you could offer a tools menu so you can generate a GamesLists TXT that makes a header for each system and then lists all the names of roms, this would save a lot of work if you wanted to make lists. It would have to list them without any folders, but still it may be useful?

f.caruso

@CarissaIsWierd You are right. I just added a new value for centerSelection : partial.
true -> always center the selection
partial -> center the selection except if at begin or end of gamelist ( in not scrollLoop )
false -> just don't ( considering behaviour has changed for false value, partial was the old "false" )
Default decomes "false" in vertical layout. Default (finally unchanged) is "partial" in horizontal layout.

@LiveFreeDead Your fullscreen problem using high dpi is not easy to solve... But I think I fixed it. Try the latest version.

Maybe you could offer a tools menu so you can generate a GamesLists TXT

Sorry I won't do that. It's absolutely not ES role to do that kind of things...
And I don't know who will ever use that ( except you ) ?
As you have basis in developement, I'm sure you'll find a way to enumerate gamelist.xml files, read them and output what you want ;-)

LiveFreeDead

@f-caruso Nailed it, got ALL screen choices crystal clear and acting they way they should - 100% perfect, even on my dual screen configuration I was able to switch to using --monitor 1 and it behaved.

Big thank you again for being a great programmer and sharing with the community.

Also the only reason I never started making a program to parse these XML's myself is I get very invested in each project I start, so I could end up writing a whole xml builder with GUI interface instead ;) I was just hoping as you had all the roms listable you might (if I was lucky) make a function that would call each system and output to a text file. But your right, it doesn't really need to be in there for everyone, wouldn't be a total loss if you make a hot key combination copy the current system's rom names to the clipboard tho right :P he he he

CarissaIsWierd

@f-caruso That's perfect! Thank you. I love the visible system feature too :D

jero

@f-caruso Thanks for the fix, the background and scroll sound already work

ThePlagueIsBack

@f-caruso said in Updated EmulationStation for Windows:

@CarissaIsWierd You are right. I just added a new value for centerSelection : partial.
true -> always center the selection
partial -> center the selection except if at begin or end of gamelist ( in not scrollLoop )
false -> just don't ( considering behaviour has changed for false value, partial was the old "false" )
Default decomes "false" in vertical layout. Default (finally unchanged) is "partial" in horizontal layout.

@LiveFreeDead Your fullscreen problem using high dpi is not easy to solve... But I think I fixed it. Try the latest version.

Maybe you could offer a tools menu so you can generate a GamesLists TXT

Sorry I won't do that. It's absolutely not ES role to do that kind of things...
And I don't know who will ever use that ( except you ) ?
As you have basis in developement, I'm sure you'll find a way to enumerate gamelist.xml files, read them and output what you want ;-)

Amazing work Fabrice, this "partial" feat for the grid is simply amazing, thank you!