Grid Updates - emulationstation-dev

ruckage · 27 Feb 2020, 15:58

@paffley said in Grid Updates - emulationstation-dev:

Hey @jdrassa thanks for merging the new grid updates :)

Found a couple of bugs in the latest version of es-dev

1 - When you go back to the gamelist view 'after exiting a game' md_video does not play, even when you scroll. If you go back to the system view then back to gamelist view the snaps re-appear.**

2 - When entering a system, the md_name, md_image, md_video etc vanishes then re-appears after the first scroll.

Now I'm not sure if this is a bug or not but with the latest es-dev update there is a frame rate counter in the top right hand side of the screen when you start a game? I'm not sure how to get rid of this as its not from es menu settings nor can I locate it in retroarch?

Hope this all helps :)

Hi @paffley. I've just installed the latest ES dev build on rpi to check and can confirm I'm also seeing these exact issues. Plus I've also noticed a bug when using omx player specifically. Sorry @jdrassa , looks like it's a few more bugs to add to list I'm afraid.

Just to confirm:

No video plays once exciting a game unless you return to the system select first. I've confirmed on both windows and Rpi.
No metadata at all is displayed for the first tile/game when first entering a system (including text,images, video) .
On Rpi if you have OMX player switched on the video fills the entire screen rather than being displayed at the size specified in the theme.xml unless both axis are defined.
eg. <size>0 0.2</size> fails and just fills the whole screen but <size>0.2 0.2</size> works correctly

@jdrassa As requested below is the contents of the grid setup I'm using - I think there are probably a lot of redundant things included as I've started using autolayout and have been experimenting quite a bit so it could do with cleaning up.

                <imagegrid name="gamegrid">
			<pos>-0.05 0.565</pos>
			<size>1.1 0.276</size>
			<autoLayout>9 1</autoLayout>
			<autoLayoutSelectedZoom>1</autoLayoutSelectedZoom>
			<margin>0.00625 0.006</margin>
			<centerSelection>true</centerSelection>
			<scrollLoop>true</scrollLoop>
			<animate>false</animate>
			<scrollDirection>horizontal</scrollDirection>
			<folderImage>./art/${style}/folder.png</folderImage>
			<imageSource>thumbnail</imageSource>
		</imagegrid>

		<gridtile name="default">
			<size>0.134 0.322</size>
			<padding>18 18</padding>
			<backgroundImage>./art/${style}/tile.png</backgroundImage>
			<backgroundCornerSize>64 64</backgroundCornerSize>
			<backgroundColor>ffffff</backgroundColor>
			<imageColor>ffffff</imageColor>
		</gridtile>

		<gridtile name="selected">
			<size>0.134 0.322</size>
			<backgroundImage>./art/${style}/tile-selected.png</backgroundImage>
			<backgroundColor>ffffff</backgroundColor>
		</gridtile>

paffley · 29 Feb 2020, 12:31

Hey @ruckage mate, hope ya well dude. Yeh I agree on the oxm player. I only use Rpi for my builds. The new features are cool aint they! used correct you can get some cool layouts. I use one on my nes/snes mini build where the 'selected' bgimage goes left and right, not quiet as far left and right as the original nes/snes mini but pretty close, I reckon with a few more tweaks I may be able to replicate it fully. Im still having a few issues with sizing the imagegrid tho with the bgimages, sometimes they look perfect but when you scroll up or down it kind of goes 'off' a little with the boxart, only minor but my ocd kicks in haha so im gonna have to investigate that further as the imagegrid seems to have little issues with specific sizing to the points (0.252 etc).

If these little minor issues can be cleaned up I believe the only thing needed for the grid view is an option of scrollSound, possibly adding on to the md_name tag I would assume.

Its all cracking tho and @jdrassa has done some awesome work on it over the months/weeks. salute to him!

I'm a big fan of hyperspin, so im just converting a theme at the moment with the new features and its spot on! works great!

Love your above layout by the way, very slick! Good work!

jdrassa · 29 Feb 2020, 14:20

@paffley @ruckage I have a PR in to fix 1 and 2 from the list above.
As for 3, after looking over the code, I suspect this has probably always been a bug with OMX player. The OMX player component doesn't have the same size calculation logic that image and VLC do.

paffley · 29 Feb 2020, 14:29

@jdrassa said in Grid Updates - emulationstation-dev:

@paffley @ruckage I have a PR in to fix 1 and 2 from the list above.
As for 3, after looking over the code, I suspect this has probably always been a bug with OMX player. The OMX player component doesn't have the same size calculation logic that image and VLC do.

Thanks @jdrassa Yes I agree on number 3, I have found numerous issues with omx.

FYI, number 2 is an issue in the stable branch also, just thought id let you know.

paffley · 29 Feb 2020, 14:33

@ruckage any chance you could upload the font you are using for the md_name please? its for my personal build. I have the regular OCR font but cannot find the outlined one.

ruckage · 29 Feb 2020, 14:50

@jdrassa said in Grid Updates - emulationstation-dev:

@paffley @ruckage I have a PR in to fix 1 and 2 from the list above.
As for 3, after looking over the code, I suspect this has probably always been a bug with OMX player. The OMX player component doesn't have the same size calculation logic that image and VLC do.

That's great @jdrassa , I look forward to trying it - you're a real star :D .

Regarding OMX player you may be right, I normally tend to explicitly set both axis for video size or use <maxsize> so I just haven't noticed it before.

ruckage · 29 Feb 2020, 15:33

@paffley said in Grid Updates - emulationstation-dev:

I have the regular OCR font but cannot find the outlined one.

That's because it didn't exist until I made ;)
Regarding sharing I'm not sure as it's an edited version of the original OCR font and as far as I'm aware it's not an open source font. For my own personal use it's obviously fine but I'd prefer to find an open source alternative to OCR if possible.

paffley · 29 Feb 2020, 15:39

That's why I cannot find it then @ruckage :P

No probs mate, I hear ya. I'll edit mine.

ruckage · 2 Mar 2020, 19:09

Hi @BuZz , any chance of getting @jdrassa pull request for ES merged as it fixes some bugs that grid view currently has. Thanks in advance.

jdrassa · 2 Mar 2020, 22:42

@ruckage for bug fix PRs like this, I usually give it a couple days just to make sure no one has any objections, before I will merge it myself.

quicksilver · 5 Mar 2020, 03:26

@jdrassa Thanks for looking into this. Although I think the issue I brought up may be somewhat different to issue that @ruckage was having. The issue I noticed is when the gameslist view is set to "video" and "showSnapshotNoVideo" is set to true, the screenshots appear at the proper size except after you launch a game and return to emulation station the screenshot of the game you just launched is "squashed" for lack of a better word. So not exactly a grid view issue but still a problem. Is there any chance you could take a look into that as well? Or will your PR also address this? Sorry to be a bother, thanks again!

ruckage · 5 Mar 2020, 21:11

@quicksilver said in Grid Updates - emulationstation-dev:

The issue I noticed is when the gameslist view is set to "video" and "showSnapshotNoVideo" is set to true, the screenshots appear at the proper size except after you launch a game and return to emulation station the screenshot of the game you just launched is "squashed" for lack of a better word...

What theme are you seeing this as an issue as I can't reproduce it myself (at least not on windows).

quicksilver · 5 Mar 2020, 21:13

@ruckage Ive been using nostalgia but it also happens on carbon

ruckage · 5 Mar 2020, 21:16

@quicksilver
Is it on the pi or windows that you're seeing the issue? If it's the pi are you using the OMX player to play videos? (there should be an otion to enable/disable OMX player).

quicksilver · 5 Mar 2020, 21:20

@ruckage it's on my pi. I'm not using videos, just using video gameslist view to get the marquees to show up.

ruckage · 5 Mar 2020, 21:21

@quicksilver
Just tried the Nostalgic theme and I see what you mean. I'm just going to check the theme.xml to if there are any problems.

ruckage · 5 Mar 2020, 21:32

@quicksilver Yeah, looks like another bug, the theme.xml itself seems fine.

quicksilver · 5 Mar 2020, 21:35

@ruckage thanks for confirming it. I also noticed that if I use skyscraper to resize any of my scraped images, the last game I played will not resize correctly and stays squashed. I have to run a different game and then regenerate my gameslist.xml again. I'm guessing its probably a related issue.

ruckage · 5 Mar 2020, 21:48

@jdrassa
This is the problem that @quicksilver is talking about, It looks very similar to what's happening to the first game image in grid view but it could just be a coincidence: