Journey sound sample in mame2003-plus, solved

mahoneyt944

@skj I think it's the same sample from what I can tell

grant2258

https://github.com/libretro/mame2003-plus-libretro/blob/0134c428b75882aa474f78dbbf2c6ecde49b97b7/src/common.c#L302

comment this for now and change it to if(1) something else must be triggering this will need to follow the code at some point this code.

mahoneyt944

@grant2258 that's what I was looking at earlier but passed it when you said about in being flac related. Does that fix the issue with the sample loading? Can't we just raise the GAME_SAMPLE_LARGE to fit our sample it's capped at 10 mb and our sample is 15+

grant2258

I think i know what the problem is there is a flag that checks if contents is ost sample

https://github.com/libretro/mame2003-plus-libretro/blob/0134c428b75882aa474f78dbbf2c6ecde49b97b7/src/sound/samples.c#L32-L45

will check it later on i would guess this is the issue with using big samples like this.

grant2258

@arcadez2003 do you have links to them samples you had to shrink sorted the problem will test the ole samples that never worked before as well. This is actually great doing it this way because it unloads the sample when it stops if its huge its so smaller systems like the mini collection can play the samples without loading em all at one time.

arcadez2003

@grant2258 said in Journey sound sample in mame:

@arcadez2003 do you have links to them samples you had to shrink sorted the problem will test the ole samples that never worked before as well. This is actually great doing it this way because it unloads the sample when it stops if its huge its so smaller systems like the mini collection can play the samples without loading em all at one time.

I still got the one for Teki Paki how to get it to ya though.?? im not sure if we can share samples on here.??

grant2258

think samples are ok to be honest as long as its not the full metallica collection! I could always drive round bring a thumb stick sanitize it throw it you while maintaining a two meter distance just for something to do during this lockdown is driving me nuts!. Seriously thrown me a link anywhere on github if you dont want to post a link here.

arcadez2003

@mahoneyt944 said in Journey sound sample in mame:

@grant2258 no, I'm at work so I can't right now. What happens though is when I go to the service menu and enter the cassette test menu. When I flip the up button to start the cassette I hear screeching. If I press down it stops. If I let it play eventually after about 30 seconds it crashes the emulator and throws me to emulationstation. So I took that sample, opened it in audacity cut it to 1:50 (originally 3:03) then exported it as .wav 16 bit pcm. I retest the above senario and the sample works just fine. So next I try the cut sample at 1:55, this time I get the screech and crash. For some reason it doesn't like the sample size over a certain size.

But then you got the sample to work through final fight, so I really don't know. It must be related to how we are initiating the sample with the mcr driver? Maybe the output is wrong, 2010mame looks like this:
static DRIVER_INIT( journey )
{
	mcr_init(machine, 91475, 91464, 90913);
	mcr_sound_init(machine, MCR_SSIO);

	ssio_set_custom_output(4, 0x01, journey_op4_w);
}
And our 2003plus wip
static DRIVER_INIT( journey )
{
	MCR_CONFIGURE_SOUND(MCR_SSIO);
	install_port_write_handler(0, 0x00, 0x00, mcr_control_port_w);
	install_port_write_handler(0, 0x04, 0x04, journey_sample_select_w);

	mcr12_sprite_xoffs = 0;
	mcr12_sprite_xoffs_flip = 0;
}

I think how i set it up is correct but when dealing with code written for a totally different driver and reworking it to fit our older one can always be problematic.
certainly all i know is with both my MAME72 and MAME84 xbox ports i can play the journey sample from twistys site from beginning to end with no problems.
and that's the full on sample btw i've not altered it whatsoever.

Now the main problem for me at least is listening to that uncool song so many times now has got me actually singing it in the shower etc etc :)

arcadez2003

@grant2258 said in Journey sound sample in mame:

think samples are ok to be honest as long as its not the full metallica collection! I could always drive round bring a thumb stick sanitize it throw it you while maintaining a two meter distance just for something to do during this lockdown is driving me nuts!. Seriously thrown me a link anywhere on github if you dont want to post a link here.

Ok check the comments in my last commit to MAME2003+ in 10 mins or so

grant2258

cheers bud can post there so ill thank you now haha!

arcadez2003

@grant2258 said in Journey sound sample in mame:

cheers bud can post there so ill thank you now haha!

So whatya think @grant2258 the full on sample works for me with no issues on both my xbox standalone MAME ports so i assume the code i added to the driver is good
can this be another of those issues caused by stuffing standalone emulator cores into a frontend.?? or maybe platform related as obviously none of ya's are using
the xbox like i am.

grant2258

This looks like it was an issue from adding the ost load and unload support it basically loads a sample if its small enough else it just loads it when its needed and unloads it when it stops when its bigger than a certain size. I added a condition in to fix tmnt samples not playing but it broke the samples that are too big if you didnt have the ost flag set. I just fixed it another way

arcadez2003

@grant2258 said in Journey sound sample in mame:

This looks like it was an issue from adding the ost load and unload support it basically loads a sample if its small enough else it just loads it when its needed and unloads it when it stops when its bigger than a certain size. I added a condition in to fix tmnt samples not playing but it broke the samples that are too big if you didnt have the ost flag set. I just fixed it another way

Right then so it's not my driver code, lovely to have that cleared up so now i can move on to something else and let you guys sort this out ha ha

grant2258

Well this is nothing to do with me haha! It working spot on it too much. Just like that big sega update mate it was all good! @mahoneyt944 will be happy ill leave a link later with a fix for plus if he wants to add it there see there is a few pull request there lol.

mahoneyt944

@arcadez2003 @grant2258
Good deal. I'm going to mess with the mute settings to figure out what actually works best in the bonus scene ...which means I have to play the hell out of this game. For some reason setting it to 25 in the interface made it sound too quiet, but that's the recommend level. I think this might be because the sample volume is being cut down before mixing so the game sounds are much louder.

Basically instead of stopping the song I mute and unmute, this allows the song to play random clips Everytime you hit the bonus round. So a pause workaround. Since stop resets to the beginning of the song every time. It's a cleaver trick to get different audio clips

I'll update with your patch before I test though then make the pull request on 2003plus once it sounds spot on.

mahoneyt944

@arcadez2003 @grant2258
OK, after beating the first level about 15 times..... I feel really good about the volume setting. It's just slightly louder than the game sounds which is what you want at a concert lol. I replaced the stop feature with mute so the first time you get to the bonus it plays from the intro. After that, every bonus scene gets a random clip of the song. Using stop you only get the intro and without pause this is a good compromise. I made a new pull request if you guys would test it out on other platforms..xbox, whatever. Let me know how it sound in the bonus and cassette menu. https://github.com/libretro/mame2003-plus-libretro/pull/787/files

Scratch that. A bit loud on my cab, I'll back it down. More testing

Riverstorm

Here's a link to the samples from Twisty's. The samples are still full length. I've only changed the sample rate and bit depth to make them quite a bit smaller (down to under 4MB). The information of each version is below. Let me know what you think of the quality if you listen to them.

@grant2258 - I agree, I would love to see the original CD's from any of the 7 or 8 custom OST's that have been implemented into m3plus. If they are true CD quality I could easily rip and split the channels out for much better quality and then do a clean shrink.

44100 Hz, 16-bit, 1 channel - 15.4MB (Original WAV)
44100 Hz, 8-bit, 1 channel - 7.73MB
22050 Hz, 16-bit, 1 channel - 7.73MB
22050 Hz, 8-bit, 1 channel - 3.86MB

If we can't link Twisty's samples just let me know and I'll remove them.

mahoneyt944

@Riverstorm grant fixed large sample support. Now they all work as they should. Pull request made if you want to test: https://github.com/libretro/mame2003-plus-libretro/pull/787/files

Riverstorm

@mahoneyt944 - Ah, ok, that was quick!

Riverstorm

@mahoneyt944 - By the way I did email Twinaphex asking if he might merge the pull requests (politely and with please ;) but they may be busy or affected by COVID or something but at least we tried. I did see markwkidd replied to an old issue last week but I can't find who or where to look to see who has those permissions on Github.