Is Yabasanshiro emulator coming on retropie?

dankcushions

i don't think it's fair to blame the drivers/foundation - no-one has isolated the issue to any particular non-conformance, and then logged it with MESA. if they did, i'm sure a fix would be forthcoming. emulation often hits some under/never-used parts of graphics drivers so it's normal for emulation development to find issues with otherwise "good" drivers.

we're just lacking someone familiar with GLSL who can do a deep dive into this. MESA have an IRC where it might be appropriate to raise this informally: mesa3d.org/lists.html (i don't this we know enough about the cause of the issue to raise it on the mailing list or gitlab)

barbudreadmon

@dankcushions said in Is Yabasanshiro emulator coming on retropie?:

no-one has isolated the issue to any particular non-conformance, and then logged it with MESA

Is that really the job of the customer though ? The issue was brought to their "support team", and they didn't seem interested in investigating it themselves. They might be a "charity group", but looking at the CEOs, entrepreneurs and investors behind (https://www.raspberrypi.org/about/governance/), i don't think it's right to market a product and to not look into every issues reported.

dankcushions

@barbudreadmon

The issue was brought to their "support team", and they didn't seem interested in investigating it themselves.

link? a post to rpi's GLES programming forum is not a support request. that's just a discussion forum like here. at no point has the specific issue been identified or it been logged at MESA, or with raspberry pi, as far as i'm aware.

they have a dedicated MESA development team. we just need someone who knows GLSL to identify and log the issue.

barbudreadmon

@dankcushions said in Is Yabasanshiro emulator coming on retropie?:

a post to rpi's GLES programming forum is not a support request.

People marked as "Raspberry Pi Engineer" are answering in that section of their forum though, and none of them answered to the topic about texelFetch, while an example of code to reproduce the issue was provided.

BuZz

@barbudreadmon it wasn't really an example. It was a line or two of shader code with no context.

If someone provided them with a snippet of code to show an issue and reported it to Mesa, it would be looked at.

Btw the commercial arm (heh) of raspberry pi does the development. I have always found them to be good at sorting out issues when an issue can be properly illustrated.

The bug with lr-yabasanshiro may not be an issue with the drivers at all. A proper bug report needs to be done.

Darksavior

I tried to build the latest version from devmiyax's repo. Failed. Ah, well. I don't know what I'm doing, just thought I'd try.

barbudreadmon

@Darksavior said in Is Yabasanshiro emulator coming on retropie?:

I tried to build the latest version from devmiyax's repo. Failed.

i stopped maintaining the port on his repo after https://github.com/devmiyax/yabause/issues/630#issuecomment-547787501 , this conversation kinda pissed me off, especially with him releasing a switch version based on the lakka distro a few weeks later...

mechafatnick

I tried Assault Suit Leynos 2 yesterday and the entire ground is missing. :)

There's definitely some issues on the 2d side of things.

grant2258

@Darksavior seems like there is a end to development on libretro on this port unless someone picks it up on there end. The only way to test would be by using standalone build. If that works well you can just request an update on the github page on libretro for someone to pick it up and hope for the best.

ok ive made a patch not got any saturn roms but it compiles just apply this patch over the repo

git clone https://github.com/devmiyax/yabause.git
cd yabause/
wget https://github.com/grant2258/yabause/raw/master/pi.patch
git apply pi.patch
cd yabause/src/libretro/
make platform=armvneonhardfloat  -j4

then copy the bin over no idea if this is enough just done the basics. I basically repaced the chd code to the libreto one not sure if this will cause issues loading or not hopefully it works

barbudreadmon

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

If that works well you can just request an update on the github page on libretro for someone to pick it up and hope for the best.

Ultimately i want someone to completely take over that core so that i can stop providing any kind of support for it, sending sync PR my way isn't gonna solve anything, i'll still be the guy getting asked for everything related to that core, including the dozens of regressions version 3.2 introduced.

grant2258

not sending anything your way you have made it clear your not updating this anymore. I just done a diff to his repo to get it to compile. Is just a patch for people to test out. Might not even work worth a try if not then well i tried. Like yourself dont really want to waste any time on it someone needs to maintain it libretro side ideally.

roslof

@grant2258 appreciate the effort here. Understood we're only tinkering.

Compiled for me. Launching a [previously working] .chd yields unsupported image in the logs. Boots, but only to Saturn BIOS screen. I'll try some non .chd files and see what I get.

[libretro ERROR] Yabause: Unsupported CD image!
[libretro ERROR] Yabause: Cannot initialize ISO-File Virtual Drive

FWIW: I just added your patch to Buzz's lr-yabasanshiro script and built it that way:

  isPlatform "rpi4" && applyPatch "$md_data/01_shader_hack_rpi4.diff"
  isPlatform "rpi4" && applyPatch "$md_data/pi.patch"

Not sure if I should have removed Buzz's shader tweak.
No worries though. Will play around more.

grant2258

@roslof using a diff repo dont use the build scripts for this just type the commands at the command prompt. This is using pretty old libretro files its the latest ones mainline though

git clone https://github.com/devmiyax/yabause.git
cd yabause/
wget https://github.com/grant2258/yabause/raw/master/pi.patch
git apply pi.patch
cd yabause/src/libretro/
make platform=armvneonhardfloat  -j4
sudo cp yabasanshiro_libretro.so /opt/retropie/libretrocores/lr-yabause/yabause_libretro.so

I downloaded shinobi gfx are flashing on teh libretro port for some reason but it is running i dont have a pi 4 though

roslof

@grant2258 as expected, that worked. Thank you! Evaluating...

Darksavior

@grant2258 No games seem to work. It boots to the disc menu. I tried a chd and bin\cue that originally worked. The screen is missing all textures. It also says it's version 2.5.1? I thought the new version was 3.2.

[libretro ERROR] Yabause: Unsupported CD image!

[libretro ERROR] Yabause: Cannot initialize ISO-File Virtual Drive

grant2258

@Darksavior remove the directory you have already with rm -rf yabause and try again. The 2.5.1 version displaying is because thats the last version libretro updated it with upstream.

edit fwiw i checked out the latest libretro code merged the latest branch changes the flashing is still there for me on linux64 on shinobi

Darksavior

@grant2258 No change.

grant2258

@Darksavior not sure what your doing different from roslof it working for him.

There seems to be some confusion here in general the libretro port seems up to date you can merge the latest into the yabasanshiro branch on libretro 3.1 something. I get flashing in both though. So you can do it that way if you prefer

roslof

@Darksavior your symptoms mirrored mine when I was using the .sh script. For it to work properly, with a clean build folder, I just followed the directions from grant2258 a few posts back.

Darksavior

@roslof I'm not using the .sh script. That's opening a can of worms and I have no dev experience. I'm using the directions grant posted. I have started over and since he didn't update his patch, my problem did not change. I delete the folder before starting over, obviously..
@grant2258 Does it matter that I'm doing this through ssh?