Integrate Daphne Emulator back into the Retropie Script for Ubuntu

[johnodon]

@dirtbagxon Not sure if this will pose any issues, but the ~/.hypseus folder is owned by root however the contents within are owned by pi.

drwxr-x--- 11 pi   pi   4096 Sep  9 21:53 .
drwxr-xr-x  3 root root 4096 Sep  8 22:27 ..
-rw-------  1 pi   pi   4684 Sep 12 11:54 .bash_history
-rw-r--r--  1 pi   pi    220 Mar 19 16:02 .bash_logout
-rw-r--r--  1 pi   pi     72 Sep  8 22:50 .bash_profile
-rw-r--r--  1 pi   pi   3771 Mar 19 16:02 .bashrc
drwx------  5 pi   pi   4096 Sep 12 11:53 .cache
drwxr-xr-x  7 pi   pi   4096 Sep 12 11:53 .config
lrwxrwxrwx  1 pi   pi     42 Sep  8 22:36 .emulationstation -> /opt/retropie/configs/all/emulationstation
-rw-r--r--  1 pi   pi      0 Sep  8 22:50 .hushlogin
drwxr-xr-x  5 root root 4096 Sep  9 16:07 .hypseus
drwxr-xr-x  3 pi   pi   4096 Sep  8 22:33 .local
lrwxrwxrwx  1 pi   pi     26 Sep  9 19:16 .mame -> /opt/retropie/configs/mame
-rw-r--r--  1 pi   pi    807 Mar 19 16:02 .profile
-rw-r--r--  1 pi   pi      0 Sep  8 22:30 .sudo_as_admin_successful
-rw-rw-r--  1 pi   pi    180 Sep  9 14:59 .wget-hsts
drwxrwxr-x  2 pi   pi   4096 Sep  9 18:01 Downloads
drwxr-xr-x  6 pi   pi   4096 Sep  8 23:01 RetroPie
drwxr-xr-x  8 pi   pi   4096 Sep  8 22:54 RetroPie-Setup
drwxrwxr-x  4 pi   pi   4096 Sep  8 22:31 RetroPie-Setup-Ubuntu
drwxrwxr-x  2 pi   pi   4096 Sep  9 20:22 history
-rw-rw-r--  1 pi   pi   8811 Sep  9 21:53 outputs.txt

drwxr-xr-x  5 root root 4096 Sep  9 16:07 .
drwxr-x--- 11 pi   pi   4096 Sep  9 21:53 ..
drwxr-xr-x  2 pi   pi   4096 Sep 10 15:32 logs
drwxr-xr-x  2 pi   pi   4096 Sep  9 16:07 ram
drwxr-xr-x  2 pi   pi   4096 Sep  9 16:07 screenshots

[DirtBagXon]

@johnodon said in Integrate Daphne Emulator back into the Retropie Script for Ubuntu:

@dirtbagxon Not sure if this will pose any issues, but the ~/.hypseus folder is owned by root however the contents within are owned by pi.

drwxr-xr-x  5 root root 4096 Sep  9 16:07 .
drwxr-x--- 11 pi   pi   4096 Sep  9 21:53 ..
drwxr-xr-x  2 pi   pi   4096 Sep 10 15:32 logs
drwxr-xr-x  2 pi   pi   4096 Sep  9 16:07 ram
drwxr-xr-x  2 pi   pi   4096 Sep  9 16:07 screenshots

These directories are actually created by the RetroPie helper function mkUserDir()

mkUserDir "$home/.$md_id/ram"
mkUserDir "$home/.$md_id/logs"
mkUserDir "$home/.$md_id/screenshots"

So it appears this function doesn't set ownership on the parent directories correctly within $home: "Creates a directory owned by the current user."

It shouldn't affect the the installation as data will only be written to the correctly owned child directories. However, it is not as it should be, so I will add a chown -R to the end of the install script to ensure it's all owned by pi.

You can either grab the latest scripts from the repo (as above) or fix with :

sudo chown -R pi:pi ~pi/.hypseus

Many thanks for the great feedback.

 

[DirtBagXon]

@mitu

Is anyone familiar with the reason that the package, even when up-to-date, still show this in RetroPie-Setup :

'Update is available'

The installed package version has the correct git tag.

Is this something I have control over?

 

[mitu]

@dirtbagxon said in Integrate Daphne Emulator back into the Retropie Script for Ubuntu:

Is this something I have control over?

Not really, since the setup script automatically determines if there's an update based on the source location and the locally stored package info (retropie.pkg in the install folder). I can't seem to reproduce the situation though, if I install from source then it shows correctly as up-to-date

[dankcushions]

@dirtbagxon is your retropie-setup script up to date? you may want to rebase it to master - quite a few changes have been made to the surrounding functionality that may affect things.

[DirtBagXon]

@dankcushions said in Integrate Daphne Emulator back into the Retropie Script for Ubuntu:

@dirtbagxon is your retropie-setup script up to date? you may want to rebase it to master - quite a few changes have been made to the surrounding functionality that may affect things.

Thanks for the quick reply guys. I am on the following merge of RetroPie-Setup now:

commit 202fabd1bf0e0638ca71d09cc6af7e233dc0e059 (HEAD -> master, origin/master, origin/HEAD)
Author: Jools Wills <buzz@exotica.org.uk>
Date:   Tue Sep 14 06:38:12 2021 +0100

    dolphin - license.txt was renamed to COPYING

I was one commit behind, but testing now still shows as out of date...
I have had this reported from a couple of other users testing the scripts in the field, so not just me seeing it.

retropie.pkg shows:

pkg_origin="source"
pkg_date="2021-09-14T17:58:55+01:00"
pkg_repo_type="git"
pkg_repo_url="https://github.com/DirtBagXon/hypseus-singe.git"
pkg_repo_branch="RetroPie"
pkg_repo_commit="327cbd674986b3c93d87beec3da9cec63c05ec57"
pkg_repo_date="2021-09-11T16:01:00+01:00"
pkg_repo_extra=""

Which all looks correct.... Hmmm...

I'll try another reinstall on the new commit.

[DirtBagXon]

Ok, doing all this via terminal: sudo RetroPie-Setup/retropie_setup.sh

Reinstalled:

retropie.pkg

pkg_origin="source"
pkg_date="2021-09-14T20:01:46+01:00"
pkg_repo_type="git"
pkg_repo_url="https://github.com/DirtBagXon/hypseus-singe.git"
pkg_repo_branch="RetroPie"
pkg_repo_commit="327cbd674986b3c93d87beec3da9cec63c05ec57"
pkg_repo_date="2021-09-11T16:01:00+01:00"
pkg_repo_extra=""

Still saying there was an update, as per first screen.

Then Removed, verified the was no /opt/retropie/emulators/hypsesus directory - all gone:

Went for reinstall:

Immediately after install completed successfully:

pkg_origin="source"
pkg_date="2021-09-14T20:20:38+01:00"
pkg_repo_type="git"
pkg_repo_url="https://github.com/DirtBagXon/hypseus-singe.git"
pkg_repo_branch="RetroPie"
pkg_repo_commit="327cbd674986b3c93d87beec3da9cec63c05ec57"
pkg_repo_date="2021-09-11T16:01:00+01:00"
pkg_repo_extra=""

Any ideas ?

[mitu]

@dirtbagxon Still can't reproduce this. You can debug the script by running

sudo __debug=1 ./retropie_setup.sh

This will produce a lot of data, but the interesting part (checking for an updated version) will be printed after you select the package from the list, right before the package dialog is shown. Copy the debug info from that part and post it on pastebin.com.

[DirtBagXon]

@mitu said in Integrate Daphne Emulator back into the Retropie Script for Ubuntu:

@dirtbagxon Still can't reproduce this. You can debug the script by running

sudo __debug=1 ./retropie_setup.sh

This will produce a lot of data, but the interesting part (checking for an updated version) will be printed after you select the package from the list, right before the package dialog is shown. Copy the debug info from that part and post it on pastebin.com.

Just so I don't miss something, pastebin has size restrictions, so:

https://raw.githubusercontent.com/DirtBagXon/debug/main/debug.txt

[mitu]

Looks like the update check fails somewhere along those lines:

...
++ git -C /home/pi/RetroPie-Setup log -1 --format=%cI -- /home/pi/RetroPie-Setup/scriptmodules/emulators/hypseus.sh
+ local module_date=
+ rp_dateIsNewer 2021-09-14T20:46:00+01:00 ''
+ local date_a=2021-09-14T20:46:00+01:00
+ local date_b=
+ [[ -z 2021-09-14T20:46:00+01:00 ]]
+ [[ -z '' ]]
+ return 0
...

What's the output of the next command in your installation ?

git -C /home/pi/RetroPie-Setup log -1 --format=%cI -- /home/pi/RetroPie-Setup/scriptmodules/emulators/hypseus.sh

[DirtBagXon]

@mitu said in Integrate Daphne Emulator back into the Retropie Script for Ubuntu:

git -C /home/pi/RetroPie-Setup log -1 --format=%cI -- /home/pi/RetroPie-Setup/scriptmodules/emulators/hypseus.sh

From ~/RetroPie-Setup Folder:

pi@retropie:~/RetroPie-Setup $ git -C /home/pi/RetroPie-Setup log -1 --format=%cI -- /home/pi/RetroPie-Setup/scriptmodules/emulators/hypseus.sh
pi@retropie:~/RetroPie-Setup $

Nothing...

[DirtBagXon]

Because it isn't merged yet....

It's just installed via a curl/wget

Ok, makes sense.

But why does it work for you ? Did you clone my branch ?

[mitu]

@dirtbagxon said in Integrate Daphne Emulator back into the Retropie Script for Ubuntu:

But why does it work for you ?

Because I've fetched the PR from the RetroPie repository into a local branch:

$ [hypseus-3] git -C /home/pi/RetroPie-Setup log -1 --format=%cI -- /home/pi/RetroPie-Setup/scriptmodules/emulators/hypseus.sh
2021-09-12T15:27:09+01:00
$ [hypseus-3]

[DirtBagXon]

@mitu

Ok, makes sense. So all will be cool when it's merged.

Thanks for the debugging....

[johnodon]

Hate to derail this convo, but on a side note...

@DirtBagXon I hope you don't mind (should have run it by you first), but I asked on the Libretro forums if they would have interest in porting your
code to a Libretro core. My post has received a few hearts (including HunterK) but no comments yet.

https://forums.libretro.com/t/request-port-hypseus-singe-to-a-libretro-core/34872

I don't know if it is even possible but this would allow us arcade Retroarch users to stay with a single emulator and benefit from the usual RA perks (i.e. bezels/overlays).

I hope I didn't step on your toes. :)

John

[DirtBagXon]

@johnodon said in Integrate Daphne Emulator back into the Retropie Script for Ubuntu:

https://forums.libretro.com/t/request-port-hypseus-singe-to-a-libretro-core/34872

 
I don't know if it is even possible but this would allow us arcade Retroarch users to stay with a single emulator and benefit from the usual RA perks (i.e. bezels/overlays).

 
I hope I didn't step on your toes. :)

Nope, not at all.

I did look at the Libretro docs some time ago, but never got around to attempting. I know the libretro Daphne port has audio issues, so hypseus might sort that out too as it's all moved to SDL2.

If someone wants to pick up on that port - I am more than happy to give my blessing.

 

[johnodon]

@dirtbagxon Fantastic! Thanks for your support!

John