PS4 controller not detected in Retropie 4.6 on Pi 4B

[A Former User]

I found some info about a patch to fix it:
https://bbs.archlinux.org/viewtopic.php?id=262451

--- a/drivers/hid/hid-sony.c	2021-12-21 22:16:46.190024249 -0500
+++ b/drivers/hid/hid-sony.c	2021-12-21 22:30:16.048986978 -0500
@@ -504,6 +504,7 @@
 
 #define DS4_FEATURE_REPORT_0x02_SIZE 37
 #define DS4_FEATURE_REPORT_0x05_SIZE 41
+#define DS4_FEATURE_REPORT_0x12_SIZE 16
 #define DS4_FEATURE_REPORT_0x81_SIZE 7
 #define DS4_FEATURE_REPORT_0xA3_SIZE 49
 #define DS4_INPUT_REPORT_0x11_SIZE 78
@@ -2593,6 +2594,55 @@
 	return 0;
 }
 
+static int sony_get_usb_ds4_devaddr(struct sony_sc *sc)
+{
+       u8 *buf = NULL;
+       int ret;
+
+       buf = kmalloc(max(DS4_FEATURE_REPORT_0x12_SIZE, DS4_FEATURE_REPORT_0x81_SIZE), GFP_KERNEL);
+       if (!buf)
+               return -ENOMEM;
+
+       /*
+        * The MAC address of a DS4 controller connected via USB can be
+        * retrieved with feature report 0x81. The address begins at
+        * offset 1.
+        */
+       ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
+                       DS4_FEATURE_REPORT_0x81_SIZE, HID_FEATURE_REPORT,
+                       HID_REQ_GET_REPORT);
+       if (ret == DS4_FEATURE_REPORT_0x81_SIZE) {
+               memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+               goto out_free;
+       }
+       dbg_hid("%s: hid_hw_raw_request(..., 0x81, ...) returned %d\n", __func__, ret);
+
+       /*
+        * Some variants do not implement feature report 0x81 at all.
+        * Fortunately, feature report 0x12 also contains the MAC address of
+        * a controller.
+        */
+       ret = hid_hw_raw_request(sc->hdev, 0x12, buf,
+                       DS4_FEATURE_REPORT_0x12_SIZE, HID_FEATURE_REPORT,
+                       HID_REQ_GET_REPORT);
+       if (ret == DS4_FEATURE_REPORT_0x12_SIZE) {
+               memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+               goto out_free;
+       }
+       dbg_hid("%s: hid_hw_raw_request(..., 0x12, ...) returned %d\n", __func__, ret);
+
+       hid_err(sc->hdev, "failed to retrieve feature reports 0x81 and 0x12 with the DualShock 4 MAC address\n");
+       ret = ret < 0 ? ret : -EINVAL;
+
+out_free:
+
+       kfree(buf);
+
+       return ret;
+}
+
+
+
 static int sony_check_add(struct sony_sc *sc)
 {
 	u8 *buf = NULL;
@@ -2613,26 +2663,9 @@
 			return 0;
 		}
 	} else if (sc->quirks & (DUALSHOCK4_CONTROLLER_USB | DUALSHOCK4_DONGLE)) {
-		buf = kmalloc(DS4_FEATURE_REPORT_0x81_SIZE, GFP_KERNEL);
-		if (!buf)
-			return -ENOMEM;
-
-		/*
-		 * The MAC address of a DS4 controller connected via USB can be
-		 * retrieved with feature report 0x81. The address begins at
-		 * offset 1.
-		 */
-		ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
-				DS4_FEATURE_REPORT_0x81_SIZE, HID_FEATURE_REPORT,
-				HID_REQ_GET_REPORT);
-
-		if (ret != DS4_FEATURE_REPORT_0x81_SIZE) {
-			hid_err(sc->hdev, "failed to retrieve feature report 0x81 with the DualShock 4 MAC address\n");
-			ret = ret < 0 ? ret : -EINVAL;
-			goto out_free;
-		}
-
-		memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
+                ret = sony_get_usb_ds4_devaddr(sc);
+                if (ret < 0)
+                        return ret;
 
 		snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
 			 "%pMR", sc->mac_address);
@@ -2670,6 +2703,7 @@
 		return 0;
 	}
 
+        dbg_hid("%s: retrieved MAC address: %s\n", __func__, sc->hdev->uniq);
 	ret = sony_check_add_dev_list(sc);
 
 out_free:

I don't know how to apply this patch to be able to test it with the controller.

Could someone tell me all the steps to follow to test this patch in Retropie?

Thanks

[mitu]

@juanzt said in PS4 controller not detected in Retropie 4.6 on Pi 4B:

https://bbs.archlinux.org/viewtopic.php?id=262451

The forum link you posted indicates this is a patch for a 3rd party PS4 controller, which fails detection because of missing functionality, but it might not work for all controllers (https://bbs.archlinux.org/viewtopic.php?pid=2010615#p2010615).

Could someone tell me all the steps to follow to test this patch in Retropie?

You could try to install using the makefile from https://github.com/soreau/hid-sony, but you'll need to replace the hid_sony.c file with the one from the upstream kernel and then apply the patch before installing it:

git clone https://github.com/soreau/hid-sony
cd hid-sony
wget -O hid-sony.c https://raw.githubusercontent.com/raspberrypi/linux/rpi-5.10.y/drivers/hid/hid-sony.c
# save the patch from https://bbs.archlinux.org/viewtopic.php?pid=2010615#p2010615 to a `patch.diff` file in the `hid-sony` folder
# then run the patch 
patch < patch.diff

make && sudo make install

[A Former User]

@mitu

Hello,

I do all these steps but it seems hid-sony.ko patched is not using because in hid-sony.c patched the string " failed to retrieve feature report 0x81 with the DualShock 4 MAC address" is not found and dmesg show this message.

Regards.

[mitu]

If the installation of the patched hid-sony module went fine, you should reboot before trying out again the controller. If that doesn't work, then the patched driver is not working with your controller.

[A Former User]

@mitu

I type

make && sudo make install

And then reboot.

When the system was reloaded again, I get "failed to retrieve feature report 0x81 with the DualShock 4 MAC address" in dmesg and I take a look a hid-sony.c patched and I not found this string in the file.

[mitu]

Then the patching hasn't been successful, maybe the patch doesn't apply correctly to the current version of hid-sony. Do you get any errors after running the patch command ?

[A Former User]

@mitu

patching file hid-sony.c
Hunk #1 succeeded at 476 (offset -28 lines).
Hunk #2 succeeded at 2455 (offset -139 lines).
Hunk #3 succeeded at 2524 (offset -139 lines).
patch unexpectedly ends in middle of line
Hunk #4 succeeded at 2564 with fuzz 1 (offset -139 lines).

It seems ok.

I have looked at the resulting hid-sony.c file and the new function appears and it seems that the rest of the things that have marked to remove on .diff file has been removed.

$ make && sudo make install
make -C /lib/modules/5.10.63-v7+/build M=/home/pi/hid-sony modules
make[1]: Entering directory '/usr/src/linux-headers-5.10.63-v7+'
  CC [M]  /home/pi/hid-sony/hid-sony.o
  MODPOST /home/pi/hid-sony/Module.symvers
  CC [M]  /home/pi/hid-sony/hid-sony.mod.o
  LD [M]  /home/pi/hid-sony/hid-sony.ko
make[1]:  Leaving directory '/usr/src/linux-headers-5.10.63-v7+'
cp hid-sony.ko /lib/modules/5.10.63-v7+/kernel/drivers/hid/

[mitu]

Looks like it the patch/install went ok, if it's still not working then maybe the patch is not enough for the controller.

[A Former User]

@mitu

I take a look at: https://github.com/soreau/hid-sony and I see a Reload module section.

I try it and I get this:

$ sudo rmmod hid_sony && modprobe hid-sony
modprobe: ERROR: could not insert 'hid_sony': Operation not permitted

How could I remove the module and add it again?

I type:

$ lsmod
Module                  Size  Used by
hid_sony               36864  0
hidp                   24576  2
cmac                   16384  1
bnep                   20480  0
hci_uart               40960  1
btbcm                  16384  1 hci_uart
bluetooth             393216  9 hidp,hci_uart,bnep,btbcm

hid_sony is not use.

[mitu]

@juanzt said in PS4 controller not detected in Retropie 4.6 on Pi 4B:

sudo rmmod hid_sony && modprobe hid-sony

This should be 'sudo rmmod hid_sony && sudo modprobe hid-sony, both operations require root` privileges.
Restarting will take care of loading the updated module, so that's an option.

[A Former User]

@mitu

Thanks for the info.

I reboot several times and I type:

$ dkms status
hid-sony, 0.1.3, 5.10.63-v7+, armv7l: installed (original_module exists)
xpad, 0.4, 5.10.63-v7+, armv7l: installed (original_module exists)

Could it be possible that it does not load the module that I have compiled?

hid-sony.c doesn't contains "failed to retrieve feature report 0x81 with the DualShock 4 MAC address" string. Where dmesg take it from?

Regards.

[mitu]

@juanzt said in PS4 controller not detected in Retropie 4.6 on Pi 4B:

Could it be possible that it does not load the module that I have compiled?

If you installed the Custom hid-sony driver from RetroPie-Setup, then you should un-install it and then re-install the patched driver.

[A Former User]

I uninstall Custom hid-sony driver and I type:

$ make && sudo make install

Then

$ sudo reboot

And on restart I type dmesg:

[   74.513174] usb 1-1.3: new full-speed USB device number 21 using dwc_otg
[   74.648746] usb 1-1.3: New USB device found, idVendor=054c, idProduct=09cc, bcdDevice= 1.00
[   74.648772] usb 1-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[   74.648784] usb 1-1.3: Product: Wireless Controller
[   74.648796] usb 1-1.3: Manufacturer: Sony Interactive Entertainment
[   74.648807] usb 1-1.3: SerialNumber: Wireless Controller
[   74.672009] sony 0003:054C:09CC.0011: failed to retrieve feature report 0x81 with the DualShock 4 MAC address
[   74.672389] sony 0003:054C:09CC.0011: hidraw0: USB HID v81.11 Gamepad [Sony Interactive Entertainment Wireless Controller] on usb-3f980000.usb-1.3/input3
[   74.672405] sony 0003:054C:09CC.0011: failed to claim input

Where dmesg take "failed to retrieve feature report 0x81 with the DualShock 4 MAC address" string from?

[mitu]

@juanzt Sorry, no idea why it's still not working.

[A Former User]

@mitu

It's Ok, thank you for guiding me through all the steps.

Regards.

[A Former User]

@mitu

After trying a thousand things, I try this:

 $ sudo modinfo hid_sony
filename:       /lib/modules/5.10.63-v7+/updates/dkms/hid-sony.ko
....
....
....

So path to hid_sony is /lib/modules/$(uname -r)/updates/dkms/ not /lib/modules/$(uname -r)/kernel/drivers/hid/

So I try this:

$ sudo cp ./hid-sony.ko /lib/modules/$(uname -r)/updates/dkms/

And now my controller works!!!!

 $ dmesg

[    8.590774] usb 1-1.3: Product: Wireless Controller
[    8.590789] usb 1-1.3: Manufacturer: Sony Interactive Entertainment
[    8.590803] usb 1-1.3: SerialNumber: Wireless Controller
[    8.639230] input: Sony Interactive Entertainment Wireless Controller Touchpad as /devices/platform/soc/3f980000.usb/usb1/1-1/1-1.3/1-1.3:1.3/0003:054C:09CC.0003/input/input2
[    8.639929] input: Sony Interactive Entertainment Wireless Controller Motion Sensors as /devices/platform/soc/3f980000.usb/usb1/1-1/1-1.3/1-1.3:1.3/0003:054C:09CC.0003/input/input3
[    8.704967] input: Sony Interactive Entertainment Wireless Controller as /devices/platform/soc/3f980000.usb/usb1/1-1/1-1.3/1-1.3:1.3/0003:054C:09CC.0003/input/input1
[    8.705567] sony 0003:054C:09CC.0003: input,hidraw0: USB HID v81.11 Gamepad [Sony Interactive Entertainment Wireless Controller] on usb-3f980000.usb-1.3/input3

Please include hid-sony.diff in Retropie to PS4 controllers that give the error: "failed to retrieve feature report 0x81 with the DualShock 4 MAC address" can work.

Thanks

[chrismeistre]

@JuanZt

Just stopped by to thank you. I've used your steps and was able to get my PS4 controller (not original) to work.