ES No Longer Saving Manual Metadata Entries

meleu

@mediamogul look at this post:
https://retropie.org.uk/forum/topic/3979/edited-game-rom-metadata-not-being-saved/5

Cheers!

mediamogul

It did appear that we were having the same issue and I was hopeful, but turning off 'Save Metadata on Exit' didn't work here. There may be something unique to my setup. I suppose it would help to try and reproduce the issue on another install. Could you perhaps edit the name of a game on your system that has not been scraped to see if it saves between sessions on your end?

BuZz

@mediamogul could be a recent es metadata related patch too.

meleu

@mediamogul you are right. It's not being saved.

@jacobfk20 could you confirm if your "save metadata on exit" optimization can be related with this issue? (I think not)
The problem is: ES isn't saving manual metadata entries even if "save metadata on exit" is off.

meleu

I compiled ES using the commit right before the @jacobfk20 PR and the problem still happens.

@BuZz could you tell what PR you are suspecting? Is it this one?

meleu

I compiled the ES commit right before the @jacobfk20 PR and the one before unclealex72 PR.

Both versions doesn't save my changes made to metadata in ES (pressing select and editing).

I did 4 tests:

commit before @jacobfk20 PR with "save metadata on exit" OFF: changed the name of a game from arcade dir and it didn't save, checked the arcade gamelist.xml and it is untouched.
commit before @jacobfk20 PR with "save metadata on exit" ON: changed the name of a game from arcade dir and it didn't save, checked the gamelist.xml and it is untouched (I didn't play anything).
commit before unclealex72 PR with "save metadata on exit" OFF: changed the name of a game from arcade dir and it didn't save, checked the arcade gamelist.xml and it is untouched.
commit before unclealex72 PR with "save metadata on exit" ON: changed the name of a game from arcade dir and it didn't save, checked the arcade gamelist.xml and it was updated (even though I didn't play anything, but it is the expected behaviour).

Conclusion: this bug was inserted before the recent ES metadata related PRs.

BuZz

It needs git bisecting - I will do it when I next have some free time.

jacobfk20

@meleu I'm confused... I can manually edit my metadata and it saves just fine. Are you talking about editing meta data externally from ES?

meleu

@jacobfk20 no. I'm talking about pressing select and edit metadata. Are you able to change the name of the game?

I made my tests changing the name of the game (as suggested by @mediamogul ).

jacobfk20

@meleu I just tried again inside ES. I changed a rom that was both scraped and one that had no metadata to begin with. I was able to change just their names, save, quit ES, re-open and they work just fine. Though this was on my Gridview branch.

meleu

@jacobfk20 said in ES No Longer Saving Manual Metadata Entries:

this was on my Gridview branch.

is your Gridview branch the master one of your github repository?

jacobfk20

@meleu No, it's the gridview branch here. It is even with Retropie except for the last two commits. I'll try saving again with vanilla.

jacobfk20

I built the latest ES from source and it still saves just fine on roms that are scraped and roms with no metadata entered. I also would have noticed this problem when doing my initial tests for my long exit time fix.