RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login

    Input needed: ES theming improvements

    Scheduled Pinned Locked Moved Projects and Themes
    themethemingemustationimprovementsbrainstorm
    255 Posts 32 Posters 175.6k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Z
      Zigurana @mattrixk
      last edited by

      @mattrixk : It should not break, (but please try it!). The way this works in ES, is by polling for the existence of a certain xml tag. The default ES expect a bunch of things to be there, otherwise it will fail miserably. With this we are adding to this collection, so no problem there.
      In addition, I've set some default values for the new ones, so even if you do not specify one (or even most) of them, ES will just use the default values. Which is an improvement over dying completely.

      If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

      1 Reply Last reply Reply Quote 0
      • Z
        Zigurana @lilbud
        last edited by

        @lilbud : For now the pre-compiled binaries are for windows, but it should compile on the Pi just fine. I just havnt found the time yet, to actually try that.

        If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

        lilbudL fieldofcowsF 2 Replies Last reply Reply Quote 0
        • lilbudL
          lilbud @Zigurana
          last edited by

          @Zigurana should I grab the fire extinguisher

          Creator of the Radiocade: https://retropie.org.uk/forum/topic/6077/radiocade

          Backlog: http://backloggery.com/lilbud

          R 1 Reply Last reply Reply Quote 1
          • R
            robertybob @lilbud
            last edited by

            @lilbud Because he's on fire?

            1 Reply Last reply Reply Quote 0
            • lilbudL
              lilbud
              last edited by

              No, probably attempting to compile it on the pi will cause it to be set ablaze.

              Creator of the Radiocade: https://retropie.org.uk/forum/topic/6077/radiocade

              Backlog: http://backloggery.com/lilbud

              Z 1 Reply Last reply Reply Quote 0
              • Z
                Zigurana @lilbud
                last edited by

                @lilbud aww man that's harsh. I mean, releasing the magic pixie smoke, sure. But actual fire? Come on.

                If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                1 Reply Last reply Reply Quote 0
                • RookervikR
                  Rookervik Global Moderator
                  last edited by

                  I couldn't get the windows build to run. Tried copying the files over an older, complete, version of ES and it still wouldn't run. It's missing a lot of DLLs.

                  Z 1 Reply Last reply Reply Quote 0
                  • fieldofcowsF
                    fieldofcows @Zigurana
                    last edited by

                    @Zigurana I've ported your commit to my local branch and built it for raspberry pi. It seems to work fine although I haven't done exhaustive testing yet.

                    I've noticed that the default logo size is different to the normal ES - if I don't include a <systemcarousel> tag then the carousel icons are smaller than the icons used in the stock ES:

                    0_1481759285250_es_carousel_orig.jpg
                    Original

                    0_1481759304428_es_carousel_new.jpg
                    With carousel modification but no theme elements

                    I think it would probably be sensible to set the defaults to work exactly as the original carousel did to ensure existing themes work correctly.

                    I used your sample config and added 5 different system types and the carousel configuration seems to work nicely.

                    0_1481759836275_es_carousel_theme.jpg

                    I'll give the code a review tomorrow and let you know my comments :) Looking good :D

                    N 1 Reply Last reply Reply Quote 3
                    • N
                      Nismo @fieldofcows
                      last edited by

                      @fieldofcows Or there is some error there, or you have exactly the same amount of games in mame than nes...

                      fieldofcowsF 1 Reply Last reply Reply Quote 0
                      • fieldofcowsF
                        fieldofcows @Nismo
                        last edited by

                        @Nismo said in Input needed: ES theming improvements:

                        @fieldofcows Or there is some error there, or you have exactly the same amount of games in mame than nes...

                        No bug. I only have mame games on my pi so I duplicated the mame gamelist for each system just to have something to test.

                        1 Reply Last reply Reply Quote 0
                        • Z
                          Zigurana @Rookervik
                          last edited by

                          @Rookervik
                          <sigh> it just never ends... </sigh>
                          I'll build again tonight, but then release version. Maybe that will clear things up.

                          If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                          mediamogulM 1 Reply Last reply Reply Quote 1
                          • mediamogulM
                            mediamogul Global Moderator @Zigurana
                            last edited by

                            @Zigurana said in Input needed: ES theming improvements:

                            <sigh> it just never ends... </sigh>

                            alt text

                            RetroPie v4.5 • RPi3 Model B • 5.1V 2.5A PSU • 16GB SanDisk microSD • 512GB External Drive

                            1 Reply Last reply Reply Quote 1
                            • Z
                              Zigurana
                              last edited by

                              Ok, Ive updated the archive, now based on the Release build, and tried it on another PC, so this time anyone with a windows machine should be able to try this out.

                              Get it here

                              If I remember well, this should also include a better default behaviour (closer to current ES).

                              For Rpi, you'll need to build this yourself atm, but that way you are sure to get the latest version!

                              If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                              N 1 Reply Last reply Reply Quote 1
                              • N
                                Nismo @Zigurana
                                last edited by Nismo

                                @Zigurana Has this fork video support?

                                Z 1 Reply Last reply Reply Quote 0
                                • Z
                                  Zigurana @Nismo
                                  last edited by

                                  @Nismo This was rebased dec 15th, with the RetroPie Master, so video is in.

                                  But please note, this is not meant to be used in your 'production' setup, I supply this solely for testing.
                                  I do not think this new feature impacts anything on the video snaps side, as it acts only on the systemView objects, not the gameListViews.

                                  Once testing and straightening out of the code has taken place, I will create a PR, and once it is accepted into RetroPie/master, people will be able to use it proper.

                                  If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                                  N RookervikR 2 Replies Last reply Reply Quote 1
                                  • N
                                    Nismo @Zigurana
                                    last edited by

                                    @Zigurana Thanks a lot, it's a nice commit, i'll try to find some time to test and comment here, I'm a little busy lately because the christmas.

                                    1 Reply Last reply Reply Quote 0
                                    • RookervikR
                                      Rookervik Global Moderator @Zigurana
                                      last edited by

                                      @Zigurana Ok this version works. I will test it out some when I have a little more time.

                                      1 Reply Last reply Reply Quote 1
                                      • RookervikR
                                        Rookervik Global Moderator
                                        last edited by

                                        I do not think video preview is working in this build of ES. I tried setting it up for 3 days and couldn't get it to work. I downloaded fieldofcow's ES and it worked right away.

                                        I will test the carousel bar next.

                                        Z 1 Reply Last reply Reply Quote 2
                                        • Z
                                          Zigurana @Rookervik
                                          last edited by

                                          @Rookervik / anyone else :
                                          Did you manage to try out the theming of the carousel bar?
                                          If there are no open bugs, I'll prepare a PR for this.

                                          If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                                          J N 2 Replies Last reply Reply Quote 1
                                          • J
                                            jdrassa @Zigurana
                                            last edited by

                                            @Zigurana

                                            I haven't had a chance to test your changes, but I did look over your code and had a couple of suggestions.

                                            • Make element names camel case. This would make it consistent with how the other elements are named.
                                            • Merge logosizex and logosizey into a single logoSize element. This is how size is specified everywhere else in the theme.

                                            Here is an example of the theme with these changes.

                                             <systemcarousel name = "carousel">
                                                <yPos>0.80</yPos>
                                                <height>0.1</height>
                                                <color>f0f0f000</color>
                                                <infobarColor>90909060</infobarColor>
                                                <infobarFontPath>./art/font.ttf</infobarFontPath>
                                                <infobarFontSize>0.033</infobarFontSize>
                                                <infobarFontColor>ffffffff</infobarFontColor>
                                                <logoScale>1.2</logoscale>
                                                <logoSize>0.22 0.24</logoSize>
                                                <maxLogoCount>5</maxLogoCount>
                                            </systemcarousel>
                                            

                                            Also, I believe that you mentioned that you fixed the default sizes, but it doesn't look like that change made it into your branch on github.

                                            It is all nitpicky, but I figured I would mention it. Great job though. Can't wait to see this change land.

                                            Get latest build of EmulationStation for Windows here

                                            1 Reply Last reply Reply Quote 2
                                            • First post
                                              Last post

                                            Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                            Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.