Flat Theme

mattrixk

@herb_fargus I think the <video> and <image> tags kind of get tied up together on Video View, so maybe your <image> tag was getting in the way?

Nismo

@mattrixk Originally marquee tag was created to display the marquee of an arcade cabinet in arcade systems (mame, fba) theme.

So usually marquee it's for displaying marquees in arcade or logos in console systems.

Of course it's another image so you can use it like you want.

Regards.

Nismo

@herb_fargus @lilbud Adding sounds it's pretty simple.

Example for sound when switching between systems:

<view name="system">
	
     <sound name="systemSound">
         <path>./art/systemsound.wav</path>
     </sound>
</view>

Example for gamelist sound:

<textlist name="gamelist">

	<scrollSound>./art/listscroll.wav</scrollSound>
</textlist>

As you can see it's pretty simple to add sounds...

Regards.

mattrixk

Thanks @Nismo, that explains why it's called "marquee" I guess. Also, I didn't know you could already do System switching sounds. I thought Gamelist cycle was the only one that worked. Is that a newer development or has it always been that way?

Nismo

@mattrixk It was a request I did to @fieldofcows lot of months ago, before video view was implemented in the main branch, it's working for me in windows, you can see it working in one of my videos here:

I don't know if it's working in the main branch (unfortunately I don't have a raspberry pi), because he removed a lot of features to add only video support to the main branch, but you can test it because it doesn't break the theme . My theme have that code and the sounds works in windows and nobody told me the theme it's broken in their rpi.

If system sound it's not working in main branch tell me and we can ask to @fieldofcows to make a pull request, so the code it's done and working very good, only that he removed some features for better testing if video implementation on main branch could cause bugs, don't need to worry about other commits.

Anyway you can add the tags for windows users because your theme should still working like before.

lilbud

@Nismo could you submit a PR to the repository? I am away from my computer at the moment.

Thanks in advance.

Nismo

@lilbud I don't know how to use github... (yes it's a shame for me), but I can try to do it.

The question is, you are the developer of this theme, so it's not better that you choose the sounds you like for your theme?

And how can I upload the sound files to your github?

robertybob

I found a website called freesound.org and picked a space-like sound :D

@Nismo I didn't how to add that system switching sound, so I've added it to my theme now. Thanks!!

Nismo

@robertybob No problem mate, tell me if it works on your rpi because I have no rpi to test, but for sure it will work on windows if you use the ES version with video support.

Gamelist sound will work for sure, I mean system sound.

Nismo

@herb_fargus @lilbud I have found an error in the code of your main flat.xml file. Maybe that's because your theme it's broken.

Problem is <view name="video"> and </view> tags are missing:

<feature supported="video">
		
	  <image name="md_marquee">
			<origin>0 0</origin>
			<pos>0.800 0.01</pos>
			<maxSize>0.19 0.10</maxSize>
	  </image>
	  
	  <video name="md_video">
			<pos>0.254 0.202</pos>
			<origin>0 0</origin>
			<size>0.185 0.327</size>
			<delay>0.0</delay>
			<default>./assets/static.mp4</default>
			<showSnapshotNoVideo>false</showSnapshotNoVideo>
			<showSnapshotDelay>false</showSnapshotDelay>
	  </video>
	  
	</feature>

</theme>

@herb_fargus can you make this changes to github and test it please?, (I don't know how to use github), change the code above for this one:

<feature supported="video">

    <view name="video">	
	  <image name="md_marquee">
			<origin>0 0</origin>
			<pos>0.800 0.01</pos>
			<maxSize>0.19 0.10</maxSize>
	  </image>
	  
	  <video name="md_video">
			<pos>0.254 0.202</pos>
			<origin>0 0</origin>
			<size>0.185 0.327</size>
			<delay>0.0</delay>
			<default>./assets/static.mp4</default>
			<showSnapshotNoVideo>false</showSnapshotNoVideo>
			<showSnapshotDelay>false</showSnapshotDelay>
	  </video>
	  
	</view>
   </feature>
</theme>

I hope this helps. Regards.

robertybob

@Nismo @lilbud

I think I've corrected it(?)

https://github.com/lilbud/es-theme-flat/pull/4

Nismo

@robertybob I think my code it's ok now.

lilbud

For sounds, which would be better?

http://rcptones.com/dev_tones/tones/digi_plink.wav

or

http://rcptones.com/dev_tones/tones/click_04.wav

Nismo

@lilbud I like both of them, for me I think the number 2 it's better.

robertybob

@Nismo Herb edited my space.xml the same way :)

Nismo

@robertybob Ok no problem then, now we only need somebody to test if it's fixed XD. Thanks.

Nismo

@robertybob It's the system sound working in your Rpi?

herb_fargus

@robertybob don't know if I did it right though ;) anyways I'll look at all this when I get time after work and all that, but if someone fixes / tests before me then that's great too. Saves me the trouble ;)

Nismo

@herb_fargus I think the right way it's this:

<feature supported="video">

   <view name="video">	
   </view>

</feature>

This way have sense...

robertybob

@Nismo said in Flat Theme:

@robertybob It's the system sound working in your Rpi?

I'm not able to test until tomorrow night, but I'll report back then :)