RP4.2 Exit game returns to top of the list?

dsstrainer

RP4.2
RPi3
ES-kids edition

edmaul69

@dsstrainer what mode are you in using es kids?

pjft

A while back when I was doing some work on gamelists I ended up getting myself in a similar state in my own ES build, so that's definitely related to EmulationStation.

Given that ES-Kids hasn't been updated in several months (almost 9 months), I am strongly inclined to suggest that that bug might've been there all along, but either you hadn't noticed it or run into it.

There aren't any relevant changes in 4.2 that would affect a ES-Kids installation in this regard.

Would you confirm that, after you return to ES after a game, that you're still in ES-Kids (i.e. do the menus have the ES-Kids options)?

Best of luck.

dsstrainer

Kiosk mode is clutch and that really needs to get into the main branch. But I've tried kiosk and full, same on both.
But it has been updated. My image from 4 months ago had ES-kids 2.0.3 and now its updated to 2.1.6 so it could be a bug in the latest version. 2.0.3 definitely did not have this issue so I wasn't sure if it was something with 4.2 or the new ES Kids.

Yes ES Kids is what you return to after game.. it all works the same as it should, with the exception of this return top.

I'll have to try the regular version again and then rollback to a previous version of ES-kids

pjft

@dsstrainer I see, you are correct. It seems to have been rebased.

Definitely submit feedback on the GitHub repository - @Zigurana will be more than happy to hear about it. I'm sure it can be fixed shortly. :)

dsstrainer

Seems i'm not the only one with the issue... another user just posted it yesterday
https://github.com/zigurana/EmulationStation/issues/49

Thanks all!

no3grover

I recently tested the ES-Kids/Kiosk mode and observed the same behavior. Initial thought was it may be permission based, but didn't do extensive testing and am no longer testing with ES Kids/Kiosk packages.

Zigurana

I've pushed an update for this (actually, amended the previous commit, so it does not show up as yet another separate fix commit). It was the result of me not taking care of business properly, so I actually forgot to finish this.
It's kind of tricky territory, with a small chance of empty list => failing assertions => crashing ES, so please make a proper backup before you try this out.
I would appreciate it if anyone could give this a test! Especially toggling favorites while in 'show only favorites' mode, and getting to empty lists.

pjft

@Zigurana I'll happily test in the coming days! I saw you had rebased your branch recently - that must have been a mammoth effort! Any new developments, or just bringing it up to speed with ES?

I had been meaning to ask you: would you object if I tried to merge your kids-friendly changes into a OMX+screensaver branch I maintain? I know several people use the OMX branch on the Pi, and I imagine they might want the option of being able to benefit from your developments while keeping OMX player around.

Also, I personally miss the kids+favorites options - I was using this before video coming up, but now with OMX I'm kind of stuck with it on the Pi. Let me know, as I'd appreciate your thoughts before attempting that!

Finally, a question: what did you do in terms of the surprise me keyboard shortcut in this branch?

Have a great weekend good sir!

Edit: also, if you have my code for filtering, I'm happy to take a stab at moving your favorites and kids code to it and submit a PR to your branch. That might help with the empty list handling as well, as I had addressed that to a certain extent. No promises I'll get to that but happy to try:)

Zigurana

@pjft thanks for the kind words!
The rebase was done just after the video views landed (april 4th?), but I'll attempt another one asap, it should be a quite a bit smaller delta than earlier.
The reason I did a rebase in which I squashed many of the commits was exactly to enable folks to lift it over to their own streams. Three commits are easier to manage than 30+ :-).
So, by all means have a look, I am sure you can come up with many improvements. By now I am sure I've become effectively blind to many of the hacks and clutches in this branch.
My next step is to bring this to main, by extending the Metadata types, and building on top of your filtering mechanism.

dsstrainer

Working great now Zig! Thank you so much.
Is there any chance the kiosk mode version could get merged into the main release version? I think these features are absolutely core features and would love them to be the new base minimum.