RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login

    Favorites for EmulationStation

    Scheduled Pinned Locked Moved Ideas and Development
    emulationstatiofavouritestestingfilter
    115 Posts 15 Posters 54.9k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • pjftP
      pjft @TMNTturtlguy
      last edited by

      @TMNTturtlguy Not necessarily here - I think here was more about how to best render the "star" icon for the favorites that @Zigurana was trying to implement in this "Favorites" change :)

      Nonetheless, all your change requests sound reasonable. I believe there's a massive thread where like-minded theme creators are having those conversations. @Zigurana , @mattrixk - is this the latest thread where those requests and conversations are being added and discussed? Or is there a running Google doc?

      Definitely echo these there, as I'm sure they'll benefit from the discussion and design conversations :)

      Thanks!

      1 Reply Last reply Reply Quote 0
      • herb_fargusH
        herb_fargus administrators
        last edited by

        Personally I'm not keen on requiring specific fonts for rendering folder icons, but them again I don't know if I have a better solution than what's been proposed either. Also I don't use folders so my opinion doesn't count much at that rate!

        If you read the documentation it will answer 99% of your questions: https://retropie.org.uk/docs/

        Also if you want a solution to your problems read this first: https://retropie.org.uk/forum/topic/3/read-this-first

        1 Reply Last reply Reply Quote 1
        • Z
          Zigurana
          last edited by

          Some inspiration :
          The guys over at the Recalbox branch of ES have just committed a change that hardcodes a specific glyph to be used as a fav icon for each system.
          These glyphs are pulled from the large web awesome font collection, which can cater to a large number of icon related use-cases.

          If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

          pjftP 1 Reply Last reply Reply Quote 2
          • DarkWolfD
            DarkWolf
            last edited by DarkWolf

            I think I'am missing something here (I kinda feel stupid right now):
            So I tryed to install your es build but it doesn't seam to change anything...
            I followed the steps to make the emulationstation file and installed it (over an existing emulationstation build). But I don't see a change at all...
            The emulationstation version is now V2.1.4 RP which is correct I think.. Do I have to do something now?

            System: Raspberry 3 Model B, RetroPie 4.2.1
            Storage: 16gb Micro SD, 64gb USB Drive
            Theme: Updated NBBA

            Documentation solves many problems: https://retropie.org.uk/docs/

            Z 1 Reply Last reply Reply Quote 0
            • pjftP
              pjft @Zigurana
              last edited by

              @Zigurana ...a favicon? Do you mean a favorites icon per system?

              I imagine that's good overall, but without seeing it in action, I struggle to grasp the full extent of that change for the users and for the theme makers :/ Is there a video or set of images I could reference to better understand what we're considering?

              Anyway, to avoid scope creep, maybe we could break down the "implementing favorites with the old metadata icon in the theme data", for feature parity with ES Kids, and then maybe "customizing games list and theme with further icons for folders and favorites"?

              Just a thought, as I don't want you to lose momentum here :)

              Z 1 Reply Last reply Reply Quote 1
              • Z
                Zigurana @DarkWolf
                last edited by

                @DarkWolf you sure you got the favorites dev branch, and not the master branch?
                The version# should be "2.1.8rp".

                If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                DarkWolfD 1 Reply Last reply Reply Quote 2
                • DarkWolfD
                  DarkWolf @Zigurana
                  last edited by DarkWolf

                  @Zigurana Oh, well, that's embarassing...
                  Not using github that much, so I thought https://github.com/zigurana/EmulationStation.git would be the correct link to clone it... Isn't it? Ok, no it isn't... wow...
                  I got it now, I think, thanks for answering

                  System: Raspberry 3 Model B, RetroPie 4.2.1
                  Storage: 16gb Micro SD, 64gb USB Drive
                  Theme: Updated NBBA

                  Documentation solves many problems: https://retropie.org.uk/docs/

                  Z 1 Reply Last reply Reply Quote 0
                  • Z
                    Zigurana @pjft
                    last edited by

                    @pjft good point, scope creep is my arch-nemesis!
                    So, the current plan:

                    • I'll revert the cosmetic changes i've made to the gamelist entries, and
                    • re-introduce the themable favorites Icon which is toggled when the selected item is a favorite or not.

                    Sounds ok?

                    If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                    pjftP 1 Reply Last reply Reply Quote 3
                    • Z
                      Zigurana @DarkWolf
                      last edited by

                      @DarkWolf no worries, thank you for testing this!

                      If tetris has thought me anything, it's that errors pile up and that accomplishments dissappear.

                      DarkWolfD 2 Replies Last reply Reply Quote 0
                      • S
                        Syhles
                        last edited by

                        @Zigurana
                        My personal opinion is that the favorites icon and folder icon should be handled like the help icons, there should be a default icon built in to EmulationStation for them, but you should be able to point to new images in the theme to replace them.

                        I'm not sure how feasible that is, but this way it wouldn't break any themes and we would also keep easy themeablilty.

                        DarkWolfD TMNTturtlguyT 2 Replies Last reply Reply Quote 4
                        • DarkWolfD
                          DarkWolf @Syhles
                          last edited by

                          @Syhles That sounds like a good solution if you ask me

                          System: Raspberry 3 Model B, RetroPie 4.2.1
                          Storage: 16gb Micro SD, 64gb USB Drive
                          Theme: Updated NBBA

                          Documentation solves many problems: https://retropie.org.uk/docs/

                          1 Reply Last reply Reply Quote 3
                          • TMNTturtlguyT
                            TMNTturtlguy @Syhles
                            last edited by

                            @Syhles agreed!

                            1 Reply Last reply Reply Quote 1
                            • DarkWolfD
                              DarkWolf @Zigurana
                              last edited by

                              @Zigurana SO now I cloned it with
                              git clone -b Favorites https://github.com/zigurana/EmulationStation.git
                              The problem is that the cmake -DCMAKE_CXX_COMPILER=g++-4.7 . fails with

                              /home/pi/EmulationStation/external/pugixml does not contain a CMakeLists.txt file.

                              Any thoughts on that one?

                              System: Raspberry 3 Model B, RetroPie 4.2.1
                              Storage: 16gb Micro SD, 64gb USB Drive
                              Theme: Updated NBBA

                              Documentation solves many problems: https://retropie.org.uk/docs/

                              pjftP 1 Reply Last reply Reply Quote 0
                              • pjftP
                                pjft @DarkWolf
                                last edited by

                                @DarkWolf a recent change meant that we need to initialize the submodules the first time around. Run:

                                git submodule update --init
                                
                                DarkWolfD 1 Reply Last reply Reply Quote 1
                                • DarkWolfD
                                  DarkWolf @pjft
                                  last edited by

                                  @pjft Wow, that was easy, thanks!
                                  I have to learn more things about git obviously

                                  System: Raspberry 3 Model B, RetroPie 4.2.1
                                  Storage: 16gb Micro SD, 64gb USB Drive
                                  Theme: Updated NBBA

                                  Documentation solves many problems: https://retropie.org.uk/docs/

                                  1 Reply Last reply Reply Quote 0
                                  • pjftP
                                    pjft @Zigurana
                                    last edited by

                                    @Zigurana I think that's a wise way to break things up. Especially as, at least the way I see it, some themes may opt to keep the icons in the per game metadata section like in your branch, either exclusively (I.e. not having it in the games list) or in conjunction with this change.

                                    But either way, it can be tackled later. :)

                                    Do let me know if/how I can help!

                                    1 Reply Last reply Reply Quote 2
                                    • DarkWolfD
                                      DarkWolf @Zigurana
                                      last edited by

                                      @Zigurana Omg that is so awesome! I was waiting for something like this for quite some time now. It's way better than the kids mode!
                                      Keep up that great work, works like a charm!

                                      OT: The emulationstation developers are a bit overdramatic

                                      make
                                      This will take a very, very long time (multiple hours).

                                      Literally took 15mins

                                      System: Raspberry 3 Model B, RetroPie 4.2.1
                                      Storage: 16gb Micro SD, 64gb USB Drive
                                      Theme: Updated NBBA

                                      Documentation solves many problems: https://retropie.org.uk/docs/

                                      pjftP 1 Reply Last reply Reply Quote 0
                                      • pjftP
                                        pjft @DarkWolf
                                        last edited by

                                        @DarkWolf it might have been written at s time when only the Pi 1 was around. But either way, under promising and over delivering is better than the other way around:)

                                        1 Reply Last reply Reply Quote 3
                                        • DarkWolfD
                                          DarkWolf
                                          last edited by

                                          One thing I noticed is that if I want to shutdown/restart the system it only closes emulationstation and leaves me with a console left

                                          System: Raspberry 3 Model B, RetroPie 4.2.1
                                          Storage: 16gb Micro SD, 64gb USB Drive
                                          Theme: Updated NBBA

                                          Documentation solves many problems: https://retropie.org.uk/docs/

                                          pjftP 1 Reply Last reply Reply Quote 0
                                          • pjftP
                                            pjft @DarkWolf
                                            last edited by

                                            @DarkWolf that's normal when you're calling emulationstation from the terminal. :)

                                            DarkWolfD 1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                            Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.