Help testing: Random Video Screensaver on Main Branch

Hex · 1 Jun 2017, 23:05

@pjft said in Help testing: Random Video Screensaver on Main Branch:

@Hex ok. It looks like I'll need to adjust VLC as a screensaver then as it might not be hardware accelerated. That's a shame as the text will look crappy :/ but it is what it is. Thanks for testing that.

What do you mean the video snap is out of place - can you share a screenshot? That would help - I may have certainly unknowingly reverted some code, since this was put together earlier in the year.

I take it it wasn't happening on the public 2.2.0 release?

Thank you very much!

You will have to read the setting to determine which player is being used for videos and switch accordingly.

pjft · 1 Jun 2017, 23:07

@Hex oh my, that is messed up. Will look into that - likely some merge problem.

Thanks.

Hex · 6 Feb 2017, 00:10

I works well in Retropie ES master branch so you can look at diffs and figure out

pjft · 1 Jun 2017, 23:16

@Hex yeah, must have messed up something simple on the merge. Thanks!

It's past midnight here, will look into it tomorrow or during the weekend.

TMNTturtlguy · 2 Jun 2017, 01:20

@pjft just an fyi - you do not use .git in @meleu script. for the repository enter:

https://github.com/pjft/EmulationStation

Branch Enter:

RetroPie-ScreenSaver-Merge

meleu · 2 Jun 2017, 02:00

@TMNTturtlguy said in Help testing: Random Video Screensaver on Main Branch:

@pjft just an fyi - you do not use .git in @meleu script.

Hey bro, the script should be smart enough to deal with the trailing .git. I tested here and it works fine with that. Are you having problems?

TMNTturtlguy · 2 Jun 2017, 02:18

@meleu yes I am. I went to add a new repository and typed it in with .git and it said that it was not a proper link to the branch and would not add it to the list. I then typed it in without the .git and it added it to my list. I went to the list, selected it and it started to download/compile.

TMNTturtlguy · 2 Jun 2017, 03:30

@pjft - Tested on retropie and as expected it appears to be working 100% the way it should be. Nice work!

meleu · 2 Jun 2017, 04:10

@TMNTturtlguy said in Help testing: Random Video Screensaver on Main Branch:

@meleu yes I am. I went to add a new repository and typed it in with .git and it said that it was not a proper link to the branch and would not add it to the list.

You are right! Sorry for looking like I'm doubting you. :-)

In my tests I edited es-repos.txt files directly... My bad.

Anyway, the script can deal with trailing .git now. Could you update and test it again, please? (remember: you can update using the script itself).

Thanks bro!

TMNTturtlguy · 2 Jun 2017, 04:12

@meleu I am not on my pi now, but i will update and get back to you! Thanks for taking a second look into it. Really nice utility you build for us.

Hex · 2 Jun 2017, 05:30

@pjft said in Help testing: Random Video Screensaver on Main Branch:

@Hex ok. It looks like I'll need to adjust VLC as a screensaver then as it might not be hardware accelerated. That's a shame as the text will look crappy :/ but it is what it is. Thanks for testing that.

What do you mean the video snap is out of place - can you share a screenshot? That would help - I may have certainly unknowingly reverted some code, since this was put together earlier in the year.

I take it it wasn't happening on the public 2.2.0 release?

Thank you very much!

I am testing on PC. It is still compiling on my PiZ :|

pjft · 2 Jun 2017, 07:02

@Hex Thanks.

Just added some options for Screensaver quality on Linux, hopefully it helps. I wasn't able to test, but do let me know how it goes. It starts as lower quality, so if you use the game name text option, it'll look quite crappy.

As for the video position, you have me stumped - I was looking at the code and didn't see anything particularly different. Will have to look later.

Thanks!

pjft · 2 Jun 2017, 09:38

Small update: VLC isn't yet rendering the screensaver on non Pi systems. I suspect it's related to the z-index changes, I'll need to investigate what needs to be done for that. Sorry.

As for the video location, that's weird. It renders well on the Pi with VLC, and nothing seems to have changed. Did you edit the theme per chance?

TMNTturtlguy · 2 Jun 2017, 14:01

@meleu said in Help testing: Random Video Screensaver on Main Branch:

You are right! Sorry for looking like I'm doubting you. :-)

In my tests I edited es-repos.txt files directly... My bad.

Anyway, the script can deal with trailing .git now. Could you update and test it again, please? (remember: you can update using the script itself).

Thanks bro!

@meleu, I updated the script and this now works correctly. Thanks

Hex · 2 Jun 2017, 15:43

@pjft No, actually the entire setup is the same. I am just running two binaries to compare

pjft · 2 Jun 2017, 16:04

@Hex hm. I might need some help troubleshooting that one then, as it's not happening on the Pi on VLC so I'm a bit at a loss. Is your other binary the 2.2.0 one?

I'll take a look at it later today or during the weekend and see.

Thanks!

Hex · 2 Jun 2017, 16:08

Yes both binaries are updated

Hex · 2 Jun 2017, 19:32

@pjft Tried on Pi3 compiled very fast. Problem was that the Video is in the middle of the gamelist. same as the photo above but zoomed out because I am running it on 1080p.

When the screensaver starts, it runs for few seconds before HDMI shuts off. Pressing Up/Down brings HDMI back up.

pjft · 2 Jun 2017, 19:50

@Hex Ok.

So, that's a weird thing, and I'm starting to suspect it's something related to the theme. Could you try changing the theme, or something? I cannot replicate the video showing in the middle of the gamelist at all, much less on the Pi :(

Can you share one of the theme files for the system you're having problems with? Alternatively, maybe someone else is having the same problem and can chime in, but I'm struggling with that one as I cannot replicate it.

As for HDMI shutting off, it's likely related to one of the bullet points I left at the first post:

Note 3: if, after enabling the video game name on screensaver the screen loses signal when rendering the screensaver, that's unfortunately a known OMX/SDL layer limitation. The workaround is to either disable that option, or add disable_overscan=1to your /boot/config.txt file.

Does that happen with the "Show game name" option set to off? Can you try disabling overscan?

I'm looking into the VLC screensaver tonight, should have news soon.

meleu · 6 Feb 2017, 21:12

@Hex said in Help testing: Random Video Screensaver on Main Branch:

Problem was that the Video is in the middle of the gamelist.

Same thing here on my RetroPie x86 (Linux Mint). It happened with ComicBook and Carbon themes.

Changed back to the official EmulationStation and the video is in the right place...

I'm away from computer now but can give more details when I get home.