RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login

    Long standing ES bugs

    Scheduled Pinned Locked Moved Ideas and Development
    es bugsemultionstationbugs
    57 Posts 6 Posters 19.9k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • lilbudL
      lilbud @ruckage
      last edited by

      @ruckage Has this been added to the Retropie ES?

      Creator of the Radiocade: https://retropie.org.uk/forum/topic/6077/radiocade

      Backlog: http://backloggery.com/lilbud

      S 1 Reply Last reply Reply Quote 1
      • S
        Syhles @lilbud
        last edited by Syhles

        @lilbud
        No these features haven't been added ​to the main branch (RetroPie's ES), you can test them to speed along the process of them getting added though.

        @jdrassa
        Tested this build, everything seems to be working as intended. Had no issues during testing and the selector image seemed to work perfectly fine. Also I have no video snaps so I can't​comment on them being broken.

        lilbudL 1 Reply Last reply Reply Quote 0
        • lilbudL
          lilbud @Syhles
          last edited by

          @jdrassa Could Selector Size be added as an element for the selector bar?

          Creator of the Radiocade: https://retropie.org.uk/forum/topic/6077/radiocade

          Backlog: http://backloggery.com/lilbud

          ruckageR 1 Reply Last reply Reply Quote 0
          • ruckageR
            ruckage @lilbud
            last edited by

            @lilbud
            It's already added (the height at least) <selectorScale>. The width is the width of the game list.

            SNES mini/Nes mini/Famicom mini theme developer.

            If you'd like to support my work you can donate here: Donate

            lilbudL 1 Reply Last reply Reply Quote 1
            • lilbudL
              lilbud @ruckage
              last edited by

              @ruckage Could the width be changed with a separate element?

              Creator of the Radiocade: https://retropie.org.uk/forum/topic/6077/radiocade

              Backlog: http://backloggery.com/lilbud

              1 Reply Last reply Reply Quote 0
              • J
                jdrassa
                last edited by

                https://ci.appveyor.com/api/buildjobs/q63ax46bxlr37917/artifacts/EmulationStation-Win32.zip

                Here is an updated Windows build for anyone interested.

                <selectorScale> has been swapped out for `<selectorHeight>' which now functions like other sizes and is a ration of the screen height.

                I also updated THEMES.md to document the new options.
                https://github.com/jrassa/EmulationStation/blob/gamelist-fixes/THEMES.md#textlist

                @ruckage I haven't seen any issues with video scaling.

                @lilbud It is certainly possible, but I would need to be convinced it would be worth the effort. If you want the selector image to be wider than the text, you can use horizontalMargin. I can't think of a use case for having the image be narrower, but it could be achieved by having transparent space on the sides of the image.

                Get latest build of EmulationStation for Windows here

                S ruckageR 2 Replies Last reply Reply Quote 2
                • S
                  Syhles @jdrassa
                  last edited by

                  @jdrassa
                  I'll test out the new build later today.

                  1 Reply Last reply Reply Quote 0
                  • ruckageR
                    ruckage @jdrassa
                    last edited by ruckage

                    @jdrassa
                    Thanks. I tried the new build and <selectorHeight> works perfectly.

                    Regarding the video scaling, I'm not sure if it's affecting the videos themselves - I'm using Video view but without videos so it shows just an image preview instead.

                    You can see below, the preview images are squashed vertically, however in the latest standard version of ES it displays normally.

                    0_1496596874947_selector bar test.png

                    SNES mini/Nes mini/Famicom mini theme developer.

                    If you'd like to support my work you can donate here: Donate

                    J S 2 Replies Last reply Reply Quote 1
                    • J
                      jdrassa @ruckage
                      last edited by

                      @ruckage I was able to reproduce the issue with the image scaling. Looks like it was an existing issue. My branch was a few commits behind the RetroPie repository. I updated it to pull in the latest changes and it is scaling properly now.

                      Get latest build of EmulationStation for Windows here

                      S ruckageR 2 Replies Last reply Reply Quote 2
                      • S
                        Syhles @jdrassa
                        last edited by Syhles

                        @jdrassa
                        I haven't checked the build where you added the video fix, but I tried the one before that with all of the bug fixes, seemed to be working without any issues along with the selector image and scale, couldn't get anything else to act incorrectly as I don't have videos.

                        Do I need to check the video fix build as well? Or was that the only change?

                        J 1 Reply Last reply Reply Quote 1
                        • J
                          jdrassa @Syhles
                          last edited by

                          @Syhles No need to check. The only change was to sync up with the RetroPie repository.

                          Get latest build of EmulationStation for Windows here

                          S 1 Reply Last reply Reply Quote 2
                          • S
                            Syhles @jdrassa
                            last edited by

                            @jdrassa
                            Then everything seems to be in working order from my testing.

                            1 Reply Last reply Reply Quote 0
                            • S
                              Syhles @ruckage
                              last edited by

                              @ruckage
                              These changes have been merged to main RetroPie branch as of today.

                              ruckageR 1 Reply Last reply Reply Quote 1
                              • ruckageR
                                ruckage @Syhles
                                last edited by

                                @Syhles said in Long standing ES bugs:

                                @ruckage
                                These changes have been merged to main RetroPie branch as of today.

                                Thanks, that's great. I'll get my themes updated then.

                                SNES mini/Nes mini/Famicom mini theme developer.

                                If you'd like to support my work you can donate here: Donate

                                S 1 Reply Last reply Reply Quote 1
                                • S
                                  Syhles @ruckage
                                  last edited by

                                  @ruckage
                                  Just curious but are you going to use the selector image function on your theme?

                                  ruckageR 1 Reply Last reply Reply Quote 0
                                  • ruckageR
                                    ruckage @Syhles
                                    last edited by

                                    @Syhles
                                    Most likely, probably something simple though like very slightly rounded corners (corner pixels removed) to match the rest of the layout. I may do a little bit more on certain systems that would suit it. I'll be experimenting to see what would look good.

                                    SNES mini/Nes mini/Famicom mini theme developer.

                                    If you'd like to support my work you can donate here: Donate

                                    S 1 Reply Last reply Reply Quote 1
                                    • S
                                      Syhles @ruckage
                                      last edited by

                                      @ruckage
                                      Sounds reasonable, I was just thinking that you could do all kinds of different things for selector image using pixel art.

                                      ruckageR 1 Reply Last reply Reply Quote 0
                                      • ruckageR
                                        ruckage @Syhles
                                        last edited by

                                        @Syhles said in Long standing ES bugs:

                                        @ruckage
                                        Sounds reasonable, I was just thinking that you could do all kinds of different things for selector image using pixel art.

                                        Definately. I don't want over do it but certain systems would benefit from more elaborate selector bars.

                                        SNES mini/Nes mini/Famicom mini theme developer.

                                        If you'd like to support my work you can donate here: Donate

                                        S 1 Reply Last reply Reply Quote 1
                                        • S
                                          Syhles @ruckage
                                          last edited by

                                          @ruckage
                                          I understand sometimes there can be too much on screen, though I feel like arcade, virtual boy, and game boy could end up with some interesting selectors.

                                          1 Reply Last reply Reply Quote 0
                                          • ruckageR
                                            ruckage @jdrassa
                                            last edited by

                                            @jdrassa
                                            Hi. Would it be possible to get an up to date windows build with the video fix as it helps with testing. Thanks.

                                            SNES mini/Nes mini/Famicom mini theme developer.

                                            If you'd like to support my work you can donate here: Donate

                                            J 1 Reply Last reply Reply Quote 1
                                            • First post
                                              Last post

                                            Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                            Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.