ES devs and testers, this tool is for you!

meleu

Hey testers! There was a bug in the script when you were trying to set the official RetroPie ES as the default one (the C option in the main menu). I've just fixed it. So, please, update your scripts.

If you used that feature to set the official ES as the default one, probably your ~/RetroPie-Setup/scriptmodules/supplementary/emulationstation.sh is non-existent/invalid. Here is how to fix it:

cd ~/RetroPie-Setup/scriptmodules/supplementary
rm emulationstation.sh
wget https://raw.githubusercontent.com/RetroPie/RetroPie-Setup/master/scriptmodules/supplementary/emulationstation.sh

Thanks and sorry for the inconvenience.

meleu

ANOTHER UPDATE

A small improvement to prevent problems as pointed by @TMNTturtlguy here.

Current version: delta

lilbud

@meleu said in ES devs and testers, this tool is for you!:

Current version: delta

Was this an intentional, or unintentional Power Rangers reference?

meleu

@lilbud it's an intentional reference to the Greek alphabet :-)

Hex

@meleu I have a few more ideas. Should I post them here?

meleu

@Hex PLEASE DO IT! :-)

Your tips are always very useful! You can also submit PRs if you prefer to write code than sentences and paragraphs (no need to do exhaustive tests, just submit the code and I test it before merge).

Hex

@meleu

A few changes that I have finished :

Replaced gitcloneorpull/gitpullorclone for my tweaks.
Added launch menu
Removed default Install menu (will bring back (only on Pi) after testing)
Changed all spaces to tabs
Added dynamic processors for make (Faster builds on multicore processors)
Added warning to Launch menu if Launching without building
moved compilations to build directory.
started removing dependence on Retropie scripts. (in works)
Only use rpSwap if running on Pi 1/Zero
Updated version to Zeta, skipping Epsilon (merging build) as you were going to incorporate my git tweaks and would have released it as Epsilon build.

Will these do? I might add some more. User requests are welcome

meleu

@Hex Those are great additions! Will you submit a PR?

pjft

I think rpswap is also used in other Pi versions in RetroPie setup. Surely it's not mandatory but unless there's a clear drawback do we need to remove it?

Hex

@pjft rpSwap does nothing if Ram > what is asked (512). Pi 1 and Zero are the only two that need rpSwap.

Hex

@meleu I would submit it tomorrow morning. Its late here. Should I submit PR with version increment? Zeta or Epsilon?

meleu

@Hex Epsilon, I didn't have time to implement the git tweaks yet. Planned to add it tomorrow.

I'm now in the middle of a tweaking Carbon theme based on what we were talking about in the @TMNTturtlguy 's post :)

meleu

@Hex regarding to rpSwap, I think RetroPie-Setup does a good job about deciding if it really needs more swap: https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/helpers.sh#L285-L313

But as we want to remove the dependence on those scripts, you can go ahead with your code.

I promess I'll organize the script and let it more readable, modularized a easier to improve. ;-)

Hex

@meleu The goal of removing dependence on Retropie scripts is so that you can run it on Linux systems which neither needs those scipts nor the installation menu

Hex

Can someone running Retropie on Pi 1/Zero let me know the output of this command uname -a

meleu

@Hex oh, I'm not in the same city as my raspi1...

Maybe @obsidianspider or @edmaul69 can help with this...

meleu

@Hex said in ES devs and testers, this tool is for you!:

@meleu The goal of removing dependence on Retropie scripts is so that you can run it on Linux systems which neither needs those scipts nor the installation menu

ASFAIK the only thing needed to change the default emulationstation is one single line on /usr/bin/emulationstation. The line that looks like this:

"/opt/retropie/supplementary/es_pjft_retropie-screensaver-merge/emulationstation.sh" "$@"

We can remove the dependency very easily a simple sed trick can deal with it. :-)

I reused the code to finish a usable version of the script as soon as possible and don't lose the "timing" in the @Zigurana 's thread. :-)

meleu

@Hex said in Help testing: Random Video Screensaver on Main Branch:

To combine all of theme in one sentence you can have the command as such :
git pull || git merge --abort && git pull -X theirs

The || ensures that git merge --abort && git pull -X theirs only runs if git pull fails

Oops. It didn't work as expected. Look what I mean:

$ echo bla || echo ble && echo bli
bla
bli

Got it?

But there's no problem, I adjusted it here:

if ! git pull; then
    git merge --abort && git pull -X theirs
fi

I'm making the git tweaks now (and creating my own version of gitPullOrClone), but you can still name your version as epsilon. :-)

edit: git tweaks done.

edit 2: I borrowed rpSwap code from RetroPie-Setup's helpers.sh, and now helpers.sh is not a dependency anymore.

lilbud

@meleu Damnit, I thought you were making a Power Rangers: S.P.D, Space Patrol Delta.

Hex

@meleu said in ES devs and testers, this tool is for you!:

@Hex said in Help testing: Random Video Screensaver on Main Branch:

To combine all of theme in one sentence you can have the command as such :
git pull || git merge --abort && git pull -X theirs

The || ensures that git merge --abort && git pull -X theirs only runs if git pull fails

Oops. It didn't work as expected. Look what I mean:
$ echo bla || echo ble && echo bli
bla
bli
Got it?

But there's no problem, I adjusted it here:
if ! git pull; then
    git merge --abort && git pull -X theirs
fi
I'm making the git tweaks now (and creating my own version of gitPullOrClone), but you can still name your version as epsilon. :-)

edit: git tweaks done.

edit 2: I borrowed rpSwap code from RetroPie-Setup's helpers.sh, and now helpers.sh is not a dependency anymore.

it should be echo haha || ( echo hehe && echo hoho )

I forgot those brackets.