New Comic Book Theme!

Zigurana

@pjft :
Hey man, sorry for the absolute radio-silence these last weeks. Work and family life has been eating away much of my time. :-/

I managed to eek out some time yesterday to continue with the themeing refactoring, which is progressing well! Lots of loose ends to tie up, but the basic functionality to create a basic or detailed GamesListView is mostly in place.

I did not yet continue with the favorites PR, as I anticipated that a lot of that work would become obsolete or irrelevant as a result of the themeing changes.

If you (or @sokiee) want to go ahead and pick up introducing the metadata type, then go ahead. You can pick the existing PR, or look at the kid-mode branch for inspiration.

I don't think it is much use to implement the visualization of favorites in gamelistviews at this point, as some of that is likely to change in the not too far future.

pjft

@Zigurana Hi, good morning!

Of course, please. No need to apologize whatsoever - family life, and work, are effectively our main responsibilities :) Glad to hear you're doing well. The theme refactoring is a massive undertaking, though - best of luck with that, and do let us know if you need any testing or motivation :)

I think that you're right, a lot of that work will become obsolete with your current changes. I'm really just scoping down the minimum-viable-product portion of it to add to ES right now - i.e. the fundamentals that won't change.

I was mostly thinking about:

Having the "favorites" metadata value;
Showing it in the metadata editor.
Filtering (since it already exists)
Optional: Adding the toggle button (unsure, if there's no visualization at this stage, though - likely not).

So yeah. I might ping @sokiee 's PR and ask if we can narrow it down to the scope we agree won't change for now.

If you would have had any particular commit in your branch where it's just these, I'd gladly take them, squash them, and tidy them up for the main branch. We'll see how things go!

Thanks.

@TMNTturtlguy wow. The more I see all these custom systems, the more I think there should be a sustainable way to manage these. I don't want to force people to have to do all the custom runcommand, es_systems and stuff to use these. Let me think about that - after I finish "all" and "last played"... (here's me setting myself up for yet more work).

meleu

@TMNTturtlguy Wow man! I think you deserve a couplet:

You've been amusing us with your art
And after the last update you have a place in my heart

[Side note: I discovered a pleasure in making couplets after meeting Isadora Quagmire :) ]

CodeDrawer

@meleu Wait, you read a series of unfortunate events? Deadly!

meleu

@CodeDrawer said in New Comic Book Theme!:

Wait, you read a series of unfortunate events?

Like aunt Josephine, I love grammar too. Therefore I couldn't avoid to note the way you wrote that question. I think you should write "did you read a series of unfortunate events?". :-)

To be honest I stopped (got distracted by real life issues) when I was reading The Slippery Slope. I want to finish it soon. Did you watch to the Netflix adaptation? I'm enjoying it.

Ooops! I think we're going off-topic... Sorry.

CodeDrawer

@meleu I never read the netflix version, just the horrible movie.

TMNTturtlguy

A Series of unfortunate .wav files!
......Look away, look away
While I haven't seen the movie, I have watched the Netflix series and it was entertaining.

Back to the topic, unfortunately a few of the launch sounds i tried to implement are not working as expected. Not sure the issue yet, but because I like to keep things tidy and neat I have updated both themes to remove them from the current code. If you have already updated there is no real reason to update again, you may see a failure to launch message for the .wav file. It will not affect your setup at all. If you prefer, update and it will remove the issue.

Thanks

pjft

@TMNTturtlguy interesting.

Would it be file encoding/bitrate related? Does EmulationStation log anything when you try to play them?

Anyway, the theme looks gorgeous!

TMNTturtlguy

@pjft Thank you! I am not sure, one issue is a file type issue I overlooked and never tested. I thought the TMNT file was a .wav and it was a .mp3. i just threw it in the folder last second and forgot to test it. I don't think .mp3 is a valid format. The other 2 are valid .wav files so I would have to look into it as you suggest. I don't have time at the moment, so for now I have just removed them. When I get more time I will take a deeper look. Thanks

meleu

@TMNTturtlguy hey bro, I noticed you've made some custom systems with a space char in the name. They are:

all games
last played
mega man

Not sure if @pjft needs all games and last played with space in the name for his ES development, but I think mega man could be named megaman.

This is not a really big problem, but things are used to work a little better without spaces. :-)

pjft

@meleu I don't, actually - originally I had thought of "all", "recent" (for last played, or "lastplayed") but it's an easy change on my end.

Though, for consistency - and potential compatibility - I'd be fully supportive of moving to a name without spaces. As you say, "things are used to work a little better without spaces", as you never know what bugs might come up from using unescaped paths with spaces :)

TMNTturtlguy

@pjft @meleu I will make the adjustment and update shortly This is an easy change. i will use the following:

megaman
allgames
~~last~~Edit per @pjft I will use lastplayed

The reason i want to use allgames is because the folder all already exists in the configs folders.

pjft

@TMNTturtlguy that's a good call!

In fact, if you'd want to preface them by something - say, auto-allgames, auto-favorites, auto-lastplayed I would not oppose as it would perhaps differentiate itself from any manually created system.

Your call.

TMNTturtlguy

@pjft @melu and All

I have updated both themes to remove spaces from the system names and to align with @pjft work in potential updates to ES. Please update from the ES Themes menu. Thank you

meleu

@TMNTturtlguy Hey dude! I love it!!!

0_1497482286837_Captura de tela de 2017-06-14 20-16-10.png

TMNTturtlguy

@meleu That is AWESOME!

TMNTturtlguy

Ok, Now that @meleu has had a chance to release is awesome script for getting the roms to work with the custom systems in the theme, i want to share with you an alternate method of doing this. This is the method that initially inspired @meleu to create his script. I would suggest that his script is better for most cases than my method. Here is a link to his newest script: Create a custom ES system able to launch games for many systems however my method also has valid uses.

Create multiple emulator systems:

This method of creating custom systems like TMNT, Mario, Mega Man, and Fighting allows you to create systems with games from any system you want in one location. You can group all of your TMNT games into one list. This method requires the creation of a new system that functions exactly the same as the current Arcade folder works. The Arcade system allows you to place all the Mame, FBA and Neo Geo roms into one place and then select the appropriate emulator to launch them. This is the same concept. If you use this concept you will either be copying roms into another folder, which means duplication of roms, or you want to create a group of systems like TMNT, Mega Man, Mario, Batman and do not wish to have the standard, NES, Sega, Arcade systems. I am using this method on a bartop arcade that will only have TMNT games. No other systems will be present. If you wish to use this concept, but don’t want to have copies of games, or to set the emulator yourself, please see the link to @meleu thread and his scripts to create links to games. It is definitely the best way to proceed if you plan to keep the standard system folders and have the games located into the special systems.

go to /home/pi/RetroPie/roms and create a new folder named: "TMNT" (note use the same steps in this process and change TMNT to whatever you want.
Add roms from any system you would like to this folder, that is right ANY rom, any system!
Go to your favorite theme and choose a system to copy, copy the folder and rename it "TMNT" this will create a duplicate of that system including logos so you will need to edit that if you can. This is the hardest part of the process. If you use my ComicBook Theme I have provided the TMNT system so there is no work to be done!
Download the needed files for the following steps here: mega.nz link
Create a TMNT folder for our conifgs and retroarch files:
a) go to /opt/retropie/configs create a new folder named "TMNT"
b) copy the files in the folder "copy these to cofigs folder" from the download link into the new TMNT folder.
c) Open retroarch.cfg modify line 3 - delete "arcade" and replace with "favorites" it should look like this:
input_remapping_directory = "/opt/retropie/configs/TMNT/"
d) Open emulators.cfg within the favorites folder. This is where we need to add in the emulators we want to be able to run and launch in our new Favorites System. In the folder in the download i have added lr-fceumm, lr-nestopia (for NES) and lr-genesis-plus-gx and lr-picodrive (for genesis). To add other systems, simply open any system folder within /opt/retropie/configs/ and open the emulator.cfg file. Copy the entire system line for each emulator and paste into the file in your favorites folder. Be sure not to copy the default = line as we only can have one default set in the folder.
Edit your es_systems.cfg file. /etc/emulationstation/ ALWAYS make a backup of the original and I suggest you copy the es_systems.cfg file to the following location /home/pi/.emulationstation edit the es_systems.cfg in this location. Copy and paste the system I have created for you in the es_systems.cfg in the folder. Change the names everything you desire, leave the <extension> line as is for every system you create. Example below:
```
<system>
     <name>TMNT</name>
     <fullname>TMNT</fullname>
     <path>/home/pi/RetroPie/roms/TMNT</path>
     <extension>.fba .zip .FBA .ZIP .smd .nes</extension>
     <command>/opt/retropie/supplementary/runcommand/runcommand.sh 0 _SYS_ TMN %ROM%</command>
     <platform>arcade</platform>
     <theme>TMNT</theme>
</system>
```
Now for the boring explanation of what you see above and how it works:
a) <Name> name of the system folder your roms are in.
b) <fullname> is the full name of the system.
c) the <path> is the path to the roms folder we created in step 1 above.
d) the <extension> are all of the file types of the roms you want to have in your favorites folder. In the above I have provided all the extensions for the main systems available on retropie.
c) the <command> is telling the startup to use the favorites folder we just created in step 4 to launch the rom using the runcommand.
d) <platform>you can put just about anything in there, some things might use this, i think the naming for the new screensaver build might use this line? Stick with Arcade to avoid error messages when shutting down, however I don’t believe the message means anything.
e) <theme> this directs the sytem to display the "TMNT" folder from within your theme. We created this in step 3.

That is it. Now restart your system. You should see the TMNT system in the theme with a list of games you put in the roms folder. The gamelist and metadata are not created for you, so you can rescrape, or recreate a new gamelist for each system. On launch of the games, you will need to select the emulator you want to use. This is similar to using the Arcade folder and launching FB Alpha and Neo Geo roms where you will need to select the emulator. If bios are needed, you will also need to place those in the appropriate location.

serotonin

Yey this is released this is amazing !!! TMNT do you speak with the ES guys? Any chance all these ES updates can come to the PC version too? I have a pi now and a pc, it would be sweet if they worked and looked the same.

meleu

@serotonin said in New Comic Book Theme!:

I have a pi now and a pc, it would be sweet if they worked and looked the same.

I have the same and they look identical. Not sure what you're talking about...

serotonin

I didn't think the PC version of emulator station had been updated in a long time ?? I thought they were just updating the pi version. How do you update es PC version ? Do I have to download a full new version and install again or is there a update feature in the app?