Please Test: Adding support for "All", "Favorites" and "Last Played" systems

cyperghost

@pjft Yes exactly a combination of the power savings @hex and your latest efforts in "favorite" support. It isn't necessary for a quick release but imho the energy saving feature should be installed by default so that user in the case of building portables can profit from longer battery live (I focus on Pi0 builds). The CPU load from different branches is listed here - maybe you missed it :D

pjft

@cyperghost Thanks for clarifying.

As I said, then, that's completely out of scope for these changes. That's something that will make it into the main branch when @Hex feels it's ready. It'd be a waste of anyone else's time to re-invent the wheel as @Hex is actively developing it, and if he's already looking into that, he has a lot more insight, knowledge and skills to make it happen the right way than others would, as few have ever devoted a moment to think about that problem.

Those developments are in good hands.

EDIT: It's not that I missed those posts, it's just that I personally don't have a pressing need to look into that problem, given that others are already doing so. Don't take this wrong - there are just so many things that we all want to look into, and only a finite amount of time in our weeks to devote to it.

Also, from the results shown in that thread, I don't see any particular downgrade in performance between 2.1.x and 2.3.x which at least gives me reassurance that nothing has been significantly broken or made worse in recent developments. If there's no regression, then it's fair game if someone wants to improve it - but it'll take as much importance or priority as any other new development.

All in all, I'm very thankful that @Hex is looking into that. Suggesting others to pick up his work and merge it so it is made "faster" is somewhat disrespectful of the time and effort he's putting into it.

The best thing that you and the community can do to help speed any of that work up - or any other RetroPie-related development, as a matter of fact - is help testing things. @Hex, @zigurana, @jdrassa and others would be very much thankful for that, as everybody wants to make sure that their work will not cause any problems.

I'll also include here @fluffypillow and @phulshof who are doing a tremendous job on their own respective frontends that will hopefully one day be fully available for RetroPie users, as well as everyone who is producing tools, scripts, overlays, etc. I'm missing a lot more people here as well, namely the project maintainers, but I don't want to turn this into a spam-fest of mentions.

Hope this sets the right expectation. Sorry for the long post-script, and thanks for the encouragement and support.

cyperghost

@pjft Is it okay for you if I upload the generated binary to github? Or am I breaking laws or a codex by doing this?

Thank you again for providing us with your mod - You made a good job and I appreciate this.

Hex

@cyperghost @pjft

Ok so those of you who dont know how awesome git is when it does what you want, well here is how you can merge two or more features in different repositories.

Follow these instructions :
Download my script https://github.com/hex007/es-dev/blob/master/es-tests.sh

create and paste / append to es-repos.txt file

https://github.com/pjft/EmulationStation RetroPie-Virtual-Systems-PR

Then create another file es-patches.txt, and paste in it

https://github.com/hex007/EmulationStation feature-powersaver d2aa4861704e4d93659246c13ecc982a6fd18314 Hex's powersaver patch

Run my script and where it asks if you want to apply patches go for yes and select Hex's powersaver patch

And continue with the build.

OR For those comfortable with git only:

git clone --recurse-submodules https://github.com/pjft/EmulationStation -b RetroPie-Virtual-Systems-PR pjft-vs

mkdir pjft-vs/build && cd pjft-vs/build

git  fetch https://github.com/hex007/EmulationStation feature-powersaver
git cherry-pick d2aa4861704e4d93659246c13ecc982a6fd18314

cyperghost

This post is deleted!

cyperghost

@Hex Your way is incredible fast. It takes only 5 minutes to compile. I think it's the make cleanup before. I'm still testing both branches (your and pjft`s)
Thank you :) I will write a small report for favorites usage and CPU usage.

pjft

@cyperghost by all means, feel free to share the binary. I can do it tomorrow as well. My binary was compiled on a pi 3 though.

Sorry for the potentially incorrect instructions, I wrote them from memory.

cyperghost

@pjft de nada

TMNTturtlguy

wow, I travel for work for 2 weeks and the world has turned upside-down! This stuff looks incredible, but I just got a setup that is working wonderfully......I guess i better buy another pi and start a fresh build!

cyperghost

@TMNTturtlguy
There is no need for a second PI... The make process runs wonderfull and you can exchange the compiled binary with the binary in /opt/retropie/supplementary/emulationstation/
Don't worry you won't mess up the system :)

I can provide binaries:
https://github.com/crcerror/emulationstation-binary-archive

Hex

Actually this is a great idea to provide compiled binaries on github with proper versions and features.

cyperghost

@Hex That's a bit hard to handle. I think main feature, author and ES version should be enough.
But everybody is free to fork and add the archive :)
I hope the archive will make development faster and more accurate because more users can simply download and try out versions.

In the repo...

If there is no @ in the name then it's a main branch release within RetroPie
authors of the branch are names by adding @name to the file
main features are named within file name

for ex. emulationstation2.1.5RP means main realase of ES from RetroPie in ES version 2.1.5
for ex. emulationstation2.2.4RP PS @hex PowerSavingsmeans ES branch from @hex with PowerSaving feature with ES version 2.2.4

Hex

@cyperghost said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

@Hex That's a bit hard to handle. I think main feature, author and ES version should be enough.
But everybody is free to fork and add the archive :)

I mean for a tester to do and not the developer. The dev cannot keep on sharing the binaries as they are much busy compiling

cyperghost

Added @pjft file to binary archive RPI2/3 only

https://github.com/crcerror/emulationstation-binary-archive

How to:

Copy file from repro and rename it back to emulationstation
Rename file emulationstation in /opt/retropie/supplementary/emulationstation/ maybe emulationstation.org >> That's your backup!
Copy repro file to /opt/retropie/supplementary/emulationstation/
User rights 755 root:root

@Hex I wans't able to merge your Powersaver Patch together with @pjft
I added

https://github.com/hex007/EmulationStation feature-powersaver d2aa4861704e4d93659246c13ecc982a6fd18314 Hex's powersaver patch

to es-patches.txt but I wasn't able to select this patch. Just the Repro was available.

meleu

@Hex hey bro, do you recommend some cross compiling guide? Compiling ES on my raspi1 is very time consuming and on my laptop take 2 or 3 minutes. I compiled the very first version of the @pjft 's PR and it took almos 4 hours on my raspi1. Now I don't have the guts to compile the new changes we are getting (I would like to test/provide feedback about two PRs you submitted too).

cyperghost

@meleu Maybe I uploaded the file you need already.
https://github.com/crcerror/emulationstation-binary-archive

--

Sorry @pjft your branch work wonderfull. I can even favourize the favourites of Little Favourite Launcher and it works flawless ;) Thank you very much I'm looking forward that the next release will be a burner :)

One suggestion. The "Added xxxxx to favourite" beacon is in the middle of the upper screen. May you can set it to right down corner?

Little Bug if you add a Favorite within the auto-favorite then ES will give error message segmentation faultand the binary is killed

Hex

@meleu Thats the beauty i work with. I write all my code on my linux system only. I test it on rasp pi only when i reach a workable copy. skipping make clean should reduce the compile time. The thing is the higheryour changes are in the hierarchy the more files are compiled again. If you have a Pi3 i would suggest compiling on that. It is fast on pi 3. Use 2 or 3 cores only and not all 4 else you will run out of ram.

I do not have a cross compile setup. I never have used one.

Hex

@cyperghost Did you atleast see the patches menu?

 es-dev.sh (version: zeta.2) - manage EmulationStation mods on your RetroPie
 ────────────────────────────────────────────────────────────────────────────

┌─────────────────────────────────────────────────────────────────────────┐
│ Would you like to apply any patches from es-patches.txt or remove all   │  
│ patches applied to this repository?                                     │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
├─────────────────────────────────────────────────────────────────────────┤  
│                       < Yes >            < No  >                        │  
└─────────────────────────────────────────────────────────────────────────┘

cyperghost

No... This windows I had never seen.

I tried manually via the github commands you posted... But then there was an error message about the cherry pick, that I can't commit the file.

git clone --recurse-submodules https://github.com/pjft/EmulationStation -b RetroPie-Virtual-Systems-PR pjft-vs

mkdir pjft-vs/build && cd pjft-vs/build

git  fetch https://github.com/hex007/EmulationStation feature-powersaver
git cherry-pick d2aa4861704e4d93659246c13ecc982a6fd18314

git clone works and downloads pjfts branch
of course works
git fetch also works
did not work

Hex

@cyperghost please post the error that you get.