Please Test: Creating Custom Collections

TMNTturtlguy

@ectoone @pjft I also have this script on my builds. Unfortunately as my summer story continues, I am traveling this week, but i hope to have a few hours this weekend to test this out, i know that is a long ways off, but that is the only chance I will have to help. If things are not resolved by then, i will post my results.

EctoOne

@tmntturtlguy Don't worry. Sooner or later I will probably have to update ES and see what happens. But TBH, I hate updates when there's nothing important to me and I have a working system that I like. That's why I have to bother with Android Studio now, I had to update my Tablet from Kitkat to Marshmallow because the support of certain Apps was dropped. :(

pjft

@cyperghost said in Please Test: Creating Custom Collections:

Small small bug
There is already the note! Your system does not support the auto-systems and the custom collections!

Yeah, don't try to manually rename files for the custom systems. That's not really expected, even though it didn't break you might find weird behaviors when navigating :)

Can you elaborate what the small small bug is? What do you mean that the system does not support the auto systems and custom collections? :)

@cyperghost and @HurricaneFan - tell me: would the bug effectively only manifest itself when exiting the gamelist view back to the system view? Meaning you'd be in a collection and then when exiting back to the system carousel it would explicitly navigate to a different system, is that it? Give me more information so I can tackle it for good :)

Thanks!

pjft

Ok, so a new update.

Here's the binary.

What changed:

Generates custom metadata for folders under "My Collections" (thanks for commenting on how miserable the experience looked, @HurricaneFan, as that kind of forced me to think about it a bit more!)
Fix system view navigation (I think - please check, @cyperghost and @HurricaneFan . I had narrowed down a misbehavior when using the "My Collections" system and exiting the gameview, but maybe I fixed a different thing to what you were experiencing).
Filters in "My Collections" work
Few other tweaks and fixes

Thanks all!

HurricaneFan

@pjft I'll get this tested today. Thanks for all the hard work you've put into this and other improvements for ES.

EDIT:
I copied the new binary over but I'm not seeing the custom metadata and the snes bug is still there.

Was your link pointing to the latest and greatest binary?

HurricaneFan

@pjft ES is showing version V2.4.1RP, is that the latest build?

pjft

@hurricanefan The version will be the same, but actually I did not update the instructions I gave you in case you were following them :)

mkdir /home/pi/tmp-es
cd /home/pi/tmp-es
rm emulationstation
wget https://github.com/pjft/EmulationStation/releases/download/0.3/emulationstation
chmod +x emulationstation
cd /opt/retropie/supplementary/emulationstation
sudo cp /home/pi/tmp-es/emulationstation /opt/retropie/supplementary/emulationstation

The file should have 5554720 bytes.

HurricaneFan

@pjft Thanks, I definitely had a different sized binary. Super weird. It's updated now and I'll test when I get time later today.

cyperghost

@pjft No bug still is there!
But it's even worse!

No I see one entry for custom collections I named it testsystem
If I enter custom-collections via carousel then I can activate testsystems and see my added roms there >> normal work

The Super NES bug is ... I see also testsystem but if I press a then I start the first game from Super NES Rom (2020 Super Baseball here) --- really weird.

How to produce
Got to Game Collection Settings:
Automatic Game Collections 3 selected
Custom Game Collections 1 selected testsystems
Group unthemed custom collections ON
Sort custom system and collections ON

Restart ES.
Now the last system in list (Super NES in my case) followed by auto-allgames auto-favoritesand auto-lastplayed can be acessed as custom-collections and but will launch ROM of system!

Sort custom system and collections OFF
No problem! Everything works!

pjft

@cyperghost can you send me a video from a phone or something?

cyperghost

@pjft
I think I can ... what is curious!
If I'm in the SNES/Custom-Collection thing move up I can select different games!
Even if there is only the system testsystemsis displayed.

X for random also works! So it's just a small issue I think! Wait one hour please, okay?

HurricaneFan

@cyperghost, @pjft I see the snes bug too. Super weird. If I am in gamelist view and go from Sega CD to SNES which is next system in my list, it triggers the Custom Collections view but I hear the video playing for the snes games, even though I don't see any of the details of snes game.

pjft

@hurricanefan @cyperghost got it. No need for video now.

This was not the bug I had ran into earlier :)

Thanks.

pjft

@cyperghost A question, though: what do you mean "it's even worse"?

cyperghost

@pjft Well in version 0.2 the SNESbug was 100% triggered to custom-collections so I could navigate through the collection.

In version 0.3 I can see the custom-collections only but I can select any SNES Rom blindly. Or press X for random selection :)

Just for fun!
New feature: This is real random you don't see the game you selected until it's loaded

HurricaneFan

@cyperghost @pjft I was able to blindly select an snes game in 0.2 and 0.3. That wasn't new to me.

pjft

@HurricaneFan Correct: 0.2 and 0.3 were when I added the "My Collections" bit.

@cyperghost and @HurricaneFan - ~~I think I've fixed it for good. Updated the same binary (my repository isn't updated yet, so don't try to compile).~~

~~There may be a few extra log messages on the terminal, which I used to troubleshoot this, but I'll remove them tomorrow when I tidy up the build, if you confirm it's sorted.~~

Nevermind. I fixed it partially, but at least now I know what's happening.

Thank you both!

Let me know if there's any other issue for the time being, and @HurricaneFan let me know if the Custom Collections metadata works for you.

I'll fix it tomorrow and report.

cyperghost

@HurricaneFan My investigation wasn't so deep :)
@pjft Sort If I use custom system and collections OFF
then the bug is gone - even on restart :)

I think it isn't a great bug.

Annother little misbehaviour:
ES tells me that my theme is still not ready for the 3 auto-system and the 1 custom-collections. I think that isn't as intended to work. Because I use IO theme and it shows all 4 systems as well.

@pjft My deepest respect for your hard work!

pjft

@cyperghost Yeah, it only happens if you sort things. I'll fix it tomorrow.

I also ran into the false warning, need to check why that happened.

Thanks both!

cyperghost

@pjft Thanks mate.
Do some testing with some new ICs now :)
I'm always ready to test your builds