Gamepad buttons stop working in retropie-setup 4.2.12

psyke83

Can someone with the controller issue please test this modified script?

Enter the retropie-setup folder:

cd RetroPie-Setup

Undo any changes if you followed my prior steps to revert the commit:

git reset --hard origin/master

Fetch and apply the patch:

wget https://gist.githubusercontent.com/psyke83/9a0b31bcd8f43d16d081462363741f35/raw/4ce063642e9088c3faa541d965d439d50c951101/joy2key.patch
patch -p1 <joy2key.patch

If everything goes as expected, you should see:

patching file scriptmodules/supplementary/runcommand/joy2key.py

If there are no further messages/errors, then the patch was applied and is ready to test.

Slightly OT: guys & gals, try not to complain too much. The Pi itself is supposed to be a hobbyist board to encourage people to learn Linux & programming. That may not be your intended purpose, but keep an open mind. If you don't want to go near a terminal, leave it to someone else to test & and wait for the inevitable fix to be merged. The problem was my fault, but I don't have a second pad available so it's difficult for me to reproduce the issue.

Darksavior

@psyke83 I'm using a backup I made last month and with just updating the script to 4.2.12 to introduce the bug, I ran the patcher and did nothing.

psyke83

@darksavior You mean it didn't fix the problem?

Once the patch is applied you still need to enter the retropie-setup menu yourself.

Darksavior

@psyke83 Yea, that's what I meant. The patcher did do the patching, but it did not fix the problem.

psyke83

Please try the second patch:

cd RetroPie-Setup
git reset --hard origin/master
wget -N https://gist.githubusercontent.com/psyke83/9a0b31bcd8f43d16d081462363741f35/raw/89fae3f4a7a6309fd7cc5863ed62f245f84c729f/joy2key.patch
patch -p1 <joy2key.patch

Darksavior

@psyke83 That works. Many thanks.
I also retested it again from my old backup. I update script to 4.2.12, bug introduced, exit retropie-setup, added your patch, re-enter retropie-setup and controls work again.

psyke83

TY. I've submitted the patch via PR #2059.

Keep using the patch until the PR has been accepted & merged. When it's merged, you'll need to do a hard reset to clear the local changes or else the script update will fail.

cd RetroPie-Setup
git reset --hard origin/master

Darksavior

@psyke83 bit offtopic, but I want to try your gamecon fix if you can provide the instructions. I've been stuck on 4.4 kernel because of that.

MrPotato

Had signed off last night so just seeing the updates.
I'm back in reset normal mode -- I think I'll plan to wait for merge and verify everything comes through then. I can live with the nuances until then without much issue, and it will give another datapoint just in case.
Thanks, psyke83!

theWinterDojer

@mrpotato Should I wait to update anything until the patch is accepted? I have iBuffalo controllers as well and I'm guessing whatever happened will break them by updating?

psyke83

@darksavior said in Gamepad buttons stop working in retropie-setup 4.2.12:

@psyke83 bit offtopic, but I want to try your gamecon fix if you can provide the instructions. I've been stuck on 4.4 kernel because of that.

See this topic: https://retropie.org.uk/forum/topic/11925/gamecon_gpio_rpi-1-2-1-kernel-4-9-build-fix

Please be sure to give feedback in that topic, and keep in mind that I could only verify that the module builds, but not that it actually works.

@thewinterdojer said in Gamepad buttons stop working in retropie-setup 4.2.12:

@mrpotato Should I wait to update anything until the patch is accepted? I have iBuffalo controllers as well and I'm guessing whatever happened will break them by updating?

The patch is already merged, so feel free to update right now (making sure to do the hard reset beforehand, if necessary, as I mentioned in my prior post).

theWinterDojer

@psyke83 Okay thanks, will performing the hard reset change any other settings or configs I should worry about?

psyke83

@thewinterdojer said in Gamepad buttons stop working in retropie-setup 4.2.12:

@psyke83 Okay thanks, will performing the hard reset change any other settings or configs I should worry about?

I don't know what you've done. Generally speaking, RetroPie-Setup should always be free from local changes in order for the script to successfully update itself. If you're not manually changing stuff, then it's likely that you can reset it without worrying.

You only need to do it for certain if you tried those "git revert" commands I suggested in earlier posts.

MrPotato

@psyke83 said in Gamepad buttons stop working in retropie-setup 4.2.12:

The patch is already merged

Sweet. I'll try to give it a whirl a little later today.

MrPotato

Works like a champ!

edmaul69

@psyke83 i had it working but i get that same error trying to update retropie-setup now. And if i try to do the revert as both pi and root user it gives me that same error. @meleu had me remove and reinstall joy2key and sadly that no longer works now either.

edmaul69

@psyke83 nevermind. running "git reset --hard origin/master" fixed it. thank you

BuZz

@edmaul69 if you ran it as root you may have now messed up your RetroPie-Setup permissions. You should chown the folder recursively to pi user to avoid issues.

edmaul69

@buzz will do. I was able to update retropie-setup and core programs and it fixed the joy2key when i updated retropie-setup, so it appears to be ok. But i will definitely do it right now to be safe. Thank you.

EvilDindon

Ok so the bug is fixed in 4.12.13 ?