Please Test: Creating Custom Collections

cyperghost

@pjft I can agree to @HurricaneFan the SNES bug is gone.
Thank you so much for creating this into ES
This is a great step :)

pjft

@tmntturtlguy I hope the update doesn't break anything that you currently have set up, so at least that's that :)

HurricaneFan

@pjft I'm seeing a new bug. If you remove a game that was already in a collection, EmulationStation crashes with a Segmentation Fault. I have to do a hard reboot of the pi to get it working again.

pjft

@hurricanefan Hm.

Let me test that. That shouldn't be happening, but after testing more now, I see it happens to Collections under My Collections.

Let me look into that. Thanks.

You would probably be able to ssh into the Pi and reboot it from there when that happens though. Hopefully. :)

EDIT: Apologies. Rookie mistake after a small refactoring yesterday. Thanks for flagging that. Will update the binary shortly.

pjft

Thanks.

Updated the branch and the binary, so you can re-do the commands to get the latest version.

Fixed the crash you reported, as well as an instance whereby trying to select a random game in an empty collection would - as expected - not behave well :)

Thanks for testing!

HurricaneFan

@pjft Adding and removing works as expected now. Thanks!

On a side note, Can Custom Collections the system be sorted differently in the system view?

Right now, My setup shows Mega Drive, Custom Collections, Nintendo 64. What causes it to display between M and N?

pjft

@hurricanefan the actual name is "my collections", that's why. :)

HurricaneFan

@pjft Ohhhh, and the theme I'm using calls them Custom Collections. Gotcha.

TMNTturtlguy

@pjft Sorry to interject, but tying this into my earlier question about being able to modify the order of the systems......Since this is not in the es_systems.cfg how will this scenario work?

I have a custom es_system.cfg that i organize by game "brand" so i have the following order (not alphabetical)

Arcade
Capcom
NeoGeo
Atari 2600
Atari 7800
NES
SNES
N64
GB
GBC
GBA
NDS
Megadrive
Sega32x
SegaCD
Dreamcast
Gamegear
PSX
PSP
Turbografx
ZxSpectrum

Where would the my custom collections be inserted in this case?
Could we modify the name of the folder to zz my custom collections in order to have this be the last in the alphabetical order?

pjft

@hurricanefan what's the theme? This is very much in the beginning so we might ask the theme makers to change that - either one way or the other.

I agree it's not very consistent, my bad.

pjft

@tmntturtlguy there's two sorting orders. One will sort them all alphabetically with the systems. The other will keep all collections at the end, and won't change the order of the systems.

Edit: that's probably the one you want and the one I use.

HurricaneFan

@pjft I keep all my testing right now with the Art Book theme. I really like how clean that theme is and have been trying to get all my roms into it for testing.

cyperghost

@tmntturtlguy You could extend your es_systems.sh and copy your favourites around. You can also create a "Minimum" theme. You only add "My custom collections"

cyperghost

@pjft I catch still the little bug that the note announces

Your theme dies not support game collections.
Pleasae update your theme, or unsure that you use a theme that contains the folder:

I get the error if I press start > Game Collections and go back with B-button or via Back-menu.

pjft

@cyperghost what theme are you using, what options do you have set, what collections do you have enabled (actual names) and what folders does the theme have?

cyperghost

@pjft
I use IO theme but it also happened to MagazineMadness (and both got the items for all 4 systems)
I have all 3 auto systems enabeld (auto-favorites, auto-allgames, auto-lasplayed)
I have 2 custom collections (testsystem, Beat'em up)

Annother one:
The custom collections show "2 Games available" - I think you can change it via hardcoding to "% Collections available)

Folder are here
IO - https://github.com/mattrixk/es-theme-io
MagazineMadness - https://github.com/RetroHursty69/es-theme-magazinemadness

pjft

@cyperghost can you get me the exact names of the collections you're enabling (maybe from inside the es settings file), the folders in the themes you're using, and the options you have enabled? The reason for that is that the code logic for that warning contains pretty much mostly string comparisons between folder names, and something must be off but I just can't replicate it consistently here. Thank you.

I considered your suggestion on the collections caption, but that would be different to what ES currently does, as even if your system only has folders in the main root path, it still shows the number of games within its entire tree. This way it's showing how many games you have available inside there - and each sub collection has the number of games in the description.

cyperghost

<?xml version="1.0"?>
<bool name="BackgroundJoystickInput" value="false" />
<bool name="CaptionsCompatibility" value="true" />
<bool name="DrawFramerate" value="false" />
<bool name="EnableSounds" value="true" />
<bool name="MoveCarousel" value="true" />
<bool name="ParseGamelistOnly" value="false" />
<bool name="QuickSystemSelect" value="false" />
<bool name="SaveGamelistsOnExit" value="true" />
<bool name="ScrapeRatings" value="true" />
<bool name="ScreenSaverControls" value="true" />
<bool name="ScreenSaverOmxPlayer" value="true" />
<bool name="ShowHelpPrompts" value="true" />
<bool name="SortAllSystems" value="true" />
<bool name="StretchVideoOnScreenSaver" value="false" />
<bool name="UseCustomCollectionsSystem" value="true" />
<bool name="VideoAudio" value="true" />
<bool name="VideoOmxPlayer" value="false" />
<int name="MaxVRAM" value="100" />
<int name="ScraperResizeHeight" value="0" />
<int name="ScraperResizeWidth" value="400" />
<int name="ScreenSaverTime" value="60000" />
<string name="AudioDevice" value="PCM" />
<string name="CollectionSystemsAuto" value="all,favorites,recent" />
<string name="CollectionSystemsCustom" value="Beat â€™em up,testsystem" />
<string name="GamelistViewStyle" value="automatic" />
<string name="OMXAudioDev" value="both" />
<string name="PowerSaverMode" value="default" />
<string name="Scraper" value="TheGamesDB" />
<string name="ScreenSaverBehavior" value="dim" />
<string name="ScreenSaverGameInfo" value="never" />
<string name="ThemeSet" value="io" />
<string name="TransitionStyle" value="instant" />

Got it... it's the unicode value of Beat 'em up!

EDIT:
I renamed to "custom-Beatem up.cfg"
That's it!

Do you may to resolve? I think it does not make sense to load an extra UTF-8 bibliothec into ES if it is not nessecary.

cyperghost

@pjft
I tried to recreate and now it works. Even the entry Beat 'em up stands clear in XML! Don't know why? Where there any changes in code between 0.2 and 0.3 that could make that happen?

pjft

@cyperghost I don't think there were any particular changes. But had you not updated to the latest binary in the recent days? I had done something to tackle that bug, so if you were still on an old binary, that might have been fixed since.

Tell me something, though: does the content of that collection get saved and reloaded correctly? What's the filename in ~/.emulationstation/collections ? And what exactly shows in the settings file now?

I am removing off characters from collection names, so that files can be created without problems (so, no commas, no *, no /, etc). But I may be saving that in the settings file, though. So that's something I need to fix.