Please Test: Adding support for "All", "Favorites" and "Last Played" systems

pjft

@cyperghost if @meleu could be paid for his code in RetroAchievements currency, he'd be all over that :p

saddys

@pjft, thanks for your job, very Thanks!

cyperghost

@pjft One line of code one CheevoPoint? We know @meleu is used to RegEx so one exchanged character one Cheevo?
I'm a bit unware of the currencie calculation

@mediamogul @TMNTturtlguy and @saddys (You will surly learn something of this also)
I updated the PID detector to v1.1
It's a great tool to detect PIDs of running emulators and the ES binary.

To escape ES it's also an easy achivment now. Just kill the binary ES without creating any file (no es-shutdown, no es-restart). That's it!

pjft

@saddys thanks! Hope you have fun with it.

@cyperghost i think that's kind of the current exchange rate, 1 line per cheevo point :)

BigMan1982

When I scroll through my "ALL GAMES" collection in ES it freezes the whole system and I have to pull the plug to reset the system. It always freezes around the game titles that start with "mu". I deleted a game and it still froze on the next one! I noticed that "mu" titles are the approximate center of my list, maybe that has something to do with it. I can scroll past the same bulk of games in my MAME system list with no issues. Any ideas? Anyone else see this?

I am running an overclocked (1.3) Pi3 B+, 5V 3A p/s, with Motion Blue V4, ES V2.4.1RP and Hursty Blue theme.

TMNTturtlguy

@bigman1982 how fast are you scrolling? Maybe ES is running out of memory if you are scrolling to fast? Have you tried to slow down when you get close the area of freezing and then click through the games? What is your VRAM set too?

ohmycommodore

@bigman1982 i've wondered whether All Games would be taxing when trying to navigate through it. there's not a huge use for that collection, in my case at least, compared to the others.

TMNTturtlguy

@ohmycommodore you can turn it off if you don't use it!

pjft

@bigman1982 there shouldn't be any problem, but I'd be keen on learning more. How many games do you have? How are you scrolling (down? R1?)? What video player are you using? VRAM setting? And if you said that you deleted a game and then it crashed on the next one, it seems it's on a very specific game or set of games. What happens if when you get there you jump over those games with R1? What's the last game it works in and the one that it fails? What happens when you scroll to those on their normal gamelists?

Let me know.

EvilDindon

Sorry if it has already been posted.

I came across some bugs regarding the Favorites menu.

Some items (games) disappear from the favorites, for some reason.

But hey, this may be my fault though, not sure, as I often delete some xml files after scraping systems the bad way.

Favorites are listed in an xml file somewher ?

Is it a known bug ?

Cheers.

Forgot to mention that I often change theme, for testing : this might be the cause of the disappearings ?

pjft

@evildindon favorites are indeed metadata from the games, stored in the gamelist files. If you re-scrape or delete those files, they will certainly be deleted.

Also note that metadata only saves on closing of ES, so if it crashes it won't save them.

Could that be what you're going through?

Best.

EvilDindon

Hey thanks, I perfectly understand now.

Re-scrape = bye bye favorites.

Good to know. ;)

BigMan1982

@tmntturtlguy speed does not matter, I have tried slow scrolling too. Thanks.

BigMan1982

@pjft sorry for the delay, I have been checking my email waiting for replies...damn I'll have to check my settings again...

5600 Games.
Scrolling down and up.
Video Player? not sure where to check this. OMX is on. (not sure if that is what you mean).
VRAM=90Mb.
I can jump over those games with R1!!! Wow didn't even know I could do that.
It varies where it fails depending on if I am scrolling from the bottom up or the top down. I can scroll the complete list except for what I think is the very middle of the list. When I got stuck while writing this; it worked on Muhammad Ali's Heavyweight Boxing, and it failed on Multi Amenity Cassette System Bios, I deleted that and scrolled up from the bottom and it worked on Muscle Bomber Duo...and failed on another version of Muscle Bomber.
Normal game lists are fine, and I can scroll past those games in their respective normal game list.

Also before testing today I removed the overclock so that's not the issue. Thanks for looking into this.

BigMan1982

@ohmycommodore said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

@bigman1982 i've wondered whether All Games would be taxing when trying to navigate through it. there's not a huge use for that collection, in my case at least, compared to the others.

I agree that I will not use it much but right now I am using it to clean up my build. I will hide it in the future most likely (especially if it conntinues to crash my Pi)

pjft

@bigman1982 let's move this here:

https://retropie.org.uk/forum/topic/12087

While I'm quite confident it's not necessarily related to collections, I want to try to dig into this.

Thanks!