lr-mame2003 driver improvement and backport

Riverstorm

@maxbeanz - Here's the new DAT. All sets are pulled from the 'Current Section' on Twisty's site. If a sample didn't exist that's current then I pulled it from the 'Older Section'. Things to note on the sets used.

Alternate sets from the 'Current Section'

Gorf set Pre-0.125u1
Shark Attack reduced version

Enhanced versions for the 'Unofficial Section' enhanced by Gyrovision

Berzerk
Carnival
Donkey Kong
Space Invaders
Qbert
Rallyx
Star Castle
Vanguard

Riverstorm

@markwkidd - I spent some time last night taking a look at the missing ROMs. I am using MAME 0.196 and Rollback 0.196 that came out a few days ago. I verified my sets are accurate.

With the newest DAT (from yesterday). It looks like King of Fighters was removed which corrected the hacked ROMs, SVC was overhauled and now uses official ROMs but Hyper Street Fighter still looks like it's using hacked ROMs. I Rebuilt with all sets, even the BIOS device sets just to be sure and they don't seems to exist in the official set.

I don't mind if they are hacked ROMs but any chance you could use your kung-fu research skills to verify one way or the other? I think Arcadez said they are official so I am not 100% sure. I do have them from the old reference set we made before the fork but it's a bit tough to search every zip in every ROM from the official set which is like 80,000 ROMs to match them but ClrMamePro is not picking these ones up.

It helps so I can make a subfolder and use and Adds-Path in ClrMamePro for one-off and miscellaneous ROMs that aren't official.

Hyper Street Fighter II: The Anniversary Edition (Asia 040202) [folder: hsf2a - size: 45mb]
missing rom: hs2ax.03 [size: 524288] [CRC32: 5f3d7397] [SHA1: 96f327dd998105ad5dc46bc9d3b741805a840d68]
missing rom: hs2ax.04 [size: 524288] [CRC32: 59acf108] [SHA1: e68fe233681175b29a35badab249c2b892b23af3]

maxbeanz

@riverstorm Do any samples work on yours ? They don't seem to play on mine. I have them in 'BIOS/mame2003-plus/samples' which is the folder that's automatically created.

As I posted above, the new 'svc.zip' seems to have corrupted graphics, 'svcboot.zip' works fine though. Arcadez posted the 2 missing roms for hsf2a on Github (not sure if they are official).

Riverstorm

I haven't tested anything yet. I was fiddling with my Pi last night and crashed it. I really dislike those virtual pad inputs. My input looks like "z RETROPAD1 B" when you try and use the letter "z". If you enter 2 or 3 inputs you have a HUGE string of inputs that is hard to follow. I found if I disable/comment out all inputs from Retroarch and just use the controller it does clean up some of the inputs, actually most (my main MAME default.cfg is 100% clean but I couldn't find them all like z and s still have garbage when doing individual game configurations.

I don't know if the "Plus crew" will address it, if it's even possible, but it kind of drives me crazy.

I will test out SVC later today after I rebuild as I have both the sets and samples ready to go.

As for the hsf2a I take it they are just unofficial ROMs? If they are posted on Github they must not be in the official set.

markwkidd

@riverstorm that's an issue on the RetroArch end but as you have been finding out the doubled "RETROPAD" inputs can be prevented by using custom retroarch.cfg.

PS I'm not sure if the double listings hurts anything, although it might. I will probably find out when I finally get around to setting up my brother's X-Arcade Tankstick to work with Lakka.

In brief, you need to have a custom retroarch.cfg mame2003-plus that unmaps all of the 'conflicting' keys listed here: https://docs.libretro.com/guides/retroarch-keyboard-controls/

maxbeanz

@markwkidd Can you confirm that samples are working for you ?

Riverstorm

Yes that is the correct location for samples. I just downloaded from source today. I recently switched over to Arcade and run everything from there. I built my inputs around MAME and had a heck of a time figuring out how to override all/retroarch.cfg for FBA keyboard/IPAC only while keeping everything else the same including controllers but I did finally get everything working.

So that left the mame-libretro folder open for testing mame2003-plus without overwriting my working set but I have to override everything for mame2003-plus. I dumped about 20 games and found several issues.

svc - crashes to the menu
svcboot - crashes to menu
Depth Charge - no sound
Donkey Kong - half sound, missing several pieces
Zaxxon - no sound

The sounds all work perfectly in lr-mame2003. Several sounds do work correctly but out of the handful I tested I had several errors. It's going to take a whole group of testers to really test all these ROMs.

I had to prompt 'ok' on some ROMs things you can bypass with lr-mame2003 core options like mame2003-skip_warnings = "enabled"

Riverstorm

@markwkidd said in lr-mame2003 driver improvement and backport:

PS I'm not sure if the double listings hurts anything, although it might. I will probably find out when I finally get around to setting up my brother's X-Arcade Tankstick to work with Lakka.
In brief, you need to have a custom retroarch.cfg mame2003-plus that unmaps all of the 'conflicting' keys listed here: https://docs.libretro.com/guides/retroarch-keyboard-controls/

Thanks Mark I will look into it for sure. I don't think it does hurt anything but I would love to see that fixed or at least a clean input screen. If only disabling inputs temporarily to get them clean.

When I used a mouse left click I get something like this "RETROPAD1 LEFT MOUSE RETROPAD2 LEFT MOUSE RETROPAD3 LEFT MOUSE RETROPAD4 LEFT MOUSE. That's from one key press.

It's a real pain as every options shows '...' because the input strings are SO long. Thanks for the links I will check it out. After I disabled everything in Retroarch keys like Z & S were still having "ghost" inputs but couldn't quite figure out where they were defined as everything all/retroarch.cfg were commented out and also arcade/retroarch.cfg had nothing.

markwkidd

Instead of commenting out those lines in the retroarch.cfg, could you try to set them to "nul"?

such as:
input_rewind = "nul"

Riverstorm

@markwkidd said in lr-mame2003 driver improvement and backport:

Instead of commenting out those lines in the retroarch.cfg, could you try to set them to "nul"?

such as:
input_rewind = "nul"

Ah ok, nice, thanks Mark yeah that makes sense. I think it's more cosmetic and a real pain for viewing inputs at a glance but last night I was able to get a completely clean default.cfg for MAME and was close on <game>.cfg overrides for like pinball, etc. that make more sense with the left/right shoulders or triggers, etc. until I crashed it by getting delete happy with some needed files. I will try again tonight and hunt down those scraggler Retroarch settings. :)

Riverstorm

@markwkidd just to add to that with what you said everything just became crystal clear. Those few left over keys that are still in use.

When I disable Retroarch settings it's only temporary as once things are setup I re-enable all the inputs and everything works fine and looks correct. Then I backup my default.cfg between updates so it only needs to be done once.

What prompted me to do is when I started setting up inputs for players 2, 3 and 4 I have assigned all the alphabet keys and of course more virtual pad inputs started making strings even longer so I thought why not clean it up.

Also it seems the Pause key disappeared from lr-mame2003 TAB input I just noticed last night. I have to check mame2003-plus tonight and see if it's there as I left my SD card at home after lunch when testing a few games.

maxbeanz

@riverstorm said in lr-mame2003 driver improvement and backport:

So that left the mame-libretro folder open for testing mame2003-plus without overwriting my working set but I have to override everything for mame2003-plus. I dumped about 20 games and found several issues.

svc - crashes to the menu

svcboot - crashes to menu

Depth Charge - no sound

Donkey Kong - half sound, missing several pieces

Zaxxon - no sound

@markwkidd This confirms that the samples in the samples directory are not being played.

'svcboot.zip' works fine on mine, I built from source this morning and manually generated the datfile. Are you sure you have the right roms ?

'svc.zip' has corrupted graphics.

Riverstorm

@maxbeanz said in lr-mame2003 driver improvement and backport:

@markwkidd This confirms that the samples in the samples directory are not being played.

Some do actually play fine so not all are broke for example these were all working fine Shark Attack, Q-bert, Bosconian, Carnival, Xevious, Wizard of Wor, etc.

I built from source this morning and manually generated the datfile. Are you sure you have the right roms ?

I was just looking at the DAT and I see I forgot to dump the neogeo.zip into the folder, will do tonight and retest.

markwkidd

@riverstorm said in lr-mame2003 driver improvement and backport:

Also it seems the Pause key disappeared from lr-mame2003 TAB input I just noticed last night. I have to check mame2003-plus tonight and see if it's there as I left my SD card at home after lunch when testing a few games.

"MAME pause" is now gone from mame2003 but "libretro pause" is still there (and uses the same code). You should use the retroarch pause hotkey.

This pause change will eventually happen to mame2003-plus once I get time to sync the two cores up better. Maybe late April or May.

Riverstorm

@markwkidd said in lr-mame2003 driver improvement and backport:

"MAME pause" is now gone from mame2003 but "libretro pause" is still there (and uses the same code). You should use the retroarch pause hotkey.
This pause change will eventually happen to mame2003-plus once I get time to sync the two cores up better. Maybe late April or May.

Thanks Mark yeah I do use the Retroarch pause. I prefer the lr-mame pause but for some reason it would always pause as a blank screen and Retroarch doesn't.

What I try and do is match AdvMAME & mame4all (any non lr- cores) to the lr-cores so they are seamless but a few keys like pause is different. Select+p for lr- vs. p for AdvMAME.

Is there any chance of fixing the XBOX silver home button in the center down the road? I really like using that button for pulling up the MAME TAB menu in AdvMAME and mame4all. It would be handy to do the same in the lr- cores.

markwkidd

@riverstorm said in lr-mame2003 driver improvement and backport:

@markwkidd said in lr-mame2003 driver improvement and backport:

"MAME pause" is now gone from mame2003 but "libretro pause" is still there (and uses the same code). You should use the retroarch pause hotkey.
This pause change will eventually happen to mame2003-plus once I get time to sync the two cores up better. Maybe late April or May.

Thanks Mark yeah I do use the Retroarch pause. I prefer the lr-mame pause but for some reason it would always pause as a blank screen and Retroarch doesn't.

What I try and do is match AdvMAME & mame4all (any non lr- cores) to the lr-cores so they are seamless but a few keys like pause is different. Select+p for lr- vs. p for AdvMAME.

Is there any chance of fixing the XBOX silver home button in the center down the road? I really like using that button for pulling up the MAME TAB menu in AdvMAME and mame4all. It would be handy to do the same in the lr- cores.

What happens when you use the MAME Tab menu to try to map the Xbox button? Does it not show up at all?

markwkidd

@maxbeanz and @Riverstorm do you mind communicating directly with @arcadez on this samples issue over in github? https://github.com/arcadez/mame2003-plus-libretro/issues/18#issuecomment-379105149

While I'm traveling there are some things I'm good at keeping up with but this samples thing is a good example of something that's difficult for me to track when I'm moving around from place to place.

Riverstorm

@markwkidd said in lr-mame2003 driver improvement and backport:

What happens when you use the MAME Tab menu to try to map the Xbox button? Does it not show up at all?

Nothing happens. It basically sits and waits for input. It's like your pressing no keys when you press the XBOX home button.

Yeah I will post over there and let arcadez know. Also I am getting the same as Max now that I have the neogeo BIOS in place. svcboot works perfect and svc works but the graphics are all garbled.

maxbeanz

@riverstorm @markwkidd I checked a lot of games that use samples and none of the samples play. The sample support must be broken. @Riverstorm Note: some of the games have sound because it's not using a WAV sample, for instance, 'dkong' uses samples for jump run & stomp, 'bosco' uses them for fire and explosion. There is no speech in 'Gorf', 'Wizard of Wor', 'Shark Attack' etc.

When the sample support is fixed we'll need to use the 'dkong' samples from Twistys 'older samples' as that contains the missing 'effect00, effect01, effect02'. You may wan't to edit your Github post :)

grant2258

@maxbeanz said in lr-mame2003 driver improvement and backport:

he sample support is fixed we'll n

updated the dat today in case people dont about the xml generator damn i just woke up and read this again lol fixed