[SCRIPT] RetroPie Convert Videos

hiulit

@Clyde Thanks! Then I'll add it to the script. I'll let you know when I update it :)

memodellocos

@Clyde explained it perfectly! Thanks for this script too @hiulit !

toimas

@WeirdH No, it actually states that one video matches the 'from'-criteria but does not convert it anyway: "> "centiped-video.mp4" --> Don't convert! Has the same Color Encoding System (C.E.S) as 'from_ces': 'yuv444p'.

toimas

No conversion if from-criteria is met
Just tried the script but all videos that matched the 'from-criteria' were not converted:

> "centiped-video.mp4" --> Don't convert! Has the same Color Encoding System (C.E.S) as 'from_ces': 'yuv444p'.

Why is there no conversion even if the criteria is met?

mitu

@toimas said in [SCRIPT] RetroPie Convert Videos:

Why is there no conversion even if the criteria is met?

Because the video doesn't need converting.

toimas

??? The video is in yuv444p... the conversion should be to yuv420p...

mitu

@toimas How are you running the script ? What parameters are you using ? Did you add --to-ces yuv420p ?

toimas

tried

./retropie-convert-videos.sh --from-ces "yuv444p" --to-ces "yuv420p" --scraper "sselph" --convert-systems "arcade"

or also with the config

# From color (optional)
# Target only videos with this particular C.E.S.
# If left blank, it will target all videos, regardless of the C.E.S.
# (e.g. "yuv444p")

from_ces = "yuv444p"

# To color (mandatory)
# Convert videos to this particular C.E.S.
# (e.g. "yuv420p")

to_ces = "yuv420p"

same result... no conversion of matching source-videos in yuv444p to yuv420p

mitu

Weird, it worked for me before with the arcade videos I downloaded from adb.arcadeitalia.net and your parameters are correct.

EDIT: can you upload somewhere the .mp4 file ?

toimas

Well... I don't think it's the videos but rather the script...
WIthout further investigation I'd suggest that the following case is rather 'counter-productive'

results+=("> \"$(basename "$video")\" --> Don't convert! Has the same Color Encoding System (C.E.S) as 'from_ces': '$from_ces'.")

I just can't think of a single case where I first check a file for matching conditions only to 'not convert' it then...

toimas

I've uploaded a yuv444p file (orginally from screenscsraper.fr)
https://www.dropbox.com/s/o0x30tzv0fpni7l/centiped-video.mp4?dl=0

Clyde

@toimas said in [SCRIPT] RetroPie Convert Videos:

I just can't think of a single case where I first check a file for matching conditions only to 'not convert' it then...

I may misunderstand you, but why check something only to ignore the result afterwards?

Conversion needs time and extra storage space, if only temporarily. Imagine that you have 5000 videos (not uncommon with MAME romsets), but only some of them are in 444p. You may not want to convert all 5000 just for a handful of them.

toimas

My goodness... so many misunderstandings...
Currently the script ignores conversion for videos THAT MATCH the FROM condition...

hiulit

Hi everyone! I've just released a new version 2.1.1 with the Skyscraper's video path fixed :)

hiulit

@memodellocos Can you try with the new version? I've merged your PR. Thanks! ;)

hiulit

@toimas I'll take a look at that when I have the time. The idea is that if from_ces and to_ces are equal, the script won't convert that video. But your settings should work.

hiulit

I've just released a new version 2.1.2.

Changelog

Fixed

The check_CES() function was checking incorrectly if the C.E.S from the video was equal to from_ces and thus not converting the videos.

@toimas Could you check if the script is working for you know? Thanks!

hiulit

BTW, the script is using libav-tools, should I change it for ffmpeg? What do you think?

mitu

@hiulit The new Debian Buster release doesn't have libav-tools anymore, they've switched back to ffmpeg (https://packages.debian.org/stretch/libav-tools). I think that you should transition to ffmpeg to have the script keep working in newer releases of Debian/Raspbian/Ubuntu.

hiulit

@mitu Thanks. I'll do it then.