OXM Player"s origin-x locked to 0.5?

WildWolfOfMibu

I've been messing around with theming and I've run into an odd problem: Whenever I disable the OXM player, my videos shift their position to the left slightly. It looks as if the x-coordinate of the OXM player's origin is locked to 0.5 and cannot be overridden. The Y-coordinate of it's origin is behaving perfectly fine, though. Has anyone else encountered this?

Thanks!

pjft

@wildwolfofmibu I'm not sure why that'd be the case, but if you can send a screenshot of the two scenarios, the ES version and the theme you're using I may try to see if anything strikes me as unexpected.

There's one key difference in how OMX Player and VLC render the videos though - or at least there was, I don't remember if I fixed it on the VLC back in the day.

OMX player renders videos respecting their aspect ratio, whereas the VLC implementation would respect the video resolution. I'm not sure if I managed to address this, but while it may not be obvious what the difference is, some old arcade games would have a non-square pixel ratio, so for instance Aliens vs Predator would render in different proportions in VLC vs OMX Player, though the latter was the correct one. Need to check if I changed that or not.

Still, if you want to share that info it might shed some light.

Thanks.

Edit: also, is your nickname a reference to Saito Hajime?

WildWolfOfMibu

Here you go:
With OXM Enabled:

With OXM Disabled:

As you can see the video is the same size, but it is being placed differently. Toggling the OXM in the OTHER SETTINGS menu was the only change made between these two screen grabs.

Yes, it is a reference to Saitou Hajime :)

EDIT: fixed embedded images.

pjft

@wildwolfofmibu well, this makes very little to no sense.

What theme is that? Can you share that specific theme's arcade XML via pastebin or something - or the entire theme zipped somewhere? Can you also share that specific video via a file sharing service, like Dropbox or Google drive?

Does this happen on other themes? What ES version are you on?

Thanks.

Edit: what's the origin set on the video?

WildWolfOfMibu

Seeing them side-by-side and looking again at my code, I can see that my diagnosis was completely wrong; the positioning of the VLC video is the correct one. I can't post the actual XML tags without getting flagged as spam, so here are the de-XMLed values being used:

origin:0 0
pos:0.315 0.163
maxSize: 0.5 0.46

The theme is Cygnus, but I've been playing around with it since the OXM player ain't give zIndex no respect, and I tried to minimize the amount of unused space while I was at it.

I just tried it on Carbon and Tronkyfran and it didn't repro or either.

pjft

@wildwolfofmibu so, if I read you right, you couldn't replicate the behavior on other existing themes, is that it?

Do send over the tags or content via pastebin or something.

I'd certainly like to look into why they show up at different locations, even if just out of curiosity.

I imagine that the origin 0 0 might play a part in it - I thought that most times I'd seen it it was 0.5 0.5, but once again it might vary. That may be the reason for the disconnect there - or for the surfacing of an unexpected bug.

Thanks!

WildWolfOfMibu

Here is the xml file I modified :
https://pastebin.com/eqCSRNYP

pjft

@wildwolfofmibu Thanks.

I am indeed puzzled. You are correct in that the coordinates suggest the VLC one is correctly placed.

I don't know how long it's been broken so far, but I'd like you to do something:

Can you tell me what ES version you're in?
Can you try installing the development branch and see if it's any different? There were some recent improvements there that may improve that situation.

Still, reading through the code, I'm baffled. Nothing stands out as a potential cause for that.

What screen resolution are you running things at, and what's the specific 1942 video resolution as well?

If you don't have that specific video, and just the snapshot to show instead of the video, can you show me where they're rendered for both VLC and OMX Player?

Thanks.

WildWolfOfMibu

@pjft

EmulationStation - v2.7.4rp, built Dec 5 2017 - 06:53:30
The video output is 1920x1080@60Hx
The 1943 Kai video is 640x480

Where can I get the development branch?

mitu

@wildwolfofmibu Open the RetroPie setup menu and install the emulationstation-dev package, it will replace your version of ES (based on the stable branch) with the latest development version (based on the master branch).

WildWolfOfMibu

Is it just as trivial to rollback from that? My RP runs off of a 256GB SD card that's nearly full, so I don't really want to go through the backup/re-imaging process until I can get a more elegant solution to re-imaging.

WildWolfOfMibu

@pjft I just grabed the latest dev branch and the same issue occurs.

(and sorry for the delay ^_^' )

edwardthehuman

Same issue for me, with OMX on, the video snaps are aligned to the left. Turning them off fixes the alignment. Using Mini SNES theme by ruckage.

pjft

Thanks both. I'll try to dig into it, now with a theme to easily replicate it on my end.

Best.

pjft

Hi all.

Just to confirm, I was trying to dig into this and I can't replicate this with the SNES-mini theme by ruckage. Both VLC and OMX Player deliver the same outcome.

Can you test in the latest dev branch, and while you're at it send a screenshot? Maybe I'm looking into the wrong thing, or a different theme will be better?

OMX Player screenshots, videos playing.

WildWolfOfMibu

Couldn't reproduce it with SNES-mini, but i was able to see the y-position move when using Tronkyfran, and the same issue still occurs as described in my modified Cygnus theme (whose base theme seems to have been removed from github).

I think I should point out that the theme you have listed shows the video on the left side of the screen and mine has the video on the right; this may be relevant because the parameters for position are a scalar of 0..1 so having the video on the left may cause the discrepancy to be imperceivable.

pjft

@wildwolfofmibu well, the first video is actually centered, but noted. I'll try to check tronkyfran if I have the chance during the week, but any other theme will come in handy as well in case that also fails for me. If you can send over two screenshots of what you see in that theme, that'll also help me dig into it.

Thanks.

WildWolfOfMibu

@pjft said in OXM Player"s origin-x locked to 0.5?:

@wildwolfofmibu well, the first video is actually centered

?
No it isn't, both screenshots you posted have the video on the left side of the screen and the gamelist in the middle of the screen.

The behavior in the current dev branch is still how it is shown in the first screenshots I posted.

Also, my original theory that it was because the OMX player's origin was locked to 0.5 doesn't seem to be correct; it's moving the position using some other variable, like maybe size or maxsize

pjft

@wildwolfofmibu ah. I thought you were referring to the position in relation to the video container, as that is what could make any sense to me.

Well, that makes little sense - carbon has it on the right and it behaves exactly as it should as well.

I think at this stage I'm getting nowhere with troubleshooting ES. Please send over your theme so I can try to replicate this under your conditions.

Thanks.

WildWolfOfMibu

@pjft said in OXM Player"s origin-x locked to 0.5?:

Please send over your theme
How do I do that? it's a 10MB .zip file