Multi Switch Shutdown Script!

cyperghost

@caver01 I'm currently working on a version that supports command line options.

Up to now 4 parameters are supported

powerbtn= with this command you set desired GPIO the powerbutton is attached to. If you left unsigned or you enter wrong setting, then default values are used. All devices support that command
resetbtn= with this command you set desired GPIO the resetbutton is attached to. If you left unsigned or you enter wrong setting, then default values are used. Only the both NESPi cases supports that type. So if you use this command on a generic button it will be ignored!
powerctrl= with this command you set desired GPIO the power ON control is attached to. All devices needs this, except the generic button only! If you enter wrong values or leave it blank the default values for expected device are used. This command indicates the power device in which state the Raspberry is, so a complete power cut can be performed!
ledctrl= with this command you set desired GPIO a LED can be shut ON or OFF. Up to now only the NESPi cases supports that feature. I think I can integrate it to other devices, too.

So you set for example your Mausberry-switch via commandline:

default values: multi_switch.sh --mausberry this will use GPIO23 for power button and GPIO24 for power ON control.
multi_switch.sh --mausberry powerbtn=17 this will use GPIO17 for power button and GPIO24 for power ON control still as default
multi_switch.sh --mausberry powerctrl=4 powerbtn=3 this will use GPIO3 for power button and GPIO4 for power ON control
multi_switch.sh --mausberry powerbutton=3 powerctrl=3a will use default values GPIO23 for power button and GPIO24 for power ON control as parameters were all setted wrong.

Also better support pages will be contained. So you get support for each command or device if you just enter ./multi_switch.sh --nespi+ help for example. I will integrate this into a later version so we can rush to v1.00.

Annother thing I may add: --systemd value to create compatibility with Shutdown Service by @meleu. So you enter multi_switch.sh --systemdinto the service file:
instead : ExecStop=/etc/killes.sh
you enter: ExecStop=/path/to/multi_switch.sh --systemd
Then you are completly independent of the power switch settings from here and can use python or any other coding language to to get ES gracefully shutdown just by using sudo poweroff or sudo shutdown -h now. The script is in no way abolished by revitalising the shutdown service because you can still reset/reboot ES with commands this script provides ;)

And then maybe some installer scripts ;)
Much better documentatation ;)
So feedback is appreaciated ;)

cyperghost

Version 0.85 is now available.....

This is a huge step!

v0.70 Parameter control, added extended help pages
v0.75 Parameter --CLOSEEMU is called --ES-CLOSEEMU (both can be used for backward compatibility!)
v0.80 Introduced --ES-SYSTEMD parameter, now the ES gracefully shutdown service by @meleu can be used
v0.85 Code cleanup, added watchdog to kill only persistent emulators with sig -9, added more helppages

cloudlink

Awesome!
With Version 0.85, are the installation instructions still the same?

cyperghost

@cloudlink Yes! Remove old version before and just download the newest. So first use point 3.1 and then do point 3.0 from instructions ;) But there are just a small things improved. It's just better documented now and some calls are much much cleaner. The biggest point is the possibility to setup GPIOs via commandline now and I differ between kill -15 and kill -9 signal now. I try to use kill -15 in first instance. If after 2 seconds the process is still active... kill level 9 is used. kill -9 can make some problems and it should only be used as last resort.
So I use this only for emulators.... you can test for example with pifba. This isn't closed with kill -15 so after 2 seconds the emulator will close caused by kill -9 signal.

@caver01 I tried to use a kind of systemd-like call. But I wasn't able to integrate this into the shutdown service. The call to should be ExecStop=path/to/multi_switch.sh --es-systemd but It didn't work. Even a call to killes.sh that calls the multi_switch.sh and waits several seconds.... Did not work! I hope the service can be done to rework again!

caver01

@cyperghost said in Multi Switch Shutdown Script!:

@caver01 I tried to use a kind of systemd-like call. But I wasn't able to integrate this into the shutdown service. The call to should be ExecStop=path/to/multi_switch.sh --es-systemd but It didn't work. Even a call to killes.sh that calls the multi_switch.sh and waits several seconds.... Did not work!

Bummer. This was exactly what I wanted to do. I wonder if needed subsystems are closing before the call.

cyperghost

@caver01 Maybe you can test and report? For me this did not work and I may hide it (it won't be displayed as option in help pages) if the --es-systemd switch will not run. It should in theoretically work the same way as @meleu's service (maybe you can add the sleep timer) but I had no success.

caver01

@cyperghost I see what you were doing. . . you were actually trying to define the service using multi_switch.sh --es-systemd. I guess I was simply going to call the multi_switch.shfrom meleu's service instead. I need to look at it and see how it is setup now. I wonder if the problem is what others are seeing--that even meleu's service is not working correctly now.

cyperghost

@caver01 Yes...

My first try was the ExecStop=

then later I used the killes.sh script and wrote just

#!/bin/bash
/path/to/multi_switch.sh --es-systemd
sleep 10

Made it executable with chmod a+x .... Did not work. So I think the service isn't working anymore. Maybe I've done something wrong?
I think there is no difference to call a bash file with parameters or to call it without ;) But I'm not sure if these systemd services can parse commandlines.... I think yes! But that's the difference of a hobby user like me and someone who really digs deep into unix systems ;)

caver01

@cyperghost Ok, so on my main arcade build (custom case, Mausberry Switch, dedicated momentary power button, GPIO-->transistor trigger), I dropped in your multi_switch. I updating my Python script that watches the GPIO triggered by the switch on the Mausberry. Now, instead of doing the traditional kill PIDs and killES, I simply call multi_switch --es-poweroff. Fast and done. The Pi shuts down, Mausberry detects the drop on the other GPIO and cuts the power.

For soft shutdown, I updated Meleu's service. My version of the service has been doing two things: First, it triggers the Mausberry via GPIO to the transistor which in turn closes the power switch. Second, it did the old emulator PID lookup and kill, plus killES. These commands got replaced with the multi_switch --es-poweroff call again.

This works great, although I should say that my system is still running the previous RetroPie image (4.3, Jessie).

We know that using the switch works great. We also know that soft shutdown also leads to the Mausberry cutting power correctly. So, I am certain that the service is triggering the transistor. What I don't know is if the trigger is getting picked up by the python script FIRST which calls multi_switch or if the call is being made by the service. Either way, my metadata is getting saved.

I could try removing the call to multi_switch from meleu's service. That way, the only thing the service is doing is triggering the switch. I may just leave it alone.

cyperghost

@caver01 Yes the scripts are called by the service but somehow the sleep commands are ignored.

You can place the transistor call to /lib/systemd/system-shutdown/ as script.
Then make the script executable.... Be aware to place the shebang #!/bin/sh in first line!

You can use the same technique like I've done in Exposed Shim ON OFF

With the script you can differ between reboots, shutdowns.... so the trigger can be called only by shutdown (=poweroff) and reboots.

cyperghost

@caver01 said in Multi Switch Shutdown Script!:

We know that using the switch works great. We also know that soft shutdown also leads to the Mausberry cutting power correctly. So, I am certain that the service is triggering the transistor. What I don't know is if the trigger is getting picked up by the python script FIRST which calls multi_switch or if the call is being made by the service. Either way, my metadata is getting saved.

So with this setup following happens.
The script is first triggered by your python script. It calls in first instance the multi_switch. The multi_switch closes all emulators and wait for ES to finish (so all metadata is saved!) then multi_switch is quit and gives control back to ES-script. The ES-script checks for apperance of files in /tmp-folder, this files trigger the further actions. It can be a restart of ES, a reboot of the system or a system shutdown!

After that the service of meleu is initiated. So the service takes action AFTER all metadata is saved. I wasn't able to run the service in a proper way... so I can't say if it works proper in general :(

caver01

@cyperghost said in Multi Switch Shutdown Script!:

The script is first triggered by your python script

Not during a soft shutdown. For software-initiated, my python is not seeing anything until it detects the button "pressed" by the transistor. So, for soft shutdown, Meleu's service is triggering that. It is then a race between python calling multi_switch and the service calling multi_switch.

cyperghost

@caver01 Oh yes ;) Even on a soft shutdown it is clear what happens.
ES writes a metadta and file into /TMP folder and the binary quits. After that, shutdown is initiated and then meleus service takes action. Then if multi_switch is called indeed a seconds shutdown is initiated ...

But I don't understand what you mean with "race" of the scripts. If you use the --es-systemdparameter I don't initiate annother shutdown.

caver01

@cyperghost It is a race because before the script in Meleu's service calls multi_switch, it first triggers my GPIO transistor. When that happens, my python script calls multi_switch. So, one or the other call is going to make sure everything closes. I don't know which one finishes first.

cyperghost

@caver01 Ahhh........!
Yes!

That makes it clear. But the solution for this is very easy. If you place a script to /lib/systemd/system-shutdown you call from there the trigger to your transisitor then the filesystem is already set to read only. Read more about here: Linux Stack Exchange and in this (late) state the system is miliseconds away for going to powerdown. That is the right moment to send signal to GPIO to "push" the button. The service also pushes arguments to callers. So the script can decide between shutdowns, reboots and so you call the trigger just in poweroff state.

I did it here.... Exposed Shim ON OFF and also here in my Yet annother NESPi case mod also with a Mausberry build in and so there is no race against two shutdowns ;)

So in your case remove the "GPIO trigger"-part from meleus service right to annother script that is placed to /lib/systemd/system-shutdown/-folder. You need sudo command for this as this files are property of root.

caver01

@cyperghost are you saying I can just put a bash script into /lib/systemd/system-shutdown/ and it will execute during shutdown? Why do we need meleu's service?

cyperghost

@caver01 said in Multi Switch Shutdown Script!:

@cyperghost are you saying I can just put a bash script into /lib/systemd/system-shutdown/ and it will execute during shutdown?

Yes! The systemd service automatically parses shutdown status to any scripts in this folder. So $1 can be poweroff, halt, reboot and you can initiate actions by this.

Why do we need meleu's service?

Well.... I don't know if the service is still useable. Some people report is does not work proper anymore. I tried, too - but also failed for proper shutdown. So the service is sadly out of service. And imho the service is usefull not to push triggers like you (ab)use it ... more to just prober shutdown ES ;)

BUT if it will work you would never have to modify button scripts. They just initiate a shutdown and the service automatically shuts down emulators and ES. That's the great advantage.

I modified the original NESPi+ python script for example and added an if/then clause. If butto nis pressed and if ES-PID is active then use multi_switch with es-poweroff switch, else use regular shutdown.
If the service would work again the python script would be just. If button is pressed then use regular shutdown.

But imho it's still a flavour what you want to do and how far you understand what you do.

caver01

@cyperghost I guess we have several options, but I do like your script—one script for several uses. It just makes sense.

cyperghost

@caver01 The intention to write this script is a bit more.

It should provide an easy all in one solution for people who use several switch devices (A simple Button connected to GPIO and ground, both NESPi case types, or the Pimonori ONOFF Shim or the Mausberry switch)
It provides a solution if people use several button to make "reset" actions. So the script can be written to just finish any emulators if they are active, or to restart ES, or to reboot the whole system if button is held down for more than 5 seconds. This is all possible if you use the regular switches.
Personally! I'm owner of 4 of the 5 devices the script supports I have a Mausberry in a NESPi case, I've a NESPi+ case, I've a Pimonori Switch and on my old B1 I've a some single push buttons only. And the setup to perform shutdown with this script was never easier to do now. Exactly as you said...
3.1 Use the script and make calls like multi_switch.sh --es-poweroff from any button script.
3.2 Personally I use it several time like multi_switch.sh --generic powerbtn=23
3.3 Sometimes I do some coding on the mashine via SSH and the TV is not powerd on so just a multi_switch.sh --es-poweroff shutdown the system cleanly with proper quitted ES.
3.4 I setted up a Pimonori Switch on my OwnCloudSystem so there is also just a proper call to multi_switch.sh --onoffshimm

Nevertheless I hope @meleu reactivates the shutdown service again.

Quackwalks

I'd love to see this working for the Kintaro 9000 case. They've been working on the meta data issue for a while now.