emulation station "quit menu" helpsystem font

sexbeer

I noticed a small glitch. Perhaps this does not change, but still.
I set my own font of help system.
but font changes to default when you choose any item in the "Quit menu"
1.

2.

3.

sexbeer

a similar error is noticed not only in the exit menu, but also in many other menus. such as, for example, "Game collection settings", "Sound settings-> Audio device, OMX player audio device", "UI settings-> UI mode", etc.

mitu

Is your theme included in RetroPie so I can test it ?
EDIT: nevermind, I found I have a custom font theme and I can reproduce the problem. Let's see if we can find a solution.

mitu

It's basically happening with every 'MessageBox' (yes/no) dialog and probably other gui windows. I managed to reproduce it with the RetroRama theme (which has a custom font).
Maybe @pjft or @jdrassa can weigh in if it's by design or a bug.

pjft

@mitu terribly sorry, only now did I see this notification. I take it this is related to the PR you submitted, or is it a separate issue?

Edit: nevermind. That seems to be a bug. I'll see if I spot anything in that code in the coming days. I'm not very familiar with that part of the code but should be something that's fixable. :)

pjft

@sexbeer So, looking at the code, it is a simple think to fix, but yet it requires a non-trivial change to make.

I'd like @jdrassa 's opinion on how to best make that happen as I may be missing something very simple and wouldn't want to propose an architectural change to parts of the code I'm not as familiar with.

It is not as much a bug as it is a side effect of the current code architecture (meaning, it's not a mistake in the code, it's just that the way it's structured it makes it hard to make it happen and as such it probably wasn't really looked into when it was created).

mitu

@pjft I submitted #500 for this. Github happily suggested a very similar issue 144, which was fixed in this PR.

pjft

@mitu thank you so much for sending that over. I took a look at that at the time but ran into a couple of issues that would benefit from others' inputs as the changes to make it work don't seem to be trivial and will likely imply some changes in other areas of the code, so I'd rather not do that without others' perspective.

@jdrassa this is the issue that prompted our chat a while back, for context. I may take this on later or at least add comments to the issue that was just created so that we can discuss things there.

Thanks all.