Favorites in KIOSK mode are not working

bebeidon

@mitu that's good to hear i just wonder how :) just let us know if you find something out please.

pjft

I’m fairly sure that by design Favorites (adding and removing) should not work in Kiosk mode. That mode is meant to be locked up pretty tight, no changes. Same reason why you shouldn’t be able to edit metadata in that mode, if I recall correctly.

I don’t recall if it should work in Kid mode but I suspect it shouldn’t either - if it does, it was either added afterwards or it is a design bug.

Unless I misunderstood what the issue is, apologies.

EDIT: it seems 7 months ago a commit made it so that this should work in Kiosk mode, but still not in Kid mode.

https://github.com/RetroPie/EmulationStation/commit/c98a5d6220ec79bf0e0f5695d4a28b489cfb4952

EDIT 2: we need to change this line here to reflect the same change from 7 months ago.

https://github.com/RetroPie/EmulationStation/blob/master/es-app/src/views/gamelist/ISimpleGameListView.cpp#L149

@mitu on my tablet at the moment, apologies.

mitu

@pjft said in Favorites in KIOSK mode are not working:

@mitu on my tablet at the moment, apologies.

I already discovered that :) - that's why I said it's a bug. Initially favorites worked in Kiosk, but in a subsequent commit it was taken away.

bebeidon

@pjft yeah it's just that the documentation states fairly clear it should work in KIOSK mode so I don't get why you expect it to not to? So I understand you and @mitu found the "bug" I would be just interested how to proceed now. Can one fix that with editing configs or is that behaviour hardcoded, so we have to wait for next release to be implemented?

pjft

@bebeidon I expect it not to because I'm the one who originally implemented it and I recall how it was designed and what for :) What the documentation states doesn't matter much as I didn't document it. As far as I was concerned it would be a problem with the documentation.

Though, as I said, the behavior was changed at a later stage and it should indeed work. It requires a small change in the code, which I pointed out. A change in configurations won't suffice.

Best.

bebeidon

@pjft oh ok that makes sense :) So should this be brought to attention on github then or will you look into it or how is the correct way of proceeding? I'm really not that experienced on how development works in an open source project like this and I'm sorry if I'm testing your patience :)

pjft

@bebeidon no, this is fine, no worries :) You’re not testing my patience at all - I just don’t have the time exactly right now to take a stab at it, but the procedure is fairly simple, and in the places I described.

I’ll see if I can take it on sometime soon-ish.

Thanks!

bebeidon

@pjft That's neat! Thanks in advance and please let me know as soon as it's implemented, if that's not too much to ask :)

pjft

@bebeidon should be done now - at least in the emulationstation-dev branch. You probably need to install it from source in RetroPie-Setup's experimental packages, I believe.

bebeidon

@pjft Yes it works! I just hope that experimental branch is otherwise stable^^ Many many thanks! You Sir, are awesome.

pjft

Good to hear it works. Should be stable for the most part, meaning, it's a bit more "leading edge", but there aren't that many developments these days that it would cause it to be intrinsically unstable. Probably just less tested, but on the flipside, if you run into something that's wrong in the experimental branch, but that works on the stable one, it's easier - and faster - to fix, hopefully :)

bebeidon

@pjft Just a heads-up for everyone trying this:
On the first device it worked like a charm no problems.
On the second device I got errors while installing from source and it aborted. The error messages and log did not tell me clearly what's wrong (at least I didn't understand it) but then I figured it out.
You should have at least(!) 1GB free space on the sd-card or you will run into the same erros. After deleting some roms, it also worked on that device. I just underestimated the size that's needed for installation.

bebeidon

@pjft Weird problem just fyi: After installing the emulationstation-dev branch I can't configure my Gamepads right Joysticks direction "Left". All other directions and buttons are working. I think the right joystick is not really used for anything but I thought I let you know.
Even pasting an old controller config, where everything was working and the direction was correctly mapped will unfortunately not fix it.

This only happens with my 8Bitdo Controllers. With my old Saitek controller I can configure his Joysticks without a problem.

When the system just booted up, I can "press" left once with the right analog stick and it works! (8Bitdo) but only one time?! Isn't that weird? Then it stopps working again and like I said it's not responding in the Configure Input GUI as well. But this tells my the controllers are definetly not broken (There are 2 8Bitdo controller anyway it would be really weird if both were broken haha)

Sorry I really thought we had everything sorted out now^^

pjft

@psyke83 does something like this ring a bell?

@bebeidon but I take it that everything in the games and whatnot work fine, and it's just within ES? Or has installing ES-dev affected the emulator configs somehow (which shouldn't have happened at all)?

Worst case scenario:

reinstall normal ES
reconfigure controls
install es-dev
don't touch the controls configuration :)

bebeidon

@pjft It seemed the controller Hotkey was not working anymore, that was the reason for re-configure the gamepad in the first place and then I stumbled over this. I will try to fix it with the advice you gave and let you know if it's working.
I'm using the controllers in Dinput mode but I would really like to leave it like that. Only in this mode all the buttons and extra-buttons seem to work correctly and I also like the vibration confirmation as soon as it's paired. In my experience this is not the case with the other modes.

psyke83

@bebeidon,

Can you post your (correct) controller configuration mapping somewhere so I can take a look?

bebeidon

@psyke83 yes as soon as I'm home again will do. Are you referring to the emulationstation config or Retroarch? I've only looked into the emulationstation one until now.

IanDaemon

I use KIOSK mode for when I have people over and don't want them hitting random buttons and messing things up. Removing all my favorites? No thank you. I'm happy that adding/deleting favorites or custom collections IS NOT available in KIOSK mode. Just use FULL UI if you want to change those lists, then put ES back in KIOSK mode. (Going back and forth is fast and simple.) I have a manually curated collection with custom collections and wouldn't want people pressing random buttons and changing things unknowingly.

bebeidon

@IanDaemon I can understand your point of view but then you could maybe consider to use the KID mode for this purpose.

mitu

@bebeidon for kid mode you have to tag all your games to be visible. I think @IanDaemon has a point here, I'm sure there are other users having a similar setup and this change would impact them for the favourites list.