Is Yabasanshiro emulator coming on retropie?

mitu

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

As long as he is releasing it eventually there shouldn't be an issue.

There's no 'eventually', the license makes it clear you need to release the source on request:
https://www.gnu.org/licenses/gpl-faq.en.html#GPLRequireSourcePostedPublic

Otherwise, 'eventually' can become years and, de-facto, there's no source released.

grant2258

@mitu it says it must be done on request it doesnt specify a processing time as it can be posted by mail.

In an ideal world it would be right away. I think this is why newer emulators are going closed source or bsd type licensing ts not good in the long term either way but it is what it is a monthly donation for your efforts who gets it you or your competition.

barbudreadmon

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

i dont know about the time delay you would need to read up on that

i did, there is none, which is why i'm saying it's probably supposed to be done as soon as possible/requested, otherwise the clause of releasing sources for gpl project would make absolutely no sense since nothing prevent you from releasing them 100 years later

anyway, the fact i had to wait several weeks for the sources to be released after requesting it remains the same

grant2258

I would suggest you contact fsf if you think its within breech or to get clarification at least you could be right not sure on the time frame. It would be a guess on my part in all honestly. I think on a human level the delays is to do with getting your patreon rewards before you share it.

pjft

All in all, I understand your stance on it @barbudreadmon and it is unfortunate that he is not very responsive there. I get his angle on the Patreon preferential treatment - if that's the cause for the delays - but indeed it is not great for a GPL project.

Thanks for helping get it on a lr- core up until now - it's been good to have it on the Pi4, even if at an early stage.

barbudreadmon

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

I think on a human level the delays is to do with getting your patreon rewards before you share it.

It might be his reason, but tbh, i don't think he would get less from patreon if he did release the sources "sooner" :

there is no other saturn project relying on patreon/bounties afaik
there is no saturn project backporting his improvements anymore (at some point kronos did, but since he kept going HLE while kronos was going LLE, it was causing more issues than it solved), i don't consider the libretro port as being a different project since it's a 1:1 port and i asked for his consent before doing it.
the only time his source code was backported for a bounty (i backported his chd support to yabause & kronos), i asked him to claim the bounty for himself

Anyway, if the original authors of yabause are fine with that, i don't think i should be the one contacting fsf

notthesame

@Darksavior I think it's the mesa drivers cos while I was working on the version I have I didn't have theses issues but soon as I did get more stuff corrected it made alot of things break, for example manx TT super bike use to present most of the bike and front grounds but, my version has issues now with only background.

On raidant slivergun, also the intro has thoses glitches but again before making more progress I had no issues but some colors were wrong still.

Same with thunder force had this nasty texture as soon as yhe ships fly away, but when I got more colors corrected this did fix, the underwater shades are missing, I can correct this but this will mess with other stuff so that's the closet I may get.

Buzz's code did correct some color issues I did have like mortal Kombat trilogy, intro that was not enough bits, I would like to try some stuff to see if that intro in radiant slivergun would go away, or panzer dragon water and white wall will go away, but if not then my guess it's this Mesa issues.

Darksavior

Hah, he just updated it to 3.2.

grant2258

Well in all honesty he seems to be the only person capable of doing fixes for this core. If it wasnt for him it would be in a worse place. I would just like to take the time to thank him for his contributions so other ports can be updated by his hard work if they choose too.

barbudreadmon

As i said in one of my posts above, if you don't intend to pressure rpi fundation into doing its job (aka providing better drivers), you should try opening a bounty or something on yabasanshiro's github, that's probably the best way to get a workaround for this asap.

grant2258

yea its not an ideal situation at all any improvements are good. afaik the rasberry pi is a charitable foundation there is limits what they can do financially as fair as getting drivers done ect

dankcushions

i don't think it's fair to blame the drivers/foundation - no-one has isolated the issue to any particular non-conformance, and then logged it with MESA. if they did, i'm sure a fix would be forthcoming. emulation often hits some under/never-used parts of graphics drivers so it's normal for emulation development to find issues with otherwise "good" drivers.

we're just lacking someone familiar with GLSL who can do a deep dive into this. MESA have an IRC where it might be appropriate to raise this informally: mesa3d.org/lists.html (i don't this we know enough about the cause of the issue to raise it on the mailing list or gitlab)

barbudreadmon

@dankcushions said in Is Yabasanshiro emulator coming on retropie?:

no-one has isolated the issue to any particular non-conformance, and then logged it with MESA

Is that really the job of the customer though ? The issue was brought to their "support team", and they didn't seem interested in investigating it themselves. They might be a "charity group", but looking at the CEOs, entrepreneurs and investors behind (https://www.raspberrypi.org/about/governance/), i don't think it's right to market a product and to not look into every issues reported.

dankcushions

@barbudreadmon

The issue was brought to their "support team", and they didn't seem interested in investigating it themselves.

link? a post to rpi's GLES programming forum is not a support request. that's just a discussion forum like here. at no point has the specific issue been identified or it been logged at MESA, or with raspberry pi, as far as i'm aware.

they have a dedicated MESA development team. we just need someone who knows GLSL to identify and log the issue.

barbudreadmon

@dankcushions said in Is Yabasanshiro emulator coming on retropie?:

a post to rpi's GLES programming forum is not a support request.

People marked as "Raspberry Pi Engineer" are answering in that section of their forum though, and none of them answered to the topic about texelFetch, while an example of code to reproduce the issue was provided.

BuZz

@barbudreadmon it wasn't really an example. It was a line or two of shader code with no context.

If someone provided them with a snippet of code to show an issue and reported it to Mesa, it would be looked at.

Btw the commercial arm (heh) of raspberry pi does the development. I have always found them to be good at sorting out issues when an issue can be properly illustrated.

The bug with lr-yabasanshiro may not be an issue with the drivers at all. A proper bug report needs to be done.

Darksavior

I tried to build the latest version from devmiyax's repo. Failed. Ah, well. I don't know what I'm doing, just thought I'd try.

barbudreadmon

@Darksavior said in Is Yabasanshiro emulator coming on retropie?:

I tried to build the latest version from devmiyax's repo. Failed.

i stopped maintaining the port on his repo after https://github.com/devmiyax/yabause/issues/630#issuecomment-547787501 , this conversation kinda pissed me off, especially with him releasing a switch version based on the lakka distro a few weeks later...

mechafatnick

I tried Assault Suit Leynos 2 yesterday and the entire ground is missing. :)

There's definitely some issues on the 2d side of things.

grant2258

@Darksavior seems like there is a end to development on libretro on this port unless someone picks it up on there end. The only way to test would be by using standalone build. If that works well you can just request an update on the github page on libretro for someone to pick it up and hope for the best.

ok ive made a patch not got any saturn roms but it compiles just apply this patch over the repo

git clone https://github.com/devmiyax/yabause.git
cd yabause/
wget https://github.com/grant2258/yabause/raw/master/pi.patch
git apply pi.patch
cd yabause/src/libretro/
make platform=armvneonhardfloat  -j4

then copy the bin over no idea if this is enough just done the basics. I basically repaced the chd code to the libreto one not sure if this will cause issues loading or not hopefully it works