Mortal Kombat 2/3/UMK3 Audio

GreenHawk84

I vote that we (since I contributed to the donations) give the money to the person who could also get it working on FBAlpha. If we confirm a fully functioning and proper MK series on FBA, that person should get the money. Not sure if anyone agrees, just my suggestion.

dankcushions

https://www.bountysource.com/issues/36272753-dcs-games-mk2-etc-slowly-overflow-the-buffer-periodically-distorting-sound
looks like someone has started working on this :D

i will test it as soon as it's completed and make sure it gets accepted promptly.

GreenHawk84

@dankcushions said in Mortal Kombat 2/3/UMK3 Audio:

https://www.bountysource.com/issues/36272753-dcs-games-mk2-etc-slowly-overflow-the-buffer-periodically-distorting-sound
looks like someone has started working on this :D

i will test it as soon as it's completed and make sure it gets accepted promptly.

I will test toooooo, I hope it works well!

dankcushions

this is now merged! if you rebuild lr-mame2003 from source (takes about 30 minutes) you will have it. can anyone test, please? i played mk2 for 10 minutes and got no distortion, but I didn't have a chance to test longer/other games.

GreenHawk84

I am at work today but I will get home and test MK2, MK3, UMK3, and I THINK Rampage WT did it too so I'll check 'em and post my results. Probably extensive play to make sure this is squashed.

GreenHawk84

@dankcushions said in Mortal Kombat 2/3/UMK3 Audio:

if you rebuild lr-mame2003 from source (takes about 30 minutes)

How do I do this, I never did this?

dankcushions

@greenhawk84 said in Mortal Kombat 2/3/UMK3 Audio:

@dankcushions said in Mortal Kombat 2/3/UMK3 Audio:

if you rebuild lr-mame2003 from source (takes about 30 minutes)

How do I do this, I never did this?

https://github.com/retropie/retropie-setup/wiki/updating-retropie#updatinginstalling-individual-packages

manage packages > main > lr-mame2003 > source

GreenHawk84

Eureka! It works!

lostless

Has the binary been updated in retropie with this fix yet?

darkmenace

Is it normal, when going into update the lr-mame2003 via source to get a black and white command prompt style screen full of garbage continually scrolling?

lostless

@darkmenace yes

darkmenace

Whilst I think things improved a bit with the sound, I was still getting a bit of crackling and crustyness. Is there any easy way for me to verify that I successfully updated lr-mame2003 package to the version with the fixed audio?

dankcushions

@darkmenace if you updated via source, you have the fix. if you go to the retroarch menu (hotkey + retropad X) in game, you can make a note of the version string at the bottom left and we can verify.

before the fix the sound would a garbled mess and out of sync after 10 minutes of play. anything other than that is a different issue.

GreenHawk84

@darkmenace yes the sound is not perfect in general but this was a fix for a large issue that occurred after ~10min of playtime.

As for the general crackle at times, that will have to be resolved separately, but not enough (IMO) for another community fund.

celly

@dankcushions so I won't need to update any roms or rebuild my set, just the emulator from source and that's it?! Sweet!

arcadez2003

It's the older DCS sound cores which cause the crackles in the sound this is gone by MAME84 and DCS was updated again come MAME85
but of course those versions lack the speedhacks however they can always be added back in to regain the performance boosts.

megaJekan

The bug is re-introduced again in the latest lr-mame2003. Maybe someone can look at it.

For those who want to play now and without any issues, I've forked the Git project and created a branch named "mk3fix", which points to the revision, where the bug was actually fixed.

So you should open file RetroPie-Setup/scriptmodules/libretrocores/lr-mame2003.sh and replace

gitPullOrClone "$md_build" https://github.com/libretro/mame2003-libretro.git

with

gitPullOrClone "$md_build" https://github.com/genius8086/mame2003-libretro mk3fix

Then please build from source again.

grant2258

your code base is seven months old the code changed since then youll introduce heap overflows.

The most likely cause of this is the dcs speedhack change now works it didnt before. The setting done nothing before

test your current code with mame2003 src/vidhrdw/midtunit_vidhrdw.c

(note fast dma is off by default now it used to be (both the hack and fastdma where on by default) I was against changing this

megaJekan

@grant2258 It is obvious that the code is outdated, I was trying to search the other forums to find out the commit e6bf01a531ec151ccec9f78dfaf87586574ee966 with fix. But the recent master has this "every 10 minutes cracking sounds" issue again. Maybe you can point to the commit, which we can use.

"dcs speedhack" - is it a core option which can be disabled?

grant2258

yes it a core option is but it wasnt hooked up right on mame2003 in your revision. Basically both where on by default.

try mame2003+ i never changed it there