Development of module-script generator for lr-mess, lr-mame and mame standalone

Folly

@bbilford83 said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

I will add my towns game and then get to your request this weekend, I promise.

I also added clone detection when downloading from the restricted.
There are a lot of clones in the lists/database of the handhelds and also in the ones used for realistic overlays.
Clones are not separate roms but are within the main roms.
For example gnw_egg is a clone of gnw_mmouse and ngnw_dkcirc is a clone of gnw_mmousep.
Getting the original main file and renaming it to the clone name will give the proper rom or at least it will load properly while the name is linked to the hash tables when loading with basename runcommands.

So downloading the main and renaming to the clone is what I have automated in the script.

bbilford83

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

@DTEAM @bbilford83 ,

I changed and added quite some stuff in 264.05.

Would like to ask you both to test the stuff.
Particularly the part switching between database versions and the coleco sgm module part.
For the database part there seemed to be an issue that I never saw before, like many wrong numbers in the dialog box.
Tested all the code and added the unset IFS command.
It looks like it's ok again.
For coleco the sgm module will be added by default now when the database is higher than 0264.
I tested some roms that work with and without sgm module and both seemed to work when the sgm module was inserted.
Still the new 0265 database isn't there yet so if you want to test then you have to change line 1908 into :
[[ ${systems[-1]} == coleco ]] && [[ $(expr $rp_module_version_mame + 0) -gt 263 ]] && ExtraPredefinedOptions+=( "-exp sgm" )
( so you will be able to use it with database 0264 )

I also like to know what you both find about the idea that the standard coleco install has the sgm module as we separated this in the past to a coleco_sgm install.
Seems to me that this is the easiest solution.
However, we might need to change the theme for coleco but lets discuss that later.

For the other restricted parts we can't talk about that much, but I would like to hear if you could figure it out how it works and if it works for you both.
Remember there are rompacks that are too big for using the added options.
I still need to add that advise/info in the variable of the form for get_all.
A good start is MSX and MSX2.

P.S .
I see that I might need to add sgm for colecop too.

Hi @Folly. I have read this through and honestly I had never heard of the "Super Game Module" for Colecovision, only read about it when I searched to see what SGM is. If I understand right, it would have improved the graphics on a bunch of arcade ports to make them closer to arcade quality, right? If it were me, I do think I would probably try to keep them as separate installs. I no doubt would want to play all the games that could be enhanced with SGM with those enhancements, but I bet at least some people would want to have the option if only to see what the difference would look like. Just my two cents though.

I don't understand what you mean about the other restricted parts that we can't talk about though, sorry!

Folly

@bbilford83 said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

I do think I would probably try to keep them as separate installs.

Earlier I was thinking that it was too difficult but I managed it :
https://github.com/FollyMaddy/RetroPie-Share/commit/baa8f8ad89c5ff9d8b4910cbeb2c8ee379ac1e16

The description in the commit should explain it all.

I think it's indeed better to split it that way you can put the non-sgm games in the folder coleco and the sgm ones in coleco_sgm just like we did earlier on.
Now the themes also don't have to be changed if the have both coleco and coleco_sgm in them.

I think @DTEAM will also agree that this is a better solution.
Right @DTEAM ?

Remember that the mame versions from 0265 and above only work if you have Bookworm OS running.

Folly

@bbilford83 said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

Would like to ask you to test the stuff.
Particularly the part switching between database versions

You don't have to test this part.
I still experience the issue.
Sometimes good versions are shown and sometimes not.
I am trying to come up with a better solution but will take a while.

bbilford83

@Folly everything you said makes sense, though I agree that's odd about the databases.

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

Remember that the mame versions from 0265 and above only work if you have Bookworm OS running.

I somehow entirely missed this. I see that .265 was released in late april but when I updated to mame/lr-mame/lr-mess yesterday I see now it only updated me to .264. I guess that is because it RetroPie-Setup somehow knows I'm not on an OS that can handle .265? What a bummer. I see the exchanges you had with @JimmyFromTheBay about how we'd have to set up a new SD card to get it running off Bookworm. I guess I will treat this as a "stopping point" for my pi4 image and start anew for my pi5 one once retropie/emulationstation is working smoothly on it.

Folly

@bbilford83 said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

though I agree that's odd about the databases.

Have fixed the issue with the database list, read here.

DTEAM

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

I think @DTEAM will also agree that this is a better solution.
Right @DTEAM ?

Yes, it's a good solutions.

If you want me to change the theme name, I can do that too. In MAME they are named coleco_sgm = coleco_homebrew. Initially, the theme was created for fbneo

Folly

@DTEAM

Thanks !

I saw indeed the name coleco_homebrew.
Personally I find coleco_sgm a better name.

Not entirely sure but I think not all homebrews make use of sgm.
Would have to look into the hash table for that.

Edit :
If needed you could make a duplicate.

DTEAM

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

Edit :
If needed you could make a duplicate.

sure

Folly

Just updated the script so psions can be installed properly.
For more info see here.

Drivers still need to be tested though.

Folly

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

Not entirely sure but I think not all homebrews make use of sgm.
Would have to look into the hash table for that.

@DTEAM
Just had a look at coleco_homebrew.xml.
There are also many non-sgm games in them, so not for sgm only.

DTEAM

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

Edit :
If needed you could make a duplicate.

done!

Folly

@DTEAM

What is your opinion about the names ?
coleco_sgm vs coleco_homebrew

Do you think I should change it in the script ?

Btw :
Are you up to date so you can run mame 265 ?

Edit :
No reply from you but I decided to change coleco_sgm into coleco_homebrew.
I think it's better overall.
See commit.

DTEAM

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

Btw :
Are you up to date so you can run mame 265 ?

No, I didn't download it from the source. I'm waiting for the precompiled one.

Folly

@DTEAM @bbilford83

I have added standalone mame version detection 265.17.
So the database will be more in sync with mame.

Can you both test it and let me know if you find this an improvement.

shift

@Folly A question: I tried to use the mame for the Philips CD-i and also for the FM Towns, and I saw that I have to pass the .cue file to it first (even if the size is 0 bytes I saw that it works), but not Is it possible to use the mame directly with .chd files without necessarily having to use the name of the "rom" (8 digits) in .cue format?

Folly

@shift

Have you installed it with my script ?

If you have a good mame binary running, that doesn't have the CHD issue, then you can load that CHD or even .CUE directly with the use of the media option.
My script creates these runcommands too using the media option -cdrm.
That should work.

shift

@Folly You're right, I was using the old script, now that I have installed the mamedev.sh it works perfectly even launching the .chd file directly. Thank you!

Folly

@shift

Good to hear !

What is your all over first impression now using the new script ?

shift

@Folly said in Development of module-script generator for lr-mess, lr-mame and mame standalone:

What is your all over first impression now using the new script ?

The new script is easier to use and is really intuitive, I added the new machine in a second!