Development of module-script generator for lr-mess, lr-mame and mame standalone

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

Every systems working fine excepted C64. For system like FM Marty, you have 15 choices. It's realy nice to see all that.
The MAME Basename option never worked for me as it currently is.
It works if I replace (ex.: gamate) :
mame-basename = "/opt/retropie/emulators/mame/mame -rompath /home/pi/RetroPie/roms/gamate -v -c %BASENAME%"

By
mame-basename = "/opt/retropie/emulators/mame/mame -v -c gamate %BASENAME%"

We can try to change that to improve, agree ?

yes

Folly

@dteam said in Development of module-script generator for lr-mess and mame standalone:

@folly said in Development of module-script generator for lr-mess and mame standalone:

Every systems working fine excepted C64. For system like FM Marty, you have 15 choices. It's realy nice to see all that.
The MAME Basename option never worked for me as it currently is.
It works if I replace (ex.: gamate) :
mame-basename = "/opt/retropie/emulators/mame/mame -rompath /home/pi/RetroPie/roms/gamate -v -c %BASENAME%"

By
mame-basename = "/opt/retropie/emulators/mame/mame -v -c gamate %BASENAME%"

We can try to change that to improve, agree ?

yes

Did a second fix, because I didn't remove the old ones.
I had to change the names of the old ones to *-test otherwise we had double commands with the same loader name.

So now you can test gamate.

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

BTW. Did you try cheats ?

for lr-mess in MAME UI (with hash files)

put cheat.7z in /home/pi/RetroPie/BIOS/mame/cheat

in custom-core-options.cfg

/opt/retropie/configs/""system"" (ex: coleco)

do

mame_cheats_enable = "enabled"

also in retroarch-core-options.cfg

/opt/retropie/configs/all

You must have the real MESS/MAME romset to do that

Boulder Dash - ColecoVision (lr-Mess)

Folly

@dteam

I need some more information to translate this to a proper solution.
I hope I can think of a way to make a good implementation ;-)

Did you run Boulderdash with the loader lr-mess-cmd or lr-mess-basename ?

The custom-core-options.cfg isn't added as config running the above loaders, but is added using, for ex., lr-mess-system-coleco-cart .
Does it work when you use (hash file names) with this loader, for example ?

The retroarch-core-options.cfg should always be loaded, perhaps an idea to add it only in this config.
Can you test, if this works, if you only use mame_cheats_enable = "enabled" in retroarch-core-options.cfg ?

Edit :
I have updated the script so the `install-<system>-cmd module-script will add mame_cheats_enable = "enabled" in retroarch-core-options.cfg.
I hope this is a good solution and that it's not conflicting with something else.

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

Did you run Boulderdash with the loader lr-mess-cmd or lr-mess-basename ?

lr-mess-cmd + MESS romset
and
lr-mess + MESS romset

lr-mess = "/opt/retropie/emulators/retroarch/bin/retroarch -L /opt/retropie/libretrocores/lr-mess/mess_libretro.so --config /opt/retropie/configs/coleco/retroarch.cfg %ROM%"

I think you don't need Hash file to run cheat finally. You just need the good game rom

For retroarch cheat codes, I'm not able to use those. They load, but nothing happens.

Folly

@dteam

Perhaps we want too much and coleco seems difficult on my end.
Reading your reply the cheats addon won't do much, perhaps I have to remove it again.

Can you check your /dev/shm/runcommand.log if you can find something about how cheats are being loaded ?

DTEAM

@folly

@folly said in Development of module-script generator for lr-mess and mame standalone:

Reading your reply the cheats addon won't do much, perhaps I have to remove it again.

No, cheats for Coleco roms from Mess romset run well with your lr-mess-cmd. It runs in MAME UI.

Folly

@dteam said in Development of module-script generator for lr-mess and mame standalone:

@folly

@folly said in Development of module-script generator for lr-mess and mame standalone:

Reading your reply the cheats addon won't do much, perhaps I have to remove it again.

No, cheats for Coleco roms from Mess romset run well with your lr-mess-cmd. It runs in MAME UI.

Ok , I will keep my update, for the cheats, in the script then.
( mame_cheats_enable = "enabled" in /all/retroarch-core-options.cfg )

Does the cheat still work when you remove it from the custom-core-config and keep it in /all/retroarch-core-config.cfg ?

And then, when you set cheats on disabled in /all/retroarch-core-config.cfg is it disabled then ?

DTEAM

@folly

Does the cheat still work when you remove it from the custom-core-config and keep it in /all/retroarch-core-config.cfg ?

Good question. I'm gonna do a test

new edit
Yes, It works

And then, when you set cheats on disabled in /all/retroarch-core-config.cfg is it disabled then ?

No, doesn't show in MAME UI

cheats = enable in custom-core-options.cfg only doesn't work also.

So It runs with retroarch-core-config.cfg

Folly

@dteam

Perfect !
Exactly what I was thinking.
Now we know it should work.

Thanks for testing :-)

I could have added it in the custom but then you have to append the config and the config is actually created for the Valerino scripts.
So this solution is perhaps the best for now.

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

What do you manage ?, In this way artwork is automatically loaded with MAME standalone.

Yes I did, this background is then renamed and used as retroarch overlay with lr-mess.

For MAME standalone I left the artwork zipped in /home/pi/RetroPie/roms/mame/artwork/<artwork>.zip

I confirm, It works great. Is It doable to get from zipped artworks in the MAME artwork folder, an unzipped copy and renamed backgroud files for your new ovelays directory (konamih, tigerh, etc).
It could be done with your generate-overlay-configs.sh

Maybe if you put everything in the overlay folder without subfolders, you could generate overlay .cfg files for everything in the /home/pi/RetroPie/roms/mame/artwork/ and copy/rename each background

That way, if It's doable , It could be work for arcade games also and handheld consoles overlays!

Folly

@dteam

Yes, I think so too.

Indeed I could implement this in the overlays script.
So then it would create the directories, create the configs and download the artwork and overlays and cheats and place them in the correct place, just in 1 run.
And It would be nice if all files can be downloaded from the same source.

Well I will think about it a bit, but that would be awesome.

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

And It would be nice if all files can be downloaded from the same source.

Cheat codes for MAME/MESS : Pugsy's Cheats , you must get cheat.7z and put It in /home/pi/RetroPie/BIOS/mame/cheat

MAME Artworks: (Handheld systems without arcade artwork), could be moved somewhere else on another server.

some observations (with your 3 days ago version):
For MAME systems (TigerH, KonamiH, Jakks, etc., ) - MAME Romset

all options working well lr-mess-cmd, etc. (except -- > lr-mess-basename - It freezes)

For systems like coleco, nes or others,

Lr-Mess-system and mame-system always working with No-intro, Tosec, MESS, etc. romsets
lr-mess-cmd works with mess romset
lr-mess-basename, mame-basename and mame-cmd never work

For systems using a nomenclature in RetroPie different from that of MAME (e.g .: jaguar = atarijaguar)

only lr-mess-system and mame-system working with No-intro, Tosec, MESS, etc. romsets

Have you the same results?

Folly

@dteam

Thanks, I will read the information and see what we can do with it.

I think I have similar results, but still I have to do some tests.

Summarized :

It seem I can remove the old :

lr-mess-basename,
mame-basename

For the handhelds this should be kept :

mame-cmd

Folly

@dteam

I have made some progress on the downloading of cheats and artwork.
But google drive is a pain !
For google drive I found a nice script, but it doesn't get all the files.
So I made an issue on Github.
Hopefully the maker of the google drive script will do something with it.
To be continued...

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

But google drive is a pain !

I put It there because It was easy to do for me for storage, but If you prefer, you can download those files and transfer It somewhere else where It will be easier to manage It.

Folly

@dteam

I will first wait on the response.

If you have some extra capacity an other solution could be to add some separate handheld folders for this purpose.

We can discuss this later.

Folly

@dteam

So you see, if this works, it would be great.
Just using a few lines ;-)

If you are interested in the code I already made.
This is it :
(OK)

#gets the cheat.7z and places it in the correct path
#works perfect
wget -N -P /tmp http://cheat.retrogames.com/download/cheat0221.zip
unzip -o /tmp/cheat0221.zip cheat.7z -d $HOME/RetroPie/BIOS/mame/cheat
rm /tmp/cheat0221.zip

EDIT ~~(look a few posts ahead for better code for artwork !)~~ :
gdrivedl got only a part of the html code(old version).
If you would browse the website, you will see that when you scroll-down, more info is added to the page.
I think that is the reason why it isn't working.
So I created an issue on github which is solved now.

#get all artwork files and put it in the correct path
#first test got about 42 of 162 artwork files :-( 
#second test with improved version of gdrivedl.py gets all files :-)
wget -nv -O /tmp/gdrivedl.py https://raw.githubusercontent.com/matthuisman/gdrivedl/master/gdrivedl.py
python /tmp/gdrivedl.py https://drive.google.com/drive/folders/1sm6gdOcaaQaNUtQ9tZ5Q5WQ6m1OD2QY3 -P $HOME/RetroPie/roms/mame/artwork
rm /tmp/gdrivedl.py

( issue is posted here and gdrivedl.py is improved, accordingly : https://github.com/matthuisman/gdrivedl/issues/12 )

DTEAM

@Folly
Great, I’ll try those and give you news.
For the artworks on google drive, if you prefer, I can split It per systems in folders

Folly

@dteam

I have a solution already ;-) (too bad, not the solution after all ! :-( )

This is the code to get all 162 files the artwork files which are then placed in the correct directory ( still testing but seems to be ok / damn stuck at 114 files ! ) :

wget -nv -O /tmp/gdrivedl.py https://raw.githubusercontent.com/matthuisman/gdrivedl/master/gdrivedl.py
curl https://drive.google.com/embeddedfolderview?id=1sm6gdOcaaQaNUtQ9tZ5Q5WQ6m1OD2QY3#list | egrep -o '(\w|-){26,}' | grep entry | sed 's/entry-//g' | while read fileid ; do python /tmp/gdrivedl.py https://drive.google.com/file/d/$fileid -P $HOME/RetroPie/roms/mame/artwork ; done
rm /tmp/gdrivedl.py

This code should be working but google drive seems to block after a while.
(see https://retropie.org.uk/forum/topic/29682/development-of-module-script-generator-for-lr-mess-and-mame-standalone/41 )

This is how it works :

with https://drive.google.com/embeddedfolderview?id=1sm6gdOcaaQaNUtQ9tZ5Q5WQ6m1OD2QY3#list you can list all the files in one page.
with egrep -o '(\w|-){26,}' | grep entry | sed 's/entry-//g' you filter out only the file-id's.
then it uses these file-id's every time in the loop, creating a command one by one for each file.