meleu last edited by
Where were you all this time?!?!
Other guys showed willingness to improve emulationstation here (example: https://retropie.org.uk/forum/topic/2250/emulationstation-fork). But you came with some cool stuff ready!
Grid view?! You've made all my dreams come true! That was the last thing I've wanted with RetroPie for it to be complete in my mind (and the BBC micro but that's in the plans) I reallllllly like the grid view. On screen keyboard is quite cool as well. Good work.
Though in terms of your source code it would have been nicer if you'd have forked the original source and had a more complete history of your changes so if we wanted to incorporate certain pieces of your code it would be easier.
Arcuza last edited by
@jacobfk20 Oh my god, this is awesome!!! Is this mod compatible with all existing themes, or do the Pixel theme need to be updated to support this modded ES?
@Arcuza I am trying to update the Material theme. Pixel and Turtle Pi have to be fixed. Pixel's simple view has a centered logo and Turtle Pi has a centered logo theme wide. The logo is covering the Game Name in grid view. I can't seem to find how to move the game name. When I figure it out. I will post here.
@lilbud another idea is to have the grid view be modified to have the game name right under the image for each game kinda like kodi, don't know how that would work code wise though. (Or you could just remove the gamelist altogether if all games are scraped)
@herb_fargus I was trying to move the game title with no success. Maybe a rectangle under the header would be the game name
mattrixk last edited by
Themes.md makes mention of a Grid View. If you could get that running theme makers could create separate layouts just for Grid View instead of using the Detailed View. I know the Detailed View of my theme MetaPixel won't look any good with your Grid View, but it would only take a few minutes to whip up a decent Grid View layout.
@mattrixk I tried to add a grid view in the theme.xml files. But ES will not see it, or crash.
If someone could try this code posted above.
@mattrixk I can easily make Gridview report as Gridview instead of detailed view. All themes will have to be updated after changing that.
@herb_fargus I actually would like to do it how Kodi does it. It is possible. Also, sorry I kinda just dumped the whole thing onto github... If you would like to add or remove anything I'd be glad to do it. Just about everything I added is modular and can be removed.
@lilbud I will look into how themes work fully today to make sure they work as they should and move the game title.
lilbud last edited by lilbud
@jacobfk20 when I tried to make a change under detailed. Nothing happened. Adding a grid view in the theme.xml did nothing. I am trying things on my theme to see exactly what needs to be done. The md_title you mentioned does not exist in any theme. Or anywhere for that matter. If you need anything tested. Get in touch with me. 3 - 4 themes are unusable in some state due to the logo overlapping the game title. If you could make the grid have the game title under each box art like herb mentioned. That would be best to fix some issues
@lilbud I just updated the original post with an update. There is now a test build that makes Grid View separate from other gamelist views. You earlier posted that <view name="grid"></view> didn't work, well it now will in the test build. This should make it fully customizable for theme makers. Putting the name on or under the game's boxart will take me a couple days to add, but I am wanting to do that.
Here is an Imgur link to a small album showing some of the things I've added.
It looks... It's... so beautifu.. ahem. I promised myself I wouldn't cry.
LasagnaDevil last edited by
One of the things I've always though was needed was a “Favorite” games option within each system, and another one where we just displayed ALL GAMES in one single folder, either sorted by letter, size, amount of times played or system.
Thus we could have all Favorites in a single folder to be displayed upon loading, for instance.
@jacobfk20 the main thing I'm interested in is the grid view, though there are obviously other features that others would like as well (there has been quite the backlog of requests since aloshi left it) but for each feature added feel free to either submit a PR or log an issue here: https://github.com/RetroPie/EmulationStation which can further the discussion on what we can add to the RetroPie project to make it better. You've done fantastic work and it would be great for the whole RetroPie community to benefit from it. I'd be happy to do any testing as well.
I just updated my theme to work with grid view. Just one thing you could look into, folders don't seem to work in grid view. I keep my mame roms in alphabetical folders. and folders will not open.
@herb_fargus I didn't even know there was a retropie branch of ES. I now see I am pretty behind on its branch. I will fork and build on its latest build and make sure everything is compatible. Thank you for pointing me in that direction. (I'll also try submit things I've done in different PRs)
@lilbud Glad to hear you were able to get your themes working. I looked into why files inside folders are not being added and understand why. It shouldn't take long to fix.
@LasagnaDevil I like the idea of having a favorites section that the user adds to. Someone else mentioned it as well as the different sorting options as well so it may be my next project.
@mediamogul No need to cry :) Thank you.
lilbud last edited by lilbud
@jacobfk20 To get any theme working, change
<view name="basic, detailed">
<view name="basic, detailed, grid">
Change in the main theme.xml. carbon.xml, pixel.xml, etc.
Dangit, if this carries on, I'll have to redo my entire collection of game snaps and convert them all to box art! You might want to contact @Zigurana as he's been working on Kid Friendly additions, favorites and some neat things as well.
@Rookervik Between this, the multiple forks and Zigurana's ES. We could have something here
ben_thatmustbeme last edited by
@jacobfk20 Awesome work man. I'm looking at diffs now to see how I can bring all this stuff in to my fork. I've been trying to keep copies of all the current forks, honestly it seems that RetroPie's copy of ES is the most actively updated.
I have done a bunch of work to try to make sure everything is clean and free of any build warnings (i'm a bit of a nut for that). I'd love to get all the people interested back in to a single repo, and I think doing so under RetroPie's name would be great.
Who is in change of retropie's ES branch? Is there really anyone in charge of it? I wanted to get everything on a standard style (which makes merging diverging branches a LOT easier). I've been using
astyle --style=1tbs -n --recursive '.cpp' '.h'
in the main directory as its pretty close to the style I am used to.
If I made PRs to that effect for both Retropie's branch and @jacobfk20 would that be acceptable? Where would the best place for conversations of this nature be? here? IRC? ('m in there all the time as ben_thatmustbeme)