RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login

    es-theme-carbon-2021 pull request

    Scheduled Pinned Locked Moved Ideas and Development
    emuationstationcarbon-2021
    7 Posts 2 Posters 429 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • phillip_benoitP
      phillip_benoit
      last edited by

      I made a pull request for es-theme-carbon-2021 to fix some of the system SVG logos for visibility. I made my account / this post so the community can beat me up about it.

      My Changes

      You'll notice the MSX logo does not load. That is a problem with the main branch. Even if you think what I did sucks, that should be addressed.

      1 Reply Last reply Reply Quote 1
      • mituM
        mitu Global Moderator
        last edited by

        Thank you for the changes. I've left a comment on the PR.

        phillip_benoitP 1 Reply Last reply Reply Quote 0
        • phillip_benoitP
          phillip_benoit @mitu
          last edited by

          @mitu github does not allow me to make individual pull requests. I guess we're done here.

          1 Reply Last reply Reply Quote 0
          • mituM
            mitu Global Moderator
            last edited by

            You can't split an existing PR, but you can make new ones.

            phillip_benoitP 1 Reply Last reply Reply Quote 0
            • phillip_benoitP
              phillip_benoit @mitu
              last edited by

              @mitu It will only let me do all my changes at once

              mituM 1 Reply Last reply Reply Quote 0
              • mituM
                mitu Global Moderator @phillip_benoit
                last edited by mitu

                @phillip_benoit create a branch for each change, before adding your changes, then create a PR from that branch.

                phillip_benoitP 1 Reply Last reply Reply Quote 0
                • phillip_benoitP
                  phillip_benoit @mitu
                  last edited by

                  This post is deleted!
                  1 Reply Last reply Reply Quote 0
                  • First post
                    Last post

                  Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                  Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.