Video Preview in EmulationStation

Nismo

@fieldofcows I'm thinking on since we can display md_video and md_image at the same time, you can do the same than preview image for video by using md_image and place it in the same place than the video without the "extra flag" and obtain the same result than the image preview for video you hardcoded on Issue #3, but with the advantage that people can use it in their themes only if they need it.

So reverting issue 3 means that people are not forced to show the image preview in their themes if they doesn't want to, but still can be do it easily if they want it in their theme.

Also I think it's less resource demanding because the way I say emulationstation doesn't need to do the same operation twice (like in my theme).

So I vote for revert Issue #3 commit for better theming possibilities and performance . It's just my humble opinion of course...

Nismo

@fieldofcows Sorry mate but Issue #7 is not fixed. I was thinking it was fixed because I enable "save metadata on exit" option and the relative paths still in my gamelist, but I was wrong, simply my paths where untouched because even with the option enabled, emulationstation doesn't save on exit.

Sorry for didn't notice before, but i was working on themes and was too late.

fieldofcows

@Nismo So what you're seeing is your relative paths being replaced with full paths in the gamelist? If so then I don't think that's anything I've done. I think it's preexisting. It also happens with image paths.

I'll have a look at fixing it anyway.

Nismo

@fieldofcows No, I'm saying that "save metadata on exit" isn't working, doesn't save anything.

Before it was working, but the issue was that it overwrites videos and marquees relative paths with absolute paths when saving metadata on exit.

Now it doesn't work so that was my confusion, I was thinking that now was working because with "save metadata on exit" enabled the relative paths still ok, but i was wrong, relative paths are ok but even with "save metadata on exit" enabled emulationstation doesn't save anything.

I hope you understand to me now, sorry but my english is not very good.

fieldofcows

@Nismo Hmm... The metadata saves fine for me (and the relative paths are switched to full paths). Have you had a look in the log file to see if there are any errors?

Your English is excellent by the way.

Nismo

@fieldofcows give me one minute to see log.

I have some questions.. Have you read my comment about reverting issue 3? what do you think?

And what about annoying go to desktop when loading games? can be fixed? Do you need a video to see what I mean?

Thanks for you patience.

Nismo

@fieldofcows Ok I deleted old log file, open emulation station, save metadata on exit is enabled, edit the name of one game, i can see the changes inside emulationstation, exit.

Here the log:

lvl2: EmulationStation - v2.0.1a, built Nov 16 2016 - 22:29:20
lvl2: Creating surface...
lvl2: Created window successfully.
lvl2: Added known joystick XInput Controller #1 (instance ID: 0, device index: 0)
lvl2: Checking available OpenGL extensions...
lvl2: ARB_texture_non_power_of_two: ok
lvl2: Loading system config file P://.emulationstation/es_systems.cfg...
lvl2: Parsing XML file "P://.emulationstation/gamelists/sega32x/gamelist.xml"...
lvl2: Parsing XML file "P://.emulationstation/gamelists/atari2600/gamelist.xml"...
lvl2: req sound [video.menuOpen]
lvl2: (missing)
lvl1: OptionListComponent too narrow!
lvl1: OptionListComponent too narrow!

Now I open emulationstation again and my changes are gone, and the gamelist.xml file is untouched.

fieldofcows

@Nismo It should end with

lvl2: EmulationStation cleanly shutting down.

So this indicates it is not exiting cleanly. Try running it with:

emulationstation --debug

and see if you get any more entries in the log to show what is going on.

Also, have a look in the Windows event viewer at "Windows Logs->Application" and see if there are any errors where the source column is "Application error" for emulationstation.exe. If there is then give me the text in the 'general' box. E.g.

Faulting application name: emulationstation.exe, version: 2.0.1.0, time stamp: 0x5823b9dd
Faulting module name: libvlccore.dll, version: 2.2.0.0, time stamp: 0x38a93891
Exception code: 0xc0000005

Regarding issue 3 - I can certainly revert it for now and build you a new version.

Nismo

@fieldofcows Thanks for the tips, i'll take a look right now.

Nismo

@fieldofcows Ok I repeat the same steps than before with debug option enabled, the log is very similar than before, but now on exit i have force close:

lvl2: EmulationStation - v2.0.1a, built Nov 16 2016 - 22:29:20
lvl2: Creating surface...
lvl2: Created window successfully.
lvl2: Added known joystick XInput Controller #1 (instance ID: 0, device index: 0)
lvl2: Checking available OpenGL extensions...
lvl2: ARB_texture_non_power_of_two: ok
lvl2: Loading system config file P://.emulationstation/es_systems.cfg...
lvl2: Parsing XML file "P://.emulationstation/gamelists/atari2600/gamelist.xml"...
lvl2: req sound [video.menuOpen]
lvl2: (missing)
lvl1: OptionListComponent too narrow!
lvl1: OptionListComponent too narrow!
lvl2: req sound [video.menuOpen]
lvl2: (missing)
lvl1: OptionListComponent too narrow!
lvl1: OptionListComponent too narrow!

Now i'll see windows log.

Nismo

@fieldofcows Windows log:

Nombre de la aplicación con errores: emulationstation.exe, versión: 2.0.1.0, marca de tiempo: 0x582cf386
Nombre del módulo con errores: ucrtbase.dll, versión: 10.0.14393.0, marca de tiempo: 0x57898db2
Código de excepción: 0xc0000409
Desplazamiento de errores: 0x000891cb
Identificador del proceso con errores: 0x6084
Hora de inicio de la aplicación con errores: 0x01d2411eba035dc9
Ruta de acceso de la aplicación con errores: P:\emulationstation.exe
Ruta de acceso del módulo con errores: C:\WINDOWS\System32\ucrtbase.dll
Identificador del informe: fbb3ce93-59f0-4caa-aa8a-635b70120108
Nombre completo del paquete con errores:
Identificador de aplicación relativa del paquete con errores:

If you need translation to english tell me.

fieldofcows

@Nismo No need to translate thanks. That's a stack corruption bug. It's going to be hard to find without reproducing it here. Does this still happen if you remove the video from the theme?

Nismo

@fieldofcows ok i'll remove the videos, one minute.

Nismo

@fieldofcows Yes still the same, it's happening since your Issue #7 commit, so maybe you can find what changed there...

The log still no clean exit.

Nismo

@fieldofcows OMG!! I tried all versions beta 1, beta 2, and beta 3 and now no one saves.

Maybe a theme error? if it's saving for you maybe is a problem i have. Sorry so much I need to test this and find what's the problem.

fieldofcows

@Nismo Yes, it's quite possible that the bug is not mine :) That's why I wanted to exclude the video from the theme as it's the most likely to cause an issue.

I've downloaded your theme and I'm transferring my configuration over to Windows to see if I can reproduce this.

Nismo

@fieldofcows Tested with default theme, still doesn't save. Maybe never saved? I'm going crazy.

Yes I remember it saved before because I need to replace all full path with relative paths before I turned off save metadata on exit.

Also I checked that gamelist.xml is not read-only.

Maybe I need to do a clean install :(

fieldofcows

@Nismo Are you sure it's not just taking ages to save the gamelist. I've just set mine up with about 1800 games and it takes minutes to exit. It looks like ES has gone but it's there in the background processing the metadata.

Start ES, exit then look in task manager to see if it is still there taking CPU cycles.

Nismo

@fieldofcows After a lot of hours I've found that is something wrong in my roms folder, that's because doesn't save. I have one folder inside my megadrive's rom folder for unlicensed games. If I removed the folder "unlicensed" inside my roms folder, all works again. Maybe path too long? I don't know, it's supossed to work but not. It's too late here and i'm very tired but almost now you know that was my problem.

Now it saves but still the relative path issue (I use notepad++ and replace relative paths in a second). But if I want to use it portable I need to disable "save metadata on exit" and then it doesn't save ratings and times played, last played, etc. I hope you can fix it soon.

I'm very glad to tell you that now the sound works perfect, even on exit it stop inmediately. For sure was emulationstation didn't clean exit.

Sorry so much for all the headaches.

Omg! it takes to you minutes to exit for saving an xml? I think that something is wrong there. For me it close at the moment. Less than a second, even if I use an slow pendrive USB and i have a lot of games too. (I use the pendrive for testing your builds I usually use a portable 2.5" HDD)

Do you finally try the theme? what do you think? keep in mind that still w.i.p. I don't like that some wheel art is difficult to see on megadrive.

Sorry so so much for all the headaches, thanks for all your tips, support, and take your time for trying to help me. Regards.

Nismo

Updated Oldroom theme to beta 2:

Resized gamelist and logo to see more room and better looking of the theme.
Resized and moved marquee-Wheel art for megadrive theme.
Resized md_image (3d box cartridge) to match 1:1 scales of 3d boxes images downloaded.
Added shadow for 3d box cartridge.
Added empty 3d box cartridge for games without image. This also solves the problem when a game doesn't have image, you still can see the shadow. Whould be better that the 3d boxes images has shadows itself but it doesn't.

Now it's time to add a new system to the theme.

Download: http://www.mediafire.com/file/uzn8re6e5522chl/oldroom_beta_2.zip

Regards.