Flat Theme

[robertybob]

@lilbud Is this ready to be added to the ES themes installer?

[lilbud]

@robertybob I would think so, unfortunately I have no say in accepting themes. Probably have to ask @herb_fargus

[herb_fargus]

@lilbud submit a PR.

[lilbud]

@herb_fargus Where would I submit the PR?

[herb_fargus]

@lilbud https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/supplementary/esthemes.sh

[lilbud]

@herb_fargus Done and Done

[lilbud]

The Flat theme, as well as the dark variant, have been added to the ES-Theme repository

[sergioad]

Famicom Disk system and ports are missing, just reporting ☺ I love the theme but as everybody I want not to see blank pages 😁

[lilbud]

@sergioad Both version of the theme have been updated with support for ports and Famicom Disk System

[sergioad]

@lilbud thank you very much

[sergioad]

Apologies but I have yet another report, PCEngine has a Nintendo logo while it was owned by Hudson software

By the way friend could you add support for optional gamelist scrolling sounds? I want to use the Carbon theme's sounds

[lilbud]

@sergioad logos updated, as for sound, probably not. I have no clue how to add sound.

[herb_fargus]

@lilbud have you tested the theme on older versions of emulationstation without video support?

[sergioad]

@lilbud maybe @Rookervik could help you to add the option of sound

[herb_fargus]

@sergioad just look at themes that have sound and copy the respective code in the XML.

[lilbud]

@herb_fargus No, it only works on the official ES with video support. It would work on @Zigurana ES-Kids branch, but the video tags crash the theme on his ES.

[herb_fargus]

@lilbud little bird tells me if it's done this way it is backward compatible with non video ES:

https://github.com/jrassa/es-theme-carbon/commit/e388e3d5c10be4218fc6c3b3ec1157d35543111e

[lilbud]

@herb_fargus updated both themes like that

[sergioad]

@herb_fargus ok

[herb_fargus]

@lilbud thanks I'll give it a test when I get time :)