Please test: Random Game selection/launch via Video Screensaver

pjft

It is certainly "possible" in the sense that it can be feasible. :) It is not my area of expertise, but doesn't look too complex (famous last words) at first glance.

I may certainly take a look at it in the coming weeks. I might just create a separate screensaver which would be "Random Image". I'm not sure how I feel about mixing videos and images on the same screensaver experience.

Thanks for the suggestion!

lilbud

How about a screensaver, like the windows ones. But pressing "Right" will launch a random game.

pjft

@lilbud said in Please test: Random Game selection/launch via Video Screensaver:

How about a screensaver, like the windows ones. But pressing "Right" will launch a random game.

Sure, a screensaver rotating random images, like the Windows ones, though I take it that pressing a key will launch the game on display at the moment in the screensaver?

Otherwise, that doesn't really need to be tied in any way to the screensaver, I take it, and it's just a completely different use case altogether?

lilbud

Yeah, like the random game option in the ES-KIDS branch.

pjft

@lilbud Got it.

The intention behind this particular experiment here is to merge that with the video (or, maybe in the future, image) screensaver capabilities built by @fieldofcows .

Currently, you can do exactly what the random game option in the ES-Kids branch does, in this experiment - that was part of the inspiration here.

In ES-Kids, you'd:

Open a menu
Select the "Surprise Me" option
Be shown a random game in the gamelist view
Press start to launch, or go back to step 1 if you wanted a new game.

In this experiment, you'll:

Press "select" on the system view screen
Are shown a random game in full-screen video
Press "start" to launch it, or "right" to get a new game.

That's the implementation here. It's not conceptually different to what you're proposing, in the sense that allows you to achieve the same purpose. The difference that @Zigurana's implementation was for the time being inside a menu, and would take you to the gamelist view, whereas this one is accessible via a single button, and takes you to a full-screen video of the random game. It also simplifies selecting subsequent random games. And, if the video screensaver is active, it just uses that so you can immediately launch the game on display.

Hope that makes it clearer.

In any sense, there's a Pull Request from Zigurana to merge his implementation with fieldofcows' work, I believe, in case that's most appealing to you!

Hope that makes it clearer, but definitely give it a shot and see what works for you and what doesn't :)

madmodder123

Since I don't use videos, is there a chance you could add "Random Game Launch" in the Retropie menu? It would be cool if this was implemented without the need to custom compile ES. If you could point me in the right direction I would love it do this! I'll look at the code after work and see if I can mod it, hence the name ;)

pjft

@madmodder123 I'll try to look into adapting this for using images rather than videos only, so that you could achieve something similar, and to make "select" select a random game from the system view, then, if you don't want any of these screensavers.

That will take some time, though, as my free time is unfortunately quite limited. But noted, I will look into that.

My best suggestion for that currently, though, is to use @Zigurana 's ES-Kids fork, as he has that built-in already. There's a page on the Wiki under Kids Friendly EmulationStation, I believe.

Thanks!

pjft

Update on the random game launch:

@Zigurana has already done a lot of work on that in his branch, and has submitted a pull request to merge with fieldofcows' branch as well, in a much more elegant way than I could. As such, I won't be reimplementing that, but rather wait until that is merged over.

For reference, the pull request is

https://github.com/fieldofcows/EmulationStation/pull/16/files

in case you're curious.

For the time being, I'll likely just consider adapting my code to allow an images screensaver as well, as others have already done a much better job at implementing a random game selection :)

For those just looking for that, for the time being the ES Kids fork is the way to go - and I highly recommend it, if you're not using videos. If you are using videos, you may try the release I put here.

Hopefully one day the majority of these things can be merged back to the main branch :)

Zigurana

@pjft :
Thanks for the praise, not sure if I deserve it😅. I added the random game stuff as a PR to @fieldofcows screensaver work, as that was the I was initially envisioning it: as a type of attractive screensaver mode that serves up random game items when idle.
The manual approach was really a test-mode to see if the goto_random function worked well, which turned out to be rather useful, esp. with larger libraries.
I see no problem with adding the button functionality, as I can see how going through the menu is a bit of a pain after 10 games or so.
In that regard, I think we should not make it anymore complicated than necessary, and it does not need to be conflated with the video improvements at all. When using the manual mode, ES will simply jump to a random item, if your setup has videos fine, otherwise it will just show the static art (or even just the single line entry, in case of basic view).

Maybe I will have a look at adding the button from the systemview, should not be difficult. Although now that I think about it, we might want to opt for X or Y, rather than 'select', as that way we can use it in both the systemview and gamelistviews.
Also in my mind 'select' should be a button that 'works' on the selected item. So for instance, pressing 'select' while focusing on the NES system, should/could give a popup window with some additional info on the system, maybe some options related to the system, etc.

pjft

@Zigurana Thanks for the notes. I fully agree it shouldn't be more complicated than it needs to. I also agree with the "select" button semantics you chose - the reason I attached it to that button was because of a chat we had had in GitHub, where you were stating that with the ES-Kids version we already had all face buttons used, so I was more planning for the future.

However, I believe we can reach an interesting compromise/balance here.

We can assign square (Y?) to the random game/video, and use triangle (X?) for the metadata shortcut, as a 4-state toggle:

More than happy to make that change on my end.

What I'd like to consider, though, is how do we eventually get all of this merged back to the main branch. All the stuff you did on ES-Kids should be able to be merged there, provided it is broken down in smaller PRs, and that we fix the few 0-length-index errors that persist when some systems don't have favorites/kids games, and maybe one or two other remaining performance considerations, if relevant.

And same for @fieldofcows ' work on video screensaver. Right now, since I forked my code from @fieldofcows 's fork, I imagine it'd be hard to get my code to go straight to the master RetroPie branch - even if because I'd be submitting code that I did not in any way develop.

Would the two of you be up to considering this - either individually or in a shared repository, and come up with a proper roadmap (more in terms of sequence rather than actual timelines - my day job already has enough of those)? :)

I'm more than happy to work together in the same repository as you, if you feel it'd be the best thing to do. And, for the sake of sequence and stability, I'd definitely believe that the ES-Kids stuff should be easier to be committed, as it's been more thoroughly tested by several people throughout the last year or so at this stage.

And I personally would want to have some sort of closure on the videoplayer before we invest more into merging with the main branch. That's my next investigation in terms of where I'm going to sink some time on, with my limited ability.

Let me know your thoughts.

Zigurana

@pjft :
Thanks for your considerations, I think the four-state toggle is inventive!

My thought-process when thinking about the Kid-Kiosk UI mode branch goes something like this:

Optimist: "Ah, yes, Kidmode stuff to do, let's go team, crush some bugs!"
Pessimist: "Don't you remember that was that part of the code that you rather not look at again, not only because its a mess, but also because you probably wrecked it even more with your so-called features?"
Optimist: "Yes, but this time it will be better, I've got more experience in C++ now. I actually know something about classes this time!"
Pessimist: "Remember, you've started a redesign of this code two times already"
Optimist: "Yes, but this time I've got this great idea!"
Realist: "@fieldofcows is probably much more able to implement a filtering framework, which will make the difficult part of the kid-modes stuff obsolete anyways."
Optimist: "Yes, but..."
Procrastinist: "Hey, look at this new thing you could try to implement, what about chiptune bg music support in ES?"
Optimist: "Wow!"
[/me listens to chiptune music while reading up on SDL_mixer]

Kidding aside, I agree fully with your sentiments, and things have changed a bit since last year. Nowadays there is much more active development in ES going on, and I must say, that is tremendously motivating. Another big change is that I can now do debugging in windows, which should make crushing the bugs at least a feasible proposition. A year ago, I used to do this with logging statements only, not a pretty sight X-P.

I think the kidmode branch could be separated into roughly two deliveries, one focusing on hiding the menu's, and one focusing on the added metadata elements and subsequent filtering of items in the gamelist view. Splitting it up smaller does not really constitute a useful standalone features I think.

My first steps now is to man up, turn up the chiptune noise, and fire up the debugger. I think most people would already be happy with an updated/rebased version of the kidmode branch.

**Scannigan**

@pjft said in Please test: Random Game selection/launch via Video Screensaver:

sudo cp emulationstation /opt/retropie/supplementary/emulationstation/

I've completed your instructions, but getting nothing when pressing select in the system select screen? Is this just for kids/kisok mode?

pjft

@__Scannigan__ Hi Scannigan!

Thanks for trying it out.

No, not at all. You may be perfectly right. You may need to go to the menu, UI settings, and select "Random Video" as your screensaver. Sorry about that omission. Let me know if that fixes it and I'll update the first post.

pjft

@Zigurana :)

Sorry for the delay, yesterday was a chaotic day. I fully empathize with your thought process :) I've been there quite a few times, to be honest, so I don't blame you whatsoever. I'm also at the moment debugging via logging statements, sigh. But chiptune music rocks ;)

I agree that the kidmode branch could probably be split in a couple of deliveries:

Metadata additions (favorites and children)
Filtering based on metadata (favorites and children)
Hiding the menus
Random game (because, why not) :P

But I'm obviously not fully familiar with the architecture. I see these as being fairly isolated yet robust additions to the main branch in their own right.

I'd love to give some feedback on the PR you sent to @fieldofcows , as there are some considerations I'd like to make on it. I'll probably add them there on that conversation. :)

Anyway, good times ahead for ES.

I'm now at least focusing on trying to come up with a future-proof solution for the video player on the Pi. If we decide to move things forward with any of these features, I'm happy to work on these some more, but without solving the video player issues first any further "quality of life" improvements are marginal. :/

**Scannigan**

@pjft Don't have an option for Random Video just Black or Dim

pjft

@__Scannigan__ Hm. That's unfortunate.

I can't claim that there wasn't something wrong with the binary I uploaded. There's a possibility that I uploaded the wrong binary. I will try to check later today.

That being said, there's also the chance that one of the steps is either missing or went wrong, meaning that you may still be running the old emulationstation binary version.

In the current version, you should not only have a "random video" option, but also - if you scroll down in the UI settings menu - you should have three new options: screensaver controls, show game name on screensaver, and launch game from screensaver (or something to that effect). Oh, and there should be an option for "use experimental video player".

If you don't see these there, it's likely something went wrong.

Can you check the contents of .emulationstation/es_settings.cfg , and see if there are any options around OMXPlayer, ScreensaverControls or such?

If you do

ls -l /opt/retropie/supplementary/emulationstation/

What's the date of the emulationstation binary there?

Could you try downloading it on your desktop and copying it to your Raspberry Pi in some other way?

Let me know. I want to make sure I can help you!

**Scannigan**

Nope nothing about OMXPlayer in es.settings.cfg

and this is what I get: -
rw-r--r-- 1 root root 451 Feb 4 00:54 CREDITS.md
-rwxr-xr-x 1 root root 4331160 Mar 10 12:02 emulationstation
-rwxr-xr-x 1 root root 444 Feb 4 00:54 emulationstation.sh
-rw-r--r-- 1 root root 5667 Feb 4 00:54 GAMELISTS.md
-rw-r--r-- 1 root root 11862 Feb 4 00:54 README.md
drwxr-xr-x 3 root root 4096 Mar 10 11:48 scripts
-rw-r--r-- 1 root root 19449 Feb 4 00:54 THEMES.md

pjft

@__Scannigan__

I am so, so sorry. :/ The only reason I can come up with is whether I've uploaded the wrong binary here. I'll have to check when I get home. I imagine this is what a botched launch may be!

Let me try one last thing:

Can you kill emulationstation (i.e. go back to the command line) and then explicitly run emulationstation from there?

cd /opt/retropie/supplementary/emulationstation/
./emulationstation --debug

I just want to triple check that it's running the actual binary you just put there (which I can tell from the date it was just put there).

I will say that my binary file on my computer, at the moment, seems to be slightly larger, taking up 4332016 bytes, but that may be a file system difference. And, also, it might just be the wrong binary.

This is the MD5 for the file I currently have here (can't promise it's the one that it should be):

MD5 (emulationstation) = 891b3b4327a130f31dce82962235cabd

I suspect you may be able to get the MD5 for your file by going to the folder and performing

openssl md5 emulationstation

Is it the same?

Worst case scenario, you could try to compile it (assuming you're comfortable and familiar with the process) but I wouldn't think it'd be necessary to go to that extent.

If you have the latest binaries from RetroPie, this should probably do it. In it I'm including the creation of a folder to compile ES in:

cd /home/pi
mkdir tmp-es
cd tmp-es
git clone https://github.com/pjft/EmulationStation.git
cmake .
make

and then, if all went well,

chmod +x emulationstation
sudo cp emulationstation /opt/retropie/supplementary/emulationstation/

I am sorry for having you spend your time here. Please let me know what you come up with. I'll also double check the binary on my Pi in a few hours when I get home, but I am almost sure that I copied it from my Pi before uploading it so I'm kind of at a loss.

Thank you for your patience and help in troubleshooting this!

**Scannigan**

I can run ES from the command line.

Wouldn't know where to even start with compiling :/

MD5(emulationstation)= 577ffbc8171d5909992dd842f9538900

pjft

Hm.

That doesn't look right.

Can you do this?

cd /home/pi
mkdir tmp-es
cd tmp-es
wget https://github.com/pjft/EmulationStation/releases/download/v0.2/emulationstation
openssl md5 emulationstation
ls -l

And share the results? I'm completely stumped, but I will make sure to get to the bottom of this, though.

EDIT: worst case scenario later at home I'll make sure to get the binary from my Raspberry Pi and upload it again. It might be a case of a wrong binary, but the fact that I'm getting a different MD5 and file size on my end, from the downloaded file, makes me suspicious that something else may be afoot.

If you download the file from https://github.com/pjft/EmulationStation/releases/download/v0.2/emulationstation on your computer, what does it tell you?

Don't worry about compiling, it's more trouble than it's worth it :)

Thanks!

EDIT: ok, I'm a bit more positive about the uploaded binary being correct. I just used a hex editor on the binary, downloaded from GitHub, and I can at least find strings related to random video and the latest additions, so hopefully we should be able to find out what's happening here :)