Please test: Random Game selection/launch via Video Screensaver
-
-
@Zigurana Thanks!
I'm so sorry for the delay in getting back to you - hectic days at work recently.
I'll check the PR later.
I had added the comments in the PR, here:
https://github.com/RetroPie/EmulationStation/pull/118#issuecomment-297463486
If you expand the file in "Show Outdated" you'll see all my remaining comments as well, can you see them there? Let me know if not - it shows as "pending" to me so I'm unsure they're public (and I don't know how to get them out of the "Pending" state) :S Or do I need to "Submit a Review" for the feedback to go through? Maybe that's it? EDIT: I think that was it. I just deleted the review, nevermind. Glad we spoke here!
Anyway, yes, I'm not a stickler for decoupling it. I still think it makes more sense architecturally, though your point is valid on the video thing. It was just a thought, in the hope of re-using the code (or part of it) rather than having duplicate attempts and randomizing a selection.
That being said, if one would want to do it later, then let's have one decouple it (likely me, haha) :)
Oh, but for instance, for implementing a go-to-random-game as a screensaver functionality, you would be able to use exactly the same code as here - though you probably wouldn't want to select it in the view. It's not a big issue anyway :)
I'll compile it and test it in the coming days, hopefully. Then I still need some time to close off my own PR for filtering (sigh).
Out of curiosity (no pressure, really), is implementing the favorites tag in the metadata on your roadmap, so I can also time my filter PR accordingly so it doesn't delay you?
Thanks!
-
@pjft said in Please test: Random Game selection/launch via Video Screensaver:
@Zigurana Thanks!
I'm so sorry for the delay in getting back to you - hectic days at work recently.
I'll check the PR later.
I had added the comments in the PR, here:
https://github.com/RetroPie/EmulationStation/pull/118#issuecomment-297463486
If you expand the file in "Show Outdated" you'll see all my remaining comments as well, can you see them there? Let me know if not - it shows as "pending" to me so I'm unsure they're public (and I don't know how to get them out of the "Pending" state) :S Or do I need to "Submit a Review" for the feedback to go through? Maybe that's it? EDIT: I think that was it. I just deleted the review, nevermind. Glad we spoke here!
Nope still can't see those comments. Maybe you need to validate your email or something?
Anyway, yes, I'm not a stickler for decoupling it. I still think it makes more sense architecturally, though your point is valid on the video thing. It was just a thought, in the hope of re-using the code (or part of it) rather than having duplicate attempts and randomizing a selection.
That being said, if one would want to do it later, then let's have one decouple it (likely me, haha) :)
Yeah, let's cross that bridge when we get there.
Oh, but for instance, for implementing a go-to-random-game as a screensaver functionality, you would be able to use exactly the same code as here - though you probably wouldn't want to select it in the view. It's not a big issue anyway :)
Selection in this context just means: move the cursor to that location. For a screensaver avant-la-lettre, that might be unwanted as it breaks continuity, but for a machine begging you to come and play, it kind of makes sense. Anyways, there are ways to get back to the origin, when implementing a screensaver (/makes mental note).
I'll compile it and test it in the coming days, hopefully. Then I still need some time to close off my own PR for filtering (sigh).
Out of curiosity (no pressure, really), is implementing the favorites tag in the metadata on your roadmap, so I can also time my filter PR accordingly so it doesn't delay you?
As long as your PR #115 is still pending, I will not touch the favorites/kidmode stuff, as much will depend on how that will turn out.
So I would say, do your thing and maybe append it to #115?
Thanks! -
-
@Zigurana Updated the PR. Would love yours and @jdrassa 's thoughts, so that hopefully we can close that. I'm happy to squash it to a single commit, but want the review first so I can ensure code consistency across the OMX build as well.
As for the favorites/kidsmode stuff, what do you mean by appending? Would you want me to add the metadata on my PR?
I'm happy to submit a second PR with adding just those two types of metadata, as well as filters for those (and yes, happy to have them be stored as an option). That being said, I don't have any intention in re-inventing the wheel you have so well invented so far, with the kiosk modes, the changes to the themes, etc, so just let me know if that single piece would help and I'm happy to take that on, using the exact same metadata types as you have in the past - but since you already have it done, I don't want to in any way duplicate work or take credit away from you.
Only if it helps.
Thanks!
-
@pjft Will you be updating your ES to the latest version anytime soon? I just updated mine and I am loving some of the new features, so I'd hate to lose those.
-
@Dominus sure. Anything in particular you're looking for that's not yet in the build?
I might share a script to add to your RetroPie Setup so you can pretty much always install the latest version I have merged. I suspect I might not have provided a binary for the latest one.
Edit: here are the instructions:
https://retropie.org.uk/forum/post/75541
You will want to quit emulationstation when you update it from source, as it may run out of memory otherwise. The latest code there should be 1 week old, hopefully nothing significant came up the last week that you're looking forward to?
Thanks.
The next steps here are actually to try and get this merged into the main ES, so expect that to be my main focus for this work in the coming months.
-
@Dominus said in Please test: Random Game selection/launch via Video Screensaver:
version anytime soon? I just updated mine and I am loving some of
I haven't checked your current version, but I noticed that there was an option for "Surprise Me!" game selection, Filtering the roms by Genre, Players, Played etc..., also the system icons seem a bit different from the last time I updated as well. They are closer together and don't expand larger too much anymore when highlighted.
-
@Dominus most if not all of those should be there. Definitely filtering, as that was something I put together, and the Surprise Me one from @Zigurana made it to the build.
Unsure about what you're referring to in regards to the icons, but as I said the code there should be up to date with ES from a week or so ago. Just follow the instructions here in this post:
-
@pjft After running the script do I still do this:
chmod +x emulationstation
sudo cp emulationstation /opt/retropie/supplementary/emulationstation/EDIT:
Never mind I see no other work is needed! Thanks!
-
@pjft i believe that @Dominus is refering to the system logos and other art in the theme. I believe others have noticed this as well and I think it has to do with the new carousel updates. I don't understand all the ins and outs because I am so focused on my custom theme, but I believe with the new changes that allow for themers to change their size and number of logos may have slighlty modifies how some themes display their logos. I think I am talking in circles. Your build acts appropriately with the updates and matches the main build.
@Dominus you just update using the menu and it installs for you, no need to follow the old method.
-
@pjft This is awesome! Thanks! I am wondering about the text in your video, that displays the game name. Mine doesn't show that, and obviously it could have been taken out after the fact. But is there a way to turn that on, or has it been disabled now?
-
@Dominus I believe that that's on the theme, there used to be a bug on that background and now it's fixed, meaning that some themes will now need to be corrected. What theme are you using?Edit: sorry, completely misunderstood the question. It was late at night.
-
@pjft Oh I am using my own, a variant of the carbon theme.
-
@pjft Oh I found the option in the menu to turn that on. Works great! Thanks again!
-
@Dominus and did you solve the theme bar? @TMNTturtlguy Had to do the same thing in his theme - I believe it's the background color for one of the items?
-
@pjft Everything looks fine on my end, I didn't have to change anything.
-
@Dominus good, sorry. It was quite late at night during our exchange, I must have misread what you meant. I thought you had mentioned that part of the theme had disappeared, but I can't seem to find any mention of that now in the morning. :)
Best.
-
@pjft I just hooked my Pi up to my TV (Usually its on my computer monitor), and now my intro video and the Video Screensavers all go blank and off and on. I tried going into the boot/config.txt and forcing
hdmi_drive=2but its still having issues. Do you know what the fix is for this? I can put it in HDMI safe mode and they play fine, it just looks like garbage lol. -
@Dominus should be related to overscan. Try to set disable overscan in config.txt - there's a previous post by someone else on that. Some particular resolutions and refresh rates mess up some TVs. Not much we can do.
Disabling the screensaver captions is also an option that others have mentioned.
Let us know if that helps!
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.