New Comic Book Theme!

[hansolo77]

@TMNTturtlguy - I see, can't wait to see what happens!

@pjft - That would be the easiest route. I was afraid I'd have to do a bunch of ROM folder creating, moving, editing, etc. If a simple "<favorite>yes|no</favorite>" could be done to a game in a gamelist.xml, that would be easiest.

Now all we need to do is come up with a way for ES to scrape a romlist from RetroAchievments so I can have a menu dedicated to those games, I'd be REALLY happy. :) Right now I just created a subfolder (for instance /RetroPie/roms/nes/_achievements) and copied the roms that have achievements into that folder (making 2 copies). The problem with that is they are always adding new roms, so I have to constantly keep copying more roms. Would be nice if there was an automated way to just build a gamelist.xml that listed those games. Maybe someday!

[jdrassa]

@TMNTturtlguy @ruckage I just submitted a fix for the the rating component. So the default color was being set to white, but it wasn't being initialized properly which caused it to transparent.

Interestingly, with the Comic theme, the ratings were appearing black because the theme is actually setting them to be black.
https://github.com/TMNTturtleguy/es-theme-ComicBook/blob/master/comic_book.xml#L126

The color is being set to black along with all of the text components. I have seen a few themes do this. Previously, the color setting was ignored, but now it is actually being used. You may notice that in this case md_rating is being used on a <text> element. ES will log a warning about this, but won't fail to load the theme.

[TMNTturtlguy]

@jdrassa Thanks for looking into this. I originally had a different icon for the rating and then changed to the graphic. At the time leaving it called out black didn't effect the graphic. I removed md_rating from that line and now I just see light gray transparent shapes for the rating, which aligns with what you are saying above. I will leave it this way and assume that once the fix goes through it will work properly. Thank you!

[TMNTturtlguy]

UPDATE: It's Finally Here!

First, thank you to everyone on the kind words and support over the last few days as my family found things to keep us busy until our power was returned. Power is on and everyone is safe, happy and healthy!

Now to the update! Both the Standard ComicBook (the 16:9) and the 4:3 version have been updated with the exact same materials. The updates are available through the ES Themes on the retropie menu.

The update add support for 22 systems, most of which are custom for custom systems! More information to come regrading how to create a custom system, I would highly recommend using @meleu method here: Create a custom ES system able to launch games for many systems I will provide another method that can be used if you don't want to link the files or if you want to do a standalone system for a cabinet build.

Thanks to @ruckage I have updated the font to support special characters to allow the font to support several languages. Thanks for modifying my text file for me!

Detailed view support has been added to allow for the images and graphics to properly show in the correct places when using detailed view.

Please note that there was a recent update to ES 2 days ago which broke the current rating symbols. A fix has already been submitted to update Emulationstation to fix the problem. Once that fix is approved, the ratings should work again.

Here is a list of updated systems:

• gamecube (gc)
• msx2
• ps2
• pspminis
• wii
• wiiu

Custom Systems Available

• All Games (all games) will be part of a future ES update by @pjft
• Batman (batman)
• Beat'em Up (btmups) You can also use this like the capcom system, simply use the arcade runcommand.
• Favorites (favorites) will be part of a future ES update by @pjft
• Fighting (fighting) You can also use this like the capcom system, simply use the arcade runcommand.
• Kids (kids) do not confuse this with the kids feature in ES - this is just a custom system background
• Last Played (last played) will be part of a future ES update by @pjft
• Light Gun (lightgun) You can also use this like the capcom system, simply use the arcade runcommand.
• Mario (mario)
• Mega Man (mega man)
• Racing (racing)
• Shoot'em Up (shmups) You can also use this like the capcom system, simply use the arcade runcommand.
• Sonic (sonic)
• Sports (sports)
• TMNT (tmnt)
• Trackball (trackball) You can also use this like the capcom system, simply use the arcade runcommand.

And now for the images! These only show 16:9 for sake of time and space! 4:3 are just as nice. Please disregard the gamelist and images, I simply copy a system over and over for testing purposes.

[Zigurana]

@pjft :
Hey man, sorry for the absolute radio-silence these last weeks. Work and family life has been eating away much of my time. :-/

I managed to eek out some time yesterday to continue with the themeing refactoring, which is progressing well! Lots of loose ends to tie up, but the basic functionality to create a basic or detailed GamesListView is mostly in place.

I did not yet continue with the favorites PR, as I anticipated that a lot of that work would become obsolete or irrelevant as a result of the themeing changes.

If you (or @sokiee) want to go ahead and pick up introducing the metadata type, then go ahead. You can pick the existing PR, or look at the kid-mode branch for inspiration.

I don't think it is much use to implement the visualization of favorites in gamelistviews at this point, as some of that is likely to change in the not too far future.

[pjft]

@Zigurana Hi, good morning!

Of course, please. No need to apologize whatsoever - family life, and work, are effectively our main responsibilities :) Glad to hear you're doing well. The theme refactoring is a massive undertaking, though - best of luck with that, and do let us know if you need any testing or motivation :)

I think that you're right, a lot of that work will become obsolete with your current changes. I'm really just scoping down the minimum-viable-product portion of it to add to ES right now - i.e. the fundamentals that won't change.

I was mostly thinking about:

• Having the "favorites" metadata value;
• Showing it in the metadata editor.
• Filtering (since it already exists)
• Optional: Adding the toggle button (unsure, if there's no visualization at this stage, though - likely not).

So yeah. I might ping @sokiee 's PR and ask if we can narrow it down to the scope we agree won't change for now.

If you would have had any particular commit in your branch where it's just these, I'd gladly take them, squash them, and tidy them up for the main branch. We'll see how things go!

Thanks.

@TMNTturtlguy wow. The more I see all these custom systems, the more I think there should be a sustainable way to manage these. I don't want to force people to have to do all the custom runcommand, es_systems and stuff to use these. Let me think about that - after I finish "all" and "last played"... (here's me setting myself up for yet more work).

[meleu]

@TMNTturtlguy Wow man! I think you deserve a couplet:

You've been amusing us with your art
And after the last update you have a place in my heart

[Side note: I discovered a pleasure in making couplets after meeting Isadora Quagmire :) ]

[CodeDrawer]

@meleu Wait, you read a series of unfortunate events? Deadly!

[meleu]

@CodeDrawer said in New Comic Book Theme!:

Wait, you read a series of unfortunate events?

Like aunt Josephine, I love grammar too. Therefore I couldn't avoid to note the way you wrote that question. I think you should write "did you read a series of unfortunate events?". :-)

To be honest I stopped (got distracted by real life issues) when I was reading The Slippery Slope. I want to finish it soon. Did you watch to the Netflix adaptation? I'm enjoying it.

Ooops! I think we're going off-topic... Sorry.

[CodeDrawer]

@meleu I never read the netflix version, just the horrible movie.

[TMNTturtlguy]

A Series of unfortunate .wav files!
......Look away, look away
While I haven't seen the movie, I have watched the Netflix series and it was entertaining.

Back to the topic, unfortunately a few of the launch sounds i tried to implement are not working as expected. Not sure the issue yet, but because I like to keep things tidy and neat I have updated both themes to remove them from the current code. If you have already updated there is no real reason to update again, you may see a failure to launch message for the .wav file. It will not affect your setup at all. If you prefer, update and it will remove the issue.

Thanks

[pjft]

@TMNTturtlguy interesting.

Would it be file encoding/bitrate related? Does EmulationStation log anything when you try to play them?

Anyway, the theme looks gorgeous!

[TMNTturtlguy]

@pjft Thank you! I am not sure, one issue is a file type issue I overlooked and never tested. I thought the TMNT file was a .wav and it was a .mp3. i just threw it in the folder last second and forgot to test it. I don't think .mp3 is a valid format. The other 2 are valid .wav files so I would have to look into it as you suggest. I don't have time at the moment, so for now I have just removed them. When I get more time I will take a deeper look. Thanks

[meleu]

@TMNTturtlguy hey bro, I noticed you've made some custom systems with a space char in the name. They are:

• all games
• last played
• mega man

Not sure if @pjft needs all games and last played with space in the name for his ES development, but I think mega man could be named megaman.

This is not a really big problem, but things are used to work a little better without spaces. :-)

[pjft]

@meleu I don't, actually - originally I had thought of "all", "recent" (for last played, or "lastplayed") but it's an easy change on my end.

Though, for consistency - and potential compatibility - I'd be fully supportive of moving to a name without spaces. As you say, "things are used to work a little better without spaces", as you never know what bugs might come up from using unescaped paths with spaces :)

[TMNTturtlguy]

@pjft @meleu I will make the adjustment and update shortly This is an easy change. i will use the following:

megaman
allgames
lastEdit per @pjft I will use lastplayed

The reason i want to use allgames is because the folder all already exists in the configs folders.

[pjft]

@TMNTturtlguy that's a good call!

In fact, if you'd want to preface them by something - say, auto-allgames, auto-favorites, auto-lastplayed I would not oppose as it would perhaps differentiate itself from any manually created system.

Your call.

[TMNTturtlguy]

@pjft @melu and All

I have updated both themes to remove spaces from the system names and to align with @pjft work in potential updates to ES. Please update from the ES Themes menu. Thank you

[meleu]

@TMNTturtlguy Hey dude! I love it!!!

[TMNTturtlguy]

@meleu That is AWESOME!