Mausberry Shutdown Script Doesn't Save Metadata

hansolo77

OK I went back and re-read your initial suggestion @cyperghost, now that I've explored a little more into this. If there is indeed a way to have ES shut down internally prior to initiating the poweroff, that's the best way to do it. But I don't see a method via the emulationstation.sh script to just exit ES. There are only keys to reboot and shutdown. Am I missing something? It looks like all I need is the command to exit ES.

cyperghost

@hansolo77

rm: cannot remove "/tmp/es-shutdown": Operation not permitted

Ah... this is caused by your GPIO script seems to be runnig as user "ROOT"
So the file es-shutdown is also created by user "ROOT" and can't removed by USER "Pi" which the ES-process belongs to ;)

There is a solution! So I told you:

cyperghost wrote: That worked as I was logged in as user pi - I hope there are no restrictions to file system.

Now if I can only figure out how to get that "error" gone. Perhaps a sudu

Out of the error please add touch /tmp/es-shutdown && chown pi:pi /tmp/es-shutdown instead of only touch /tmp/es-shutdown. Pleaso don't mess around with sudo. The process of your script runs already under root, so there is no need to sudo again.

The error you've posted is a permission error caused by user root, now we change the file to permit user pi ;)

I updated the script posted above, so it should work for all processes now. Can you please test and tell me?

I see in the code you have it doing an echo. That should mean in either case it will display a line indicating which method it is shutting down right? All I'm getting on my screen is

That's just for troubleshooting and indicating, you can remove or comment the lines with # if it works as you want. I still left the else branch for you (it's a useless code piece for now), maybe you need it for a future condition.

I'm also not sure why you have the path with a .* in it. Isn't that path redundant?
opt/retropie/supplementary/.*/emulationstation
I know I'm a total newb to this, but I'm trying to understand...

That's for indicating the binary process and other emulationstations-binaries like emulationstation_kidsmode, emulationstation_powersaver.... without the * you would just kill the ordinary binary emulationstation not more not less. @Buzz and @meleu did a nice job in creating this script. I also appreciate the help of some guys here in the forum so there is no intentention te be called a noob - rookie sounds better :)

here are only keys to reboot and shutdown. Am I missing something? It looks like all I need is the command to exit ES.

To exit ES: It's an internal c++ command. I never needed to exit ES becasue I always log in via SSH if I need a terminal. So I can't give correct answer here how ES can be proper quitted - maybe via killall emulationstation?

As I told you... use the chwon command to change user rights of created file and I've updated the bash script and commented it.

EDIT - the script should work so far but there is space for doing some code optimizings:

I think you can remove waitcommand you initiated because I made an exit and give shutdown control back to ES (but only if binary PID was detected! If the ES binary is not detected the GPIO script runs as usual)
If you want you can remove complete else branch (don't remove fi command!)
you can remove or comment my two echo commands to give if-condition out to screen - it can be used for bug hunting

hansolo77

I almost posted a big grin, until I restarted... The script now displays just one word on the screen when I hit the power button:

Terminated

But when the system came back up, my Last Played collection hadn't saved the most recent game I played. So I think we're back to square one again. :(

pjft

@hansolo77 Just to make sure we're looking at the right part of the problem, what's the result of running ls -lon the folder of the gamelist that should contain the game you last played?

Does the date and time of the file match the time when you rebooted? What's the current date and time of that file?

hansolo77

The date and time didn't update... I just played a game right before testing 10 minutes ago, I see this:

pi@retropie:~ $ ls -l /opt/retropie/configs/all/emulationstation/gamelists/megadrive/
total 1560
-rw-r--r-- 1 pi pi 1594754 Jul 21 01:26 gamelist.xml

pjft

Got it.

So we're looking at the right end of the problem: it's not saving the metadata.

Also, do you have "Save Metadata on Exit" turned on?

Just wanted to check you're not chasing something from the wrong end.

hansolo77

Yeah.. I've never changed it. Just double checked too... I did, however, launch the game via the Favorites collection rather than from the actual system menu.. gonna test that now.

EDIT - Seems like it liked it ok when I ran it from the system menu.. Gonna further test..

pjft

That shouldn't have any effect, to be honest.

hansolo77

LOL WTF...

Now it's working. I tested a different system from my Favorites, exited back to ES then powered off. That most recent game is now at the top of the Last Played list. Go figure. Maybe it just need to go through a complete "reboot" cycle after editing the script? I've also noticed that the Terminated indicator on the screen has gone away.

pjft

I'm thinking that whatever solution you have going on there at the moment is not reliable enough. :)

cyperghost

@pjft I think there was a problem with file permission.
But that should be solved via chmod.

@hansolo77 Can the topic marked as solved? Are there any issues? Can you please post your GPIO script?

hansolo77

I don't want to mark it as solved until I've done further testing. I'd like to see if it still saves if I'm playing a game and shut it down before returning to ES (probably won't, so the script might need updated). I also want to test to see if it saves after I play a game then let the screensaver run for a bit and shutdown during the screensaver. For now, the testing via direct system menu and via the Favorites menu seems to be working. I'm running out for a few hours so I won't be able to test again for some time. But fingers are crossed.

Here's the script as it is right now:

/etc/switch.sh

#!/bin/bash

#this is the GPIO pin connected to the lead on switch labeled OUT
GPIOpin1=23

#this is the GPIO pin connected to the lead on switch labeled IN
GPIOpin2=24

echo "$GPIOpin1" > /sys/class/gpio/export
echo "in" > /sys/class/gpio/gpio$GPIOpin1/direction
echo "$GPIOpin2" > /sys/class/gpio/export
echo "out" > /sys/class/gpio/gpio$GPIOpin2/direction
echo "1" > /sys/class/gpio/gpio$GPIOpin2/value
while [ 1 = 1 ]; do
power=$(cat /sys/class/gpio/gpio$GPIOpin1/value)
if [ $power = 0 ]; then
sleep 1
else

# End Emulationstation if condition of running binary is true (not tested!)
# v1 07/21/17 by cyperghost - Inital run 
# v1.1 07/22/17 - Added chown command to set right user permission for creating es-shutdown
espid=$( pgrep -f "/opt/retropie/supplementary/.*/emulationstation([^.]|$)" ) # PID of binary only
if [ "$espid" ]; then                                                         # Condition: PID is not equal 0 or empty then use ES shutdown
   echo "ES binary is running - I'm using ES internal shutdown"
   touch /tmp/es-shutdown && chown pi:pi /tmp/es-shutdown                     #v1.1 Change file permission of es-shutdown to user:group pi:pi
   pkill -f "/opt/retropie/supplementary/.*/emulationstation([^.]|$)"
   exit
else
   echo "ES binary is closed - I proceed with usual shutdown"
fi
# End Emulationstation if condition of running binary is true (not tested!)

sudo poweroff
fi
done

cyperghost

@hansolo77 Do your testing:
My ratings:

Shutdown between running gaming session - there is nothing that the script can do. If it works, fine if not then take it easy
Shutting down in screensavemode - should work
Shutting down in regular mode - should work (you've tested already)

Have a nice weekend mate - I'm also out for a few hours.

hansolo77

Save metadata during game play:
1st Try, Nope. Loaded a game I never played and shutdown during playing. Upon reboot, Last Played had not been updated.
2nd Try, Nope. Added a game I never played to the Last Playedcollection, verified it was there, then started another. I turned off the system while that game was playing. Upon reboot, the collection had not saved.
Shutting down during screensaver:
1st Try, Nope. I loaded a game, exited, confirmed it existed in the Last Played collection, then let the video screensaver load. When the video was playing, it locked up (video froze, and I was unable recover or access the system via SSH). Had to pull the plug and start over. The list had not saved at this point.
2nd Try, Yup. Same as before, loaded a game, then let the screensaver load. I let it play a few videos to make sure it wasn't locked up, then shut down. Upon rebooting, the Last Played collection had saved.
Shutting down in regular mode:
1st Try, Yup. via System menu (random system). Loaded a game, verified it was in the Last Played, shut down, and it was still there upon reboot.
2nd Try, Yup. via Favorites menu. Loaded a game, verified Last Played updated, shut down, still there upon reboot.
3rd Try, Yup. via Last Played menu. Loaded a game, verified, shut down, rebooted, still there!

Take away - The new additions to the script are working. Thanks @cyperghost!! The only caveat is that you MUST be in ES when you shutdown if you want it to save your metadata. If you shutdown while playing a game, or if the system crashes, nothing is saved. Perhaps a future update to Retropie can get around this by having the gamelist.xml files be saved upon access (loading a game), rather than after returning from a gaming session.

pjft

@hansolo77 The reason that that is not happening is because writing the gamelists is a time consuming process, with time increasing the more content it has. As such, the most effective way to do so is at exit (writing once only).

The metadata is only updated after the game exits and returns to ES, so maybe that's why it's not saving. Try loading a game, exiting from a game, and then loading a game and exiting from within the emulator. See if at least the first game is saved.

hansolo77

Not sure what you mean. Do you mean load a game from RetroArch via the RetroPie menu?

pjft

@hansolo77 no, just two games via EmulationStation. So: play game 1, back to es, play another game, shutdown. We'll see if game 1 is at least stored.

cyperghost

Good morning together, how are you?

@hansolo77 said in Mausberry Shutdown Script Doesn't Save Metadata:

Shutting down during screensaver:
1st Try, Nope. I loaded a game, exited, confirmed it existed in the Last Played collection, then let the video screensaver load. When the video was playing, it locked up (video froze, and I was unable recover or access the system via SSH). Had to pull the plug and start over. The list had not saved at this point.

Oh you use video screensavers -- never usem them so I can't try out. Why there was a lock up? Is that a thing sometimes happen at random or can you investigate? But this has nothing to do with ES status at all.

@pjft said in Mausberry Shutdown Script Doesn't Save Metadata:

@hansolo77 The reason that that is not happening is because writing the gamelists is a time consuming process, with time increasing the more content it has. As such, the most effective way to do so is at exit (writing once only).

That's clear, so it was my intention to provide for regular ES exit. If you search in internet for shutting down ES the killall method is prefered but you know what happens then.

The metadata is only updated after the game exits and returns to ES, so maybe that's why it's not saving. Try loading a game, exiting from a game, and then loading a game and exiting from within the emulator. See if at least the first game is saved.

As far as I understood you mean

Load game X and press "START + SELECT" to return to ES
Load game Y, press the GPIO shutdown

-> result: only game X is showing in Last Played list

Please correct me if I'm wrong :)
Mate? Do you want some coffee,too?

EDIT: Just should write shorter textes, you cleared out but I already understood :)

cyperghost

I rearranged the script a bit
It was written down just for testing purposes - so I made some small improvments that should be better for future maintainment. In v1 and v1.1 you have to change two lines in PID detection. Now I always use the detected PID. I removed echos and the useless else branch.

@hansolo77 version 1.2 is ready for you

#!/bin/bash

#this is the GPIO pin connected to the lead on switch labeled OUT
GPIOpin1=23

#this is the GPIO pin connected to the lead on switch labeled IN
GPIOpin2=24

echo "$GPIOpin1" > /sys/class/gpio/export
echo "in" > /sys/class/gpio/gpio$GPIOpin1/direction
echo "$GPIOpin2" > /sys/class/gpio/export
echo "out" > /sys/class/gpio/gpio$GPIOpin2/direction
echo "1" > /sys/class/gpio/gpio$GPIOpin2/value
while [ 1 = 1 ]; do
power=$(cat /sys/class/gpio/gpio$GPIOpin1/value)
if [ $power = 0 ]; then
sleep 1
else

# End Emulationstation if condition of running binary is true
# v1.0 07/21/17 by cyperghost - Inital run 
# v1.1 07/22/17 - Added chown command to set right user permission for creating es-shutdown
# v1.2 07/23/17 - Some small improvments, easier to maintain, removed echo, removed else branch 
# greetings @pjft for his famous favorits and @meleu for the RegEx sniplet 
espid=$( pgrep -f "/opt/retropie/supplementary/.*/emulationstation([^.]|$)" ) # detect PID of ES binary only
if [ "$espid" ]; then                                                         # Condition: PID is not equal 0 or empty then use ES shutdown
   touch /tmp/es-shutdown && chown pi:pi /tmp/es-shutdown                     #v1.1 Change file permission of es-shutdown to user:group pi:pi
   kill $espid                                                                #v1.2 use kill@detected PID - easier to maintain now!
   exit
fi
# End Emulationstation if condition of running binary is true

sudo poweroff
fi
done

hansolo77

I will try version 1.2 in a little bit. I'm slowly getting familiar with reading scripts and understanding how they work. The various keys and commands I'm totally lost on so I'd need a lot more experience with them to be able to write my own. In the meanwhile, I noticed you changed from pkill to just kill. You sure that will work too? But like I said, will test.

As for testing the games... I've actually played a few games and seen the Last Played collection have them, only to have it not save that list. I think in all experience so far, the only time it's not saving is from a crash. I will try playing a game, exit to ES, verify the game is listed, then play something else and shut down while playing to see if the previous game remains.