RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login

    Mausberry Shutdown Script Doesn't Save Metadata

    Scheduled Pinned Locked Moved ControlBlock, PowerBlock & Co.
    mausberry
    251 Posts 10 Posters 96.7k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • meleuM
      meleu @cyperghost
      last edited by

      @cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

      @meleu yes
      pkill -f "$(sed -n 4p /dev/shm/runcommand.info)" Does not work.

      weird. I'm not able to test on my actual RetroPie, but look the test I've made:

      [PROMPT]$ sleep 1000 &
      [1] 8648
      [PROMPT]$ cat test.info
      1st line
      2nd line
      3rd line
      sleep 1000
      bla
      bla
      bla
      
      [PROMPT]$ pkill -f "$(sed -n 4p test.info)"
      [1]+  Terminated              sleep 1000
      

      But I noticed an issue when the file to look for the 4th line doesn't exist... then my suggestion is to use this

      [[ -f /dev/shm/runcommand.info ]] && pkill -f "$(sed -n 4p /dev/shm/runcommand.info)"
      

      Can you test it on a real RetroPie setup?

      • Useful topics
      • joystick-selection tool
      • rpie-art tool
      • achievements I made
      cyperghostC 1 Reply Last reply Reply Quote 0
      • cyperghostC
        cyperghost @meleu
        last edited by cyperghost

        @meleu Not now ... Have to work :)
        Cya mate!

        meleuM 1 Reply Last reply Reply Quote 0
        • meleuM
          meleu @cyperghost
          last edited by

          @cyperghost I found the problem: that line from runcommand.info has some double quotes wich is confusing the pkill. Here's my current solution:

          rcinfo=/dev/shm/runcommand.info
          [[ -f "$rcinfo" ]] && pkill -f -9 "$(sed -n 4p "$rcinfo" | cut -d' ' -f1)"
          

          I tested on my retropie here and it seems to work. Please test it when you have a chance.

          Cheers!

          • Useful topics
          • joystick-selection tool
          • rpie-art tool
          • achievements I made
          1 Reply Last reply Reply Quote 1
          • hansolo77H
            hansolo77
            last edited by

            You guys are just talking gibberish again. For somebody who's unfamiliar with all of this, I'm completely lost. RetroPie is only my 2nd ever Pi project, and really only my first exposure to the scripting side of it. I'm eager to learn, but throwing out seemingly random lines of code without reference or instruction on where to place it doesn't help me any. :) No biggie, I'll get there. I'm just totally unfamiliar with the commands. set sed, IFS.. totally new to me. I only just learned about top like 4 days ago. ^_^

            So tomorrow after work, would you rather I test @cyperghost's v1.4 or replace that section with @meleu's? Or would it be better to just wait and let ya'll hash it out some more?

            Who's Scruffy Looking?

            meleuM 1 Reply Last reply Reply Quote 0
            • meleuM
              meleu @hansolo77
              last edited by

              @hansolo77 haha... sorry for the nerdy stuff. :)

              my suggestion is to try this:

              espid=$(pgrep -f "/opt/retropie/supplementary/.*/emulationstation([^.]|$)")
              if [ "$espid" ]; then
                  [[ -f "/dev/shm/runcommand.info" ]] \
                  && pkill -f -9 "$(sed -n 4p "/dev/shm/runcommand.info" | cut -d' ' -f1)" \
                  && sleep 4
                  touch /tmp/es-shutdown && chown pi:pi /tmp/es-shutdown
                  kill $espid
              fi
              
              • Useful topics
              • joystick-selection tool
              • rpie-art tool
              • achievements I made
              cyperghostC 1 Reply Last reply Reply Quote 0
              • hansolo77H
                hansolo77
                last edited by hansolo77

                Ok cool. I'm going to bed soon so I will test this tomorrow when I get off work. If not right away, I'm off Thursday, so plenty of time then.

                Who's Scruffy Looking?

                1 Reply Last reply Reply Quote 0
                • cyperghostC
                  cyperghost @meleu
                  last edited by cyperghost

                  @meleu
                  You can even improve :)

                  Edit runcommand-onend.sh and add

                  sudo rm /dev/shm/runcommand.info
                  

                  or make PR to runcommand.sh :)
                  Because runcommand.info isn't removed if emulator ends by start+select button :) It isn't really needed but it's a nice cleanup and definates the addition to the GPIO script you made with more sense.

                  meleuM 1 Reply Last reply Reply Quote 0
                  • meleuM
                    meleu @cyperghost
                    last edited by

                    @cyperghost it can be useful for debugging. I prefer to keep it even after the emulator has finished.

                    • Useful topics
                    • joystick-selection tool
                    • rpie-art tool
                    • achievements I made
                    cyperghostC 1 Reply Last reply Reply Quote 0
                    • cyperghostC
                      cyperghost @meleu
                      last edited by cyperghost

                      @meleu And why do you check presence of runcommand.info in your script? Don't get me wrong but I think the filecheck only makes sense if you remove that after emulator call ends? Because you will always run the "sleep 4"-command even if you are only in ES :)

                      meleuM 1 Reply Last reply Reply Quote 0
                      • meleuM
                        meleu @cyperghost
                        last edited by meleu

                        @cyperghost because if the file doesn't exist that sed will fail and print nothing (empty string).

                        Just for fun do the following

                        1. save all important file you have open.
                        2. perform this command: pkill -f ""
                        3. cry (well, if you saved the files you don't have to cry. as I didn't saved, I cried)

                        Explaining: using an empty string as the pattern matches "everything". And the result is pkilling every single process owned by the pkiller!

                        I noticed it on an unpleasant way. :)

                        • Useful topics
                        • joystick-selection tool
                        • rpie-art tool
                        • achievements I made
                        1 Reply Last reply Reply Quote 0
                        • cyperghostC
                          cyperghost
                          last edited by cyperghost

                          @meleu Okay ... what about this one?
                          It's pretty save and finds out PID of every emulator :)

                          #!/bin/bash
                          emucall=$(sed -n 4p /dev/shm/runcommand.info)
                          emupid=${emucall#* }
                          pos=$(expr ${#emucall} - ${#emupid})
                          emupid=$(pgrep -f ${emucall:0:$pos})
                          kill $emupid
                          

                          Then if PID is a true value kill first the emulator and then kill ES in seconds instance... Thank your for every suggestions - I learn really a lot of your examples!

                          meleuM 1 Reply Last reply Reply Quote 0
                          • meleuM
                            meleu @cyperghost
                            last edited by meleu

                            @cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

                            @meleu Okay ... what about this one?

                            #!/bin/bash
                            emucall=$(sed -n 4p /dev/shm/runcommand.info)
                            emupid=${emucall#* }
                            pos=$(expr ${#emucall} - ${#emupid})
                            emupid=$(pgrep -f ${emucall:0:$pos})
                            kill $emupid
                            

                            Wow! It's a bit complex, isn't it?

                            Yeah, using parameter substitution is a good solution here. But I would simplify it with this:

                            emucall="$(sed -n 4p /dev/shm/runcommand.info)"
                            [[ -n "$emucall" ]] && pkill -f "${emucall% *}"
                            

                            By the way, sometimes I feel like we are messing @hansolo77 's thread with all those bash snippets. I'm going t open a bash thread for us. :-)

                            EDIT: topic created https://retropie.org.uk/forum/topic/11900/shell-scripting-topic

                            • Useful topics
                            • joystick-selection tool
                            • rpie-art tool
                            • achievements I made
                            lostlessL 1 Reply Last reply Reply Quote 0
                            • lostlessL
                              lostless @meleu
                              last edited by

                              @meleu i think it's all relevant. I'm a mauseberry user as well and I find it interesting that I can make it finally function the way it needs to in a retropie setup. If we can get it to quit an emulator, save the sram And then save the meta data for emulation station, the better. I'm elated that my switch now saves meta data when in emulation station. I've had to redo scrapping so many times. 👍

                              1 Reply Last reply Reply Quote 1
                              • hansolo77H
                                hansolo77
                                last edited by

                                Here here! Thanks @lostless :) I knew I wasn't alone in this. And yeah, you guys are just leaving me in the dust with all these snippets. I'd love to learn how to do all that on my own too, but until I do I have to rely on you guys coming up with solutions for me to test and try.

                                I hate to say, I have a migraine again tonight, so I'm not gonna be much help in troubleshooting a new method/addition. But I will try to do it tomorrow since I'm off work.

                                Who's Scruffy Looking?

                                1 Reply Last reply Reply Quote 1
                                • NamErehWonN
                                  NamErehWon
                                  last edited by NamErehWon

                                  Correct me if I'm wrong, but it appears that the script monitoring the GPIO isn't debouncing the input. You would have to hold the button for up to a second depending on where in the sleep you hit it. This should cover debouncing and make it so you could require a hold of a specific length of time.

                                   #GPIO init stuff here
                                   previous_power = 0
                                   while [ 1 = 1 ]; do
                                      power=$(cat /sys/class/gpio/gpio$GPIOpin1/value)
                                      if [$power != $previous_power]; then
                                         sleep 0.05 #might need to be tweaked. You can make it 1s+ to require a hold
                                         power=$(cat /sys/class/gpio/gpio$GPIOpin1/value)
                                         if[$power != 0];then
                                            #shutdown code here
                                         fi
                                      fi
                                      previous_power = $power
                                      #you can put a short sleep here if need be
                                   done
                                  
                                  meleuM cyperghostC 2 Replies Last reply Reply Quote 0
                                  • meleuM
                                    meleu @NamErehWon
                                    last edited by

                                    @namerehwon I don't know the details about this GPIO thing, but I don't think that an infinite loop like that would be a good approach.

                                    Maybe you can improve your script above using inotify-tools like in that script you saw on another thread.

                                    • Useful topics
                                    • joystick-selection tool
                                    • rpie-art tool
                                    • achievements I made
                                    1 Reply Last reply Reply Quote 0
                                    • cyperghostC
                                      cyperghost @NamErehWon
                                      last edited by

                                      @namerehwon Well that's out of our focus. We want to

                                      1. Reboot ES proberly
                                      2. Save metadata in all situation
                                        2.1 In ES mode (solved with version 1.2)
                                        2.2 If any emulator is running (@meleu and @cyperghost coproduction)

                                      But it's a good thing to debounce GPIO keypress but is that needed?
                                      It isn't necessary imho because one keypress will effect an action >> Reboot.
                                      There isn't a toggeling or keypress needed. So it doesn't matter if the signal is produces 1 times or 100 times :) - my personal opinion

                                      caver01C 1 Reply Last reply Reply Quote 0
                                      • caver01C
                                        caver01 @cyperghost
                                        last edited by

                                        @cyperghost but isn't @NamErehWon saying that in the current config, because of the loop timing it may not pickup the button press unless you hold it long enough for a cycle to see it? I have noticed this with my mausberry before I shifted to a python script using edge detection.

                                        Better detection of the button press seems like a good improvement on the script to me even if it expands the scope of the thread a little.

                                        My 4-player cocktail style cabinet built as a custom "roadcase"

                                        1 Reply Last reply Reply Quote 1
                                        • cyperghostC
                                          cyperghost
                                          last edited by

                                          ah okay - thx

                                          1 Reply Last reply Reply Quote 0
                                          • caver01C
                                            caver01
                                            last edited by

                                            That said, once we have a better shutdown procedure, would those of us using mausberry be better served with Python than a bash loop? I have read other posts that say yes. I have also asked this of Mausberry directly, but they are not responsive on their own support forum. In any case, I don't want to hijack the progress being made hear in any way, but I wonder if others are considering Python for this too.

                                            My 4-player cocktail style cabinet built as a custom "roadcase"

                                            cyperghostC 1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                            Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.