Bug? Box art displaying incorrect size the first time I enter a system

j.e.f.f

@TMNTturtlguy I'll give it a shot. Thanks for all your suggestions. I'll report back later with my results.

jdrassa

I spent some time trying to debug this over the weekend. I am not sure what the exact cause is, but it appears to be an issue with the fact that the same image/texture is being loaded twice, for md_image and md_video.

I experienced some weird behavior while messing around with it. Currently, the image is loaded into the VideoComponent and then loaded into the ImageComponent. When I switched this order, all of the images were rendered incorrectly. When I disabled loading the image into the ImageComponent, the image rendered properly. Seems to be a bit of a race condition.

@fieldofcows since md_image and md_video will show the same image, is there any reason to still include md_image on the video view?

j.e.f.f

@jdrassa They don't display the same thing, at least not the way I'm doing it. I have game footage videos and box art for all the games in my collection. I've modified the theme to display them side by side. md_image displays the box art, and md_video displays the game footage.

TMNTturtlguy

@j.e.f.f I just got this to work for me....take the md_image out of the main .xml file for your overall theme, i.e. carbon.xml. place it in your theme.xml. Now ES will be able to load them simultaneously without fighting with each other. I have this working on my build right now.

j.e.f.f

@TMNTturtlguy Awesome! I'll give this a shot tonight! Thanks!

jdrassa

After posting, I did some more digging and I have a fix for the issue. The cause of the problem appears to be that the initial image is set when the view is create, before the theme is applied, and is being sized based on the default values. I am going to submit a fix that will defer setting the image until the view is shown.

TMNTturtlguy

@jdrassa Awesome, that will work as well, sounds like my fix is a work around, but it seems to work.

j.e.f.f

@jdrassa Oh sweet! I'll wait for the fix then... breaking out md_image to the various theme.xml files seems like a bit of a daunting task...

TMNTturtlguy

@j.e.f.f The official fix will is great and probably worth waiting for, just be aware it will only work if you are running the most current ES. I am using a video screensaver build, so I won't be able to take advantage of the fix until the screensaver is added to main ES.

As for the md_image in the themes....how many systems do you have? It took me about 10 minutes to do 16 systems. I just opened up the main .xml and copied the md_image text, opened the theme.xml and pasted it in, saved and was done. Since all the parameters are set it worked like a charm.

j.e.f.f

@TMNTturtlguy So I have two definitions for md_image -- one for detailed view and one for video view. Do I copy both to theme.xml or just the video view one (since detailed view never had the problem)?

jdrassa

The fix has been merged into the RetroPie repository.

TMNTturtlguy

@j.e.f.f just the one from your video view. Here is what my theme.xml looks like:
<view name="basic, detailed, video">

	<image name="logo">
		<path>./art/system.png</path>
		<pos>0.266 0.082</pos>
		<maxSize>0.460 0.126</maxSize>
		<origin>0.5 0.5</origin>
	</image>
	
	<image name="logo2" extra="true">
		<path>./art/controller.svg</path>
		<pos>0.918 0.29</pos>
		<maxSize>0.29 0.13</maxSize>
		<origin>0.5 0.5</origin>
		<color>ffffff</color>
	</image>
	
	<image name="md_image">
		<pos>0.982 0.6</pos>
		<size>0.127 0.149</size>
		<origin>1 1</origin>
	</image>
					
</view>

here is what my main comicbook.xml looks like:
<view name="detailed">

	<image name="md_image">
		<pos>0.67 0.4</pos>
		<maxSize>0.3 0.408</maxSize>
		<origin>0.5 0.5</origin>
	</image>
	
</view>

<view name="video">

	<video name="md_video">
		<pos>0.67 0.4</pos>
		<origin>0.5 0.5</origin>
		<size>0.3 0.408</size>
		<delay>0.05</delay>
		<default></default>
		<showSnapshotNoVideo>true</showSnapshotNoVideo>
		<showSnapshotDelay>false</showSnapshotDelay>
	</video>
	
	<image name="md_marquee">
		<pos>0.74 0.086</pos>
		<maxSize>0.26 0.1</maxSize>
		<origin>0.5 0.5</origin>
	</image>
	
</view>

TMNTturtlguy

@jdrassa Wow that was fast!

j.e.f.f

@jdrassa Thanks! Do I need to update from source in order to get this fix or is from binary OK?

jdrassa

@j.e.f.f not sure. I don't know how often they update the binary.

j.e.f.f

@jdrassa Just wanted to say thank you again! I needed to update from source, but my issue is now fixed!

pjft

@jdrassa apologies for the question, but why do both labels show the same image? I don't understand the semantics behind video showing an image, even when there's not a video, or am I misreading it? I thought of one would want an image to show underneath or to the side of the video, the md_image label was to be used?

Anyway, thanks for digging into this and fixing it!

j.e.f.f

@jdrassa Is it just me or has the system screen changed slightly? Some of the system logos zoom right to the top and bottom edges of the white bar when they are focused (example: Ports, Sega Master System). I could have sworn there used to be some padding .

I understand that the white bar is not themeable, or at least it wasn't... has that changed with this release? Any way to control this?

mattrixk

@j.e.f.f I think the Carousel Mod by Zigurana has been added to RetroPie now, so it will probably be in all new builds.

j.e.f.f

@mattrixk Sweet! More to play with!!