Chicuelo Theme

HurricaneFan · 20 Feb 2018, 17:11

@cosmo0 Chicuelo meant that the version you install from ES theme menu shouldn't have the dots enabled.

cosmo0 · 20 Feb 2018, 18:42

@hurricanefan ah! ok, well, I installed it from esthemes, and it did have the dots, so I guess there's something wrong on GitHub?

HurricaneFan · 20 Feb 2018, 22:57

@cosmo0 Looks like there are possibly 2 versions of the theme.

@chicuelo Which one doesn't have dots included?

chicuelo · 20 Feb 2018, 23:31

@hurricanefan
Sorry I forget to delete the first project, now its available only /es-theme-chicuelo

HurricaneFan · 21 Feb 2018, 14:15

@chicuelo That might break what is in ES Theme installer. I think that one points to /Chicuelo.

https://github.com/RetroPie/RetroPie-Setup/commit/a843bdb734b5b29a8af08d7399c122545b4c2ae3

'chicueloarcade Chicuelo'

mitu · 21 Feb 2018, 14:23

@chicuelo just to expand on @HurricaneFan's observation, the ES theme installer in RetroPie expects the repository name to be called es-theme-<themename>. So if your theme is declared in the installer as chicueloarcade Chicuelo, the installer will check out

github.com/chicueloarcade/es-theme-Chicuelo

If you moved the repository, then the installer will not be able to install/update your theme.

chicuelo · 21 Feb 2018, 15:01

@mitu Thanks, but thats the exact name my repo has: es-theme-Chicuelo so ES will look into there. I assume its working fine

EctoOne · 21 Feb 2018, 15:02

@hurricanefan it should not break it. If you look at the other themes listed, none of them contains the es-theme part. It is just the maintainer name and the plain theme name.

cosmo0 · 21 Feb 2018, 18:03

Excellent! I have updated the theme, and the dots have disappeared :) Thank you !

cosmo0 · 22 Feb 2018, 00:14

Hi @chicuelo !

I have created a pull request to add "SegaCD" and "ports" to your theme : https://github.com/chicueloarcade/es-theme-Chicuelo/pull/1

Please let me know if there is any problem with it ! :)

Thanks

chicuelo · 22 Feb 2018, 16:42

@cosmo0

No problem! feel free to add new systems. As long as you don't publish and make money its okay :D
I use sega 32x as sega CD system, that's why I only create that system.

cosmo0 · 22 Feb 2018, 19:21

@chicuelo of course :)

If you're interested in integrating my changes, open my pull request and click the accept button. It will automatically merge my change in your theme.

Then, in your local copy, do either a fetch and rebase (git fetch then git rebase if you're using a command line, or the corresponding buttons in a GUI) or a pull (git pull) to get the latest changes on your computer.

If you're not interested in my changes, no worries :)

eenricc · 22 Feb 2018, 21:43

@chicuelo It's possible to adapt the theme to monitors with 4:3 or 5:4 resolution? Thanks!!

chicuelo · 23 Feb 2018, 02:48

@cosmo0
Thanks! I will look how to do this, I am not so good with gitHub yet!
I have only some guidelines to add new systems, for the character, it should be one background and a character of a game, the most iconic. And it has to be standed on the ground (not floating). For example in Ports, there are four backgrounds and the logo in the middle. the best option will be using one game and the character to match all other systems.
For the controller, I will try to make that mouse more reallistic, between a render and a fine illustration. Following that your changes will be gorgeous and perfect integrated on the theme!
Thanks for your help!

chicuelo · 23 Feb 2018, 02:51

@eenricc
I tried using this theme on different resolutions, screens and aspect ratios and retropie solved well the display, there was only a little offset on the in-game screenshot in RCA displays with smaller resolution. But it was a little detail, otherwise the theme looked good in every screen I tested so Im not planning to adapt the theme yet

cosmo0 · 23 Feb 2018, 07:46

@chicuelo Yeah I tried to find the most iconic port but I really didn't know what to choose. Doom guy maybe? Yeah in retrospect, I should probably have gone with that...

No need to thank me, you have done all the hard work ;)

cosmo0 · 25 Feb 2018, 00:40

@chicuelo
Hi! I have updated the pull request by changing the "ports" images:

The "character" is now Doom Guy. I even added a shadow under his feets to "ground" him :) I hope it's not too bloody?
In case you wish to change it a little, the source of the image is the Doom wikia

The "controller" has been changed to a Logitech mouse (I just removed the logo). It's a photo (source) but I think it looks fine along the others. What do you think?

chicuelo · 25 Feb 2018, 16:28

@cosmo0
Great! I accepted the pull request and it merged successfully (I think!). The changes are visible now on the repo!

cosmo0 · 25 Feb 2018, 18:47

@chicuelo said in Chicuelo Theme:

@cosmo0
Great! I accepted the pull request and it merged successfully (I think!). The changes are visible now on the repo!

You may have missed something because I don't see it accepted, but it's a good thing, I made some more updates just now :D

the "ports" controller is now a keyboard : it's more easily readable, and integrates better with the other controllers, since it's "up front". The mouse was not "from the front" and it was a little weird.
there is a now a PSP system :)

I'm pumped up to make some more systems... maybe :D

cosmo0 · 25 Feb 2018, 18:55

Ah I see what you did : you have merged the pull request in a branch. I'm not sure what you clicked exactly, it's been a while since I worked with pull requests.

Maybe my pull request is wrong (I should have created a branch). If you can't just merge it into "master", let me know and I will create a new (correct) one.